[U-Boot-Users] [PATCH] ColdFire: Fix missing code flash size for M5485EVB

From: TsiChungLiew Tsi-Chung.Liew@freescale.com
Signed-off-by: James Mahan kmahan@freescale.com Signed-off-by: TsiChung Liew Tsi-Chung.Liew@freescale.com --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile index 0f6cc59..30fda62 100644 --- a/Makefile +++ b/Makefile @@ -1912,7 +1912,7 @@ M5485HFE_config : unconfig M5485EFE_config) BOOT=2;CODE=0;VID=1;USB=1;RAM=64;RAM1=0;; \ M5485FFE_config) BOOT=2;CODE=32;VID=1;USB=1;RAM=64;RAM1=64;; \ M5485GFE_config) BOOT=4;CODE=0;VID=0;USB=0;RAM=64;RAM1=0;; \ - M5485HFE_config) BOOT=2;CODE=;VID=1;USB=0;RAM=64;RAM1=0;; \ + M5485HFE_config) BOOT=2;CODE=16;VID=1;USB=0;RAM=64;RAM1=0;; \ esac; \ >include/config.h ; \ echo "#define CFG_BUSCLK 100000000" > $(obj)include/config.h ; \

Hi u-boot ml, Hi Tsi Chung Liew,
I have the following error compiling the M5475xxx targets:
[code] make[1]: Leaving directory `/mnt/devel/idf/u-boot/common' make -C libfdt/ make[1]: Entering directory `/mnt/devel/idf/u-boot/libfdt' m68k-elf-ar crv libfdt.a make[1]: Leaving directory `/mnt/devel/idf/u-boot/libfdt' UNDEF_SYM=`m68k-elf-objdump -x lib_generic/libgeneric.a board/freescale/common/libfreescale.a board/freescale/m547xevb/libm547xevb.a cpu/mcf547x_8x/libmcf547x_8x.a lib_m68k/libm68k.a fs/cramfs/libcramfs.a fs/fat/libfat.a fs/fdos/libfdos.a fs/jffs2/libjffs2.a fs/reiserfs/libreiserfs.a fs/ext2/libext2fs.a net/libnet.a disk/libdisk.a drivers/bios_emulator/libatibiosemu.a drivers/block/libblock.a drivers/dma/libdma.a drivers/hwmon/libhwmon.a drivers/i2c/libi2c.a drivers/input/libinput.a drivers/misc/libmisc.a drivers/mtd/libmtd.a drivers/mtd/nand/libnand.a drivers/mtd/nand_legacy/libnand_legacy.a drivers/mtd/onenand/libonenand.a drivers/net/libnet.a drivers/net/sk98lin/libsk98lin.a drivers/pci/libpci.a drivers/pcmcia/libpcmcia.a drivers/spi/libspi.a drivers/rtc/librtc.a drivers/serial/libserial.a drivers/usb/libusb.a drivers/video/libvideo.a post/libpost.a post/drivers/libpostdrivers.a common/libcommon.a libfdt/libfdt.a |sed -n -e 's/.*(__u_boot_cmd_.*)/-u\1/p'|sort|uniq`; \ cd /mnt/devel/idf/u-boot && m68k-elf-ld -Bstatic -T /mnt/devel/idf/u-boot/board/freescale/m547xevb/u-boot.lds -Ttext 0xFF800000 -n $UNDEF_SYM cpu/mcf547x_8x/start.o \ --start-group lib_generic/libgeneric.a board/freescale/common/libfreescale.a board/freescale/m547xevb/libm547xevb.a cpu/mcf547x_8x/libmcf547x_8x.a lib_m68k/libm68k.a fs/cramfs/libcramfs.a fs/fat/libfat.a fs/fdos/libfdos.a fs/jffs2/libjffs2.a fs/reiserfs/libreiserfs.a fs/ext2/libext2fs.a net/libnet.a disk/libdisk.a drivers/bios_emulator/libatibiosemu.a drivers/block/libblock.a drivers/dma/libdma.a drivers/hwmon/libhwmon.a drivers/i2c/libi2c.a drivers/input/libinput.a drivers/misc/libmisc.a drivers/mtd/libmtd.a drivers/mtd/nand/libnand.a drivers/mtd/nand_legacy/libnand_legacy.a drivers/mtd/onenand/libonenand.a drivers/net/libnet.a drivers/net/sk98lin/libsk98lin.a drivers/pci/libpci.a drivers/pcmcia/libpcmcia.a drivers/spi/libspi.a drivers/rtc/librtc.a drivers/serial/libserial.a drivers/usb/libusb.a drivers/video/libvideo.a post/libpost.a post/drivers/libpostdrivers.a common/libcommon.a libfdt/libfdt.a --end-group -L /usr/local/lib/gcc/m68k-uclinux/4.1.1 -lgcc \ -Map u-boot.map -o u-boot common/libcommon.a(cmd_bootm.o): In function `do_bootm_vxworks': /mnt/devel/idf/u-boot/common/cmd_bootm.c:1622: undefined reference to `do_bootvx' common/libcommon.a(cmd_bootm.o): In function `do_bootm_qnxelf': /mnt/devel/idf/u-boot/common/cmd_bootm.c:1636: undefined reference to `do_bootelf' common/libcommon.a(env_flash.o): In function `saveenv': /mnt/devel/idf/u-boot/common/env_flash.c:312: undefined reference to `flash_sect_protect' /mnt/devel/idf/u-boot/common/env_flash.c:316: undefined reference to `flash_sect_erase' /mnt/devel/idf/u-boot/common/env_flash.c:329: undefined reference to `flash_sect_protect' make: *** [u-boot] Error 1 [/code]
I fixed the error modifying the common/Makefile: ... -COBJS-$(CONFIG_CMD_ELF) += cmd_elf.o +COBJS-y += cmd_elf.o ... -COBJS-$(CONFIG_CMD_FLASH) += cmd_flash.o +COBJS-y += cmd_flash.o ...
forcing the compiling (and linking) of the cmd_flash.c and cmd_elf.c files.
I also noticed that the targets that define CFG_DRAMSZ1 cannot compile because a "temp" variabile is used but not declared in the m547xevb.c file.
Best regards,
luigi
Il giorno mer, 30/01/2008 alle 15.11 -0600, Tsi-Chung Liew ha scritto:
From: TsiChungLiew Tsi-Chung.Liew@freescale.com
Signed-off-by: James Mahan kmahan@freescale.com Signed-off-by: TsiChung Liew Tsi-Chung.Liew@freescale.com
Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile index 0f6cc59..30fda62 100644 --- a/Makefile +++ b/Makefile @@ -1912,7 +1912,7 @@ M5485HFE_config : unconfig M5485EFE_config) BOOT=2;CODE=0;VID=1;USB=1;RAM=64;RAM1=0;; \ M5485FFE_config) BOOT=2;CODE=32;VID=1;USB=1;RAM=64;RAM1=64;; \ M5485GFE_config) BOOT=4;CODE=0;VID=0;USB=0;RAM=64;RAM1=0;; \
- M5485HFE_config) BOOT=2;CODE=;VID=1;USB=0;RAM=64;RAM1=0;; \
- M5485HFE_config) BOOT=2;CODE=16;VID=1;USB=0;RAM=64;RAM1=0;; \ esac; \
include/config.h ; \echo "#define CFG_BUSCLK 100000000" > $(obj)include/config.h ; \
Ing. Luigi Mantellini Industrie Dial Face S.p.A. Via Canzo, 4 20068 Peschiera Borromeo (MI) Tel.: +39 02 5167 2813 Fax: +39 02 5167 2459 E-mail: luigi.mantellini@idf-hit.com

Luigi,
Is the problem you encountered after you implemented the "Move PPC and M68K ramdiskloading to a common routine" patch or before?
Regards, TsiChung
-----Original Message----- From: Luigi 'Comio' Mantellini [mailto:luigi.mantellini@idf-hit.com] Sent: Monday, February 04, 2008 5:04 PM To: Liew Tsi Chung Cc: U-Boot-Users; Wolfgang Denx; Rigby John; Mahan James Subject: Re: [U-Boot-Users] [PATCH] ColdFire: Fix missing code flash sizefor M5485EVB
Hi u-boot ml, Hi Tsi Chung Liew,
I have the following error compiling the M5475xxx targets:
[code] make[1]: Leaving directory `/mnt/devel/idf/u-boot/common' make -C libfdt/ make[1]: Entering directory `/mnt/devel/idf/u-boot/libfdt' m68k-elf-ar crv libfdt.a make[1]: Leaving directory `/mnt/devel/idf/u-boot/libfdt' UNDEF_SYM=`m68k-elf-objdump -x lib_generic/libgeneric.a board/freescale/common/libfreescale.a board/freescale/m547xevb/libm547xevb.a cpu/mcf547x_8x/libmcf547x_8x.a lib_m68k/libm68k.a fs/cramfs/libcramfs.a fs/fat/libfat.a fs/fdos/libfdos.a fs/jffs2/libjffs2.a fs/reiserfs/libreiserfs.a fs/ext2/libext2fs.a net/libnet.a disk/libdisk.a drivers/bios_emulator/libatibiosemu.a drivers/block/libblock.a drivers/dma/libdma.a drivers/hwmon/libhwmon.a drivers/i2c/libi2c.a drivers/input/libinput.a drivers/misc/libmisc.a drivers/mtd/libmtd.a drivers/mtd/nand/libnand.a drivers/mtd/nand_legacy/libnand_legacy.a drivers/mtd/onenand/libonenand.a drivers/net/libnet.a drivers/net/sk98lin/libsk98lin.a drivers/pci/libpci.a drivers/pcmcia/libpcmcia.a drivers/spi/libspi.a drivers/rtc/librtc.a drivers/serial/libserial.a drivers/usb/libusb.a drivers/video/libvideo.a post/libpost.a post/drivers/libpostdrivers.a common/libcommon.a libfdt/libfdt.a |sed -n -e 's/.*(__u_boot_cmd_.*)/-u\1/p'|sort|uniq`; \ cd /mnt/devel/idf/u-boot && m68k-elf-ld -Bstatic -T /mnt/devel/idf/u-boot/board/freescale/m547xevb/u-boot.lds -Ttext 0xFF800000 -n $UNDEF_SYM cpu/mcf547x_8x/start.o \ --start-group lib_generic/libgeneric.a board/freescale/common/libfreescale.a board/freescale/m547xevb/libm547xevb.a cpu/mcf547x_8x/libmcf547x_8x.a lib_m68k/libm68k.a fs/cramfs/libcramfs.a fs/fat/libfat.a fs/fdos/libfdos.a fs/jffs2/libjffs2.a fs/reiserfs/libreiserfs.a fs/ext2/libext2fs.a net/libnet.a disk/libdisk.a drivers/bios_emulator/libatibiosemu.a drivers/block/libblock.a drivers/dma/libdma.a drivers/hwmon/libhwmon.a drivers/i2c/libi2c.a drivers/input/libinput.a drivers/misc/libmisc.a drivers/mtd/libmtd.a drivers/mtd/nand/libnand.a drivers/mtd/nand_legacy/libnand_legacy.a drivers/mtd/onenand/libonenand.a drivers/net/libnet.a drivers/net/sk98lin/libsk98lin.a drivers/pci/libpci.a drivers/pcmcia/libpcmcia.a drivers/spi/libspi.a drivers/rtc/librtc.a drivers/serial/libserial.a drivers/usb/libusb.a drivers/video/libvideo.a post/libpost.a post/drivers/libpostdrivers.a common/libcommon.a libfdt/libfdt.a --end-group -L /usr/local/lib/gcc/m68k-uclinux/4.1.1 -lgcc \ -Map u-boot.map -o u-boot common/libcommon.a(cmd_bootm.o): In function `do_bootm_vxworks': /mnt/devel/idf/u-boot/common/cmd_bootm.c:1622: undefined reference to `do_bootvx' common/libcommon.a(cmd_bootm.o): In function `do_bootm_qnxelf': /mnt/devel/idf/u-boot/common/cmd_bootm.c:1636: undefined reference to `do_bootelf' common/libcommon.a(env_flash.o): In function `saveenv': /mnt/devel/idf/u-boot/common/env_flash.c:312: undefined reference to `flash_sect_protect' /mnt/devel/idf/u-boot/common/env_flash.c:316: undefined reference to `flash_sect_erase' /mnt/devel/idf/u-boot/common/env_flash.c:329: undefined reference to `flash_sect_protect' make: *** [u-boot] Error 1 [/code]
I fixed the error modifying the common/Makefile: ... -COBJS-$(CONFIG_CMD_ELF) += cmd_elf.o +COBJS-y += cmd_elf.o ... -COBJS-$(CONFIG_CMD_FLASH) += cmd_flash.o +COBJS-y += cmd_flash.o ...
forcing the compiling (and linking) of the cmd_flash.c and cmd_elf.c files.
I also noticed that the targets that define CFG_DRAMSZ1 cannot compile because a "temp" variabile is used but not declared in the m547xevb.c file.
Best regards,
luigi
Il giorno mer, 30/01/2008 alle 15.11 -0600, Tsi-Chung Liew ha scritto:
From: TsiChungLiew Tsi-Chung.Liew@freescale.com
Signed-off-by: James Mahan kmahan@freescale.com Signed-off-by: TsiChung Liew Tsi-Chung.Liew@freescale.com
Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile index 0f6cc59..30fda62 100644 --- a/Makefile +++ b/Makefile @@ -1912,7 +1912,7 @@ M5485HFE_config : unconfig M5485EFE_config)
BOOT=2;CODE=0;VID=1;USB=1;RAM=64;RAM1=0;; \
M5485FFE_config)
BOOT=2;CODE=32;VID=1;USB=1;RAM=64;RAM1=64;; \
M5485GFE_config)
BOOT=4;CODE=0;VID=0;USB=0;RAM=64;RAM1=0;; \
- M5485HFE_config) BOOT=2;CODE=;VID=1;USB=0;RAM=64;RAM1=0;;
\
- M5485HFE_config)
BOOT=2;CODE=16;VID=1;USB=0;RAM=64;RAM1=0;; \
esac; \
include/config.h ; \
echo "#define CFG_BUSCLK 100000000" >
$(obj)include/config.h ; \
Ing. Luigi Mantellini Industrie Dial Face S.p.A. Via Canzo, 4 20068 Peschiera Borromeo (MI) Tel.: +39 02 5167 2813 Fax: +39 02 5167 2459 E-mail: luigi.mantellini@idf-hit.com

Hi TsiChung,
I'm using the actual master head of the git-tree... then I think without the patch set.
luigi
On lun, 2008-02-04 at 16:44 -0700, Liew Tsi Chung wrote:
Luigi,
Is the problem you encountered after you implemented the "Move PPC and M68K ramdiskloading to a common routine" patch or before?
Regards, TsiChung
-----Original Message----- From: Luigi 'Comio' Mantellini [mailto:luigi.mantellini@idf-hit.com] Sent: Monday, February 04, 2008 5:04 PM To: Liew Tsi Chung Cc: U-Boot-Users; Wolfgang Denx; Rigby John; Mahan James Subject: Re: [U-Boot-Users] [PATCH] ColdFire: Fix missing code flash sizefor M5485EVB
Hi u-boot ml, Hi Tsi Chung Liew,
I have the following error compiling the M5475xxx targets:
[code] make[1]: Leaving directory `/mnt/devel/idf/u-boot/common' make -C libfdt/ make[1]: Entering directory `/mnt/devel/idf/u-boot/libfdt' m68k-elf-ar crv libfdt.a make[1]: Leaving directory `/mnt/devel/idf/u-boot/libfdt' UNDEF_SYM=`m68k-elf-objdump -x lib_generic/libgeneric.a board/freescale/common/libfreescale.a board/freescale/m547xevb/libm547xevb.a cpu/mcf547x_8x/libmcf547x_8x.a lib_m68k/libm68k.a fs/cramfs/libcramfs.a fs/fat/libfat.a fs/fdos/libfdos.a fs/jffs2/libjffs2.a fs/reiserfs/libreiserfs.a fs/ext2/libext2fs.a net/libnet.a disk/libdisk.a drivers/bios_emulator/libatibiosemu.a drivers/block/libblock.a drivers/dma/libdma.a drivers/hwmon/libhwmon.a drivers/i2c/libi2c.a drivers/input/libinput.a drivers/misc/libmisc.a drivers/mtd/libmtd.a drivers/mtd/nand/libnand.a drivers/mtd/nand_legacy/libnand_legacy.a drivers/mtd/onenand/libonenand.a drivers/net/libnet.a drivers/net/sk98lin/libsk98lin.a drivers/pci/libpci.a drivers/pcmcia/libpcmcia.a drivers/spi/libspi.a drivers/rtc/librtc.a drivers/serial/libserial.a drivers/usb/libusb.a drivers/video/libvideo.a post/libpost.a post/drivers/libpostdrivers.a common/libcommon.a libfdt/libfdt.a |sed -n -e 's/.*(__u_boot_cmd_.*)/-u\1/p'|sort|uniq`; \ cd /mnt/devel/idf/u-boot && m68k-elf-ld -Bstatic -T /mnt/devel/idf/u-boot/board/freescale/m547xevb/u-boot.lds -Ttext 0xFF800000 -n $UNDEF_SYM cpu/mcf547x_8x/start.o \ --start-group lib_generic/libgeneric.a board/freescale/common/libfreescale.a board/freescale/m547xevb/libm547xevb.a cpu/mcf547x_8x/libmcf547x_8x.a lib_m68k/libm68k.a fs/cramfs/libcramfs.a fs/fat/libfat.a fs/fdos/libfdos.a fs/jffs2/libjffs2.a fs/reiserfs/libreiserfs.a fs/ext2/libext2fs.a net/libnet.a disk/libdisk.a drivers/bios_emulator/libatibiosemu.a drivers/block/libblock.a drivers/dma/libdma.a drivers/hwmon/libhwmon.a drivers/i2c/libi2c.a drivers/input/libinput.a drivers/misc/libmisc.a drivers/mtd/libmtd.a drivers/mtd/nand/libnand.a drivers/mtd/nand_legacy/libnand_legacy.a drivers/mtd/onenand/libonenand.a drivers/net/libnet.a drivers/net/sk98lin/libsk98lin.a drivers/pci/libpci.a drivers/pcmcia/libpcmcia.a drivers/spi/libspi.a drivers/rtc/librtc.a drivers/serial/libserial.a drivers/usb/libusb.a drivers/video/libvideo.a post/libpost.a post/drivers/libpostdrivers.a common/libcommon.a libfdt/libfdt.a --end-group -L /usr/local/lib/gcc/m68k-uclinux/4.1.1 -lgcc \ -Map u-boot.map -o u-boot common/libcommon.a(cmd_bootm.o): In function `do_bootm_vxworks': /mnt/devel/idf/u-boot/common/cmd_bootm.c:1622: undefined reference to `do_bootvx' common/libcommon.a(cmd_bootm.o): In function `do_bootm_qnxelf': /mnt/devel/idf/u-boot/common/cmd_bootm.c:1636: undefined reference to `do_bootelf' common/libcommon.a(env_flash.o): In function `saveenv': /mnt/devel/idf/u-boot/common/env_flash.c:312: undefined reference to `flash_sect_protect' /mnt/devel/idf/u-boot/common/env_flash.c:316: undefined reference to `flash_sect_erase' /mnt/devel/idf/u-boot/common/env_flash.c:329: undefined reference to `flash_sect_protect' make: *** [u-boot] Error 1 [/code]
I fixed the error modifying the common/Makefile: ... -COBJS-$(CONFIG_CMD_ELF) += cmd_elf.o +COBJS-y += cmd_elf.o ... -COBJS-$(CONFIG_CMD_FLASH) += cmd_flash.o +COBJS-y += cmd_flash.o ...
forcing the compiling (and linking) of the cmd_flash.c and cmd_elf.c files.
I also noticed that the targets that define CFG_DRAMSZ1 cannot compile because a "temp" variabile is used but not declared in the m547xevb.c file.
Best regards,
luigi
Il giorno mer, 30/01/2008 alle 15.11 -0600, Tsi-Chung Liew ha scritto:
From: TsiChungLiew Tsi-Chung.Liew@freescale.com
Signed-off-by: James Mahan kmahan@freescale.com Signed-off-by: TsiChung Liew Tsi-Chung.Liew@freescale.com
Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile index 0f6cc59..30fda62 100644 --- a/Makefile +++ b/Makefile @@ -1912,7 +1912,7 @@ M5485HFE_config : unconfig M5485EFE_config)
BOOT=2;CODE=0;VID=1;USB=1;RAM=64;RAM1=0;; \
M5485FFE_config)
BOOT=2;CODE=32;VID=1;USB=1;RAM=64;RAM1=64;; \
M5485GFE_config)
BOOT=4;CODE=0;VID=0;USB=0;RAM=64;RAM1=0;; \
- M5485HFE_config) BOOT=2;CODE=;VID=1;USB=0;RAM=64;RAM1=0;;
\
- M5485HFE_config)
BOOT=2;CODE=16;VID=1;USB=0;RAM=64;RAM1=0;; \
esac; \
include/config.h ; \
echo "#define CFG_BUSCLK 100000000" >
$(obj)include/config.h ; \
Ing. Luigi Mantellini Industrie Dial Face S.p.A. Via Canzo, 4 20068 Peschiera Borromeo (MI) Tel.: +39 02 5167 2813 Fax: +39 02 5167 2459 E-mail: luigi.mantellini@idf-hit.com
Industrie Dial Face S.p.A. Luigi Mantellini R&D - Software Industrie Dial Face S.p.A. Via Canzo, 4 20068 Peschiera Borromeo (MI), Italy Tel.: +39 02 5167 2813 Fax: +39 02 5167 2459 E-mail: luigi.mantellini@idf-hit.com
participants (3)
-
Liew Tsi Chung
-
Luigi 'Comio' Mantellini
-
Tsi-Chung Liew