[U-Boot] [PATCH v2 0/4] Add support new arch: c6x
C6X (C6000) is family of fixed and floating-point DSPs manufactured by Texas Instruments.
Signed-off-by: Dmitry Bondar bond@inmys.ru Cc: Tom Rini trini@ti.com
--- Changes for v2: - davinci SOC reset_c.c rewritten with readl/writel. - Tom Rini trini@ti.com added to cc
Dmitry Bondar (4): Add support new arch: c6x c6x: Add support c674x CPUs c6x: Add suport build davinci SOC with c674x CPUs c6x: Add support c6745-som board
MAINTAINERS | 3 + Makefile | 1 + arch/arm/cpu/arm926ejs/davinci/Makefile | 5 + arch/arm/cpu/arm926ejs/davinci/reset_c.c | 31 +++ arch/c6x/config.mk | 1 + arch/c6x/cpu/c674x/Makefile | 30 +++ arch/c6x/cpu/c674x/cache.c | 17 ++ arch/c6x/cpu/c674x/config.mk | 14 + arch/c6x/cpu/c674x/start.S | 22 ++ arch/c6x/cpu/u-boot.lds | 76 ++++++ arch/c6x/include/asm/bitops.h | 88 +++++++ arch/c6x/include/asm/byteorder.h | 1 + arch/c6x/include/asm/cache.h | 29 ++ arch/c6x/include/asm/config.h | 3 + arch/c6x/include/asm/errno.h | 1 + arch/c6x/include/asm/global_data.h | 88 +++++++ arch/c6x/include/asm/gpio.h | 2 + arch/c6x/include/asm/io.h | 53 ++++ arch/c6x/include/asm/posix_types.h | 72 ++++++ arch/c6x/include/asm/processor.h | 4 + arch/c6x/include/asm/ptrace.h | 302 ++++++++++++++++++++++ arch/c6x/include/asm/sizes.h | 51 ++++ arch/c6x/include/asm/string.h | 26 ++ arch/c6x/include/asm/types.h | 53 ++++ arch/c6x/include/asm/u-boot.h | 57 ++++ arch/c6x/include/asm/unaligned.h | 1 + arch/c6x/lib/Makefile | 51 ++++ arch/c6x/lib/board.c | 201 +++++++++++++++ arch/c6x/lib/bootm.c | 59 +++++ arch/c6x/lib/csum_64plus.S | 408 ++++++++++++++++++++++++++++++ arch/c6x/lib/delay.S | 39 +++ arch/c6x/lib/divi.S | 54 ++++ arch/c6x/lib/divremi.S | 61 +++++ arch/c6x/lib/divremu.S | 86 +++++++ arch/c6x/lib/divu.S | 100 ++++++++ arch/c6x/lib/divull.c | 336 ++++++++++++++++++++++++ arch/c6x/lib/llshl.S | 36 +++ arch/c6x/lib/llshr.S | 36 +++ arch/c6x/lib/llshru.S | 36 +++ arch/c6x/lib/memcmp.c | 24 ++ arch/c6x/lib/memcpy_64plus.S | 45 ++++ arch/c6x/lib/memmove.c | 30 +++ arch/c6x/lib/memset.c | 20 ++ arch/c6x/lib/mpyll.S | 47 ++++ arch/c6x/lib/negll.S | 29 ++ arch/c6x/lib/pop_rts.S | 30 +++ arch/c6x/lib/push_rts.S | 28 ++ arch/c6x/lib/remi.S | 78 ++++++ arch/c6x/lib/remu.S | 81 ++++++ arch/c6x/lib/strasgi.S | 88 +++++++ arch/c6x/lib/strasgi_64plus.S | 37 +++ arch/c6x/lib/unaligned.S | 117 +++++++++ board/inmys/c6745-som/Makefile | 27 ++ board/inmys/c6745-som/c6745-som.c | 247 ++++++++++++++++++ boards.cfg | 1 + common/cmd_bdinfo.c | 5 + common/image.c | 4 + examples/standalone/stubs.c | 15 + include/configs/c6745-som-inmys.h | 294 +++++++++++++++++++++ mkconfig | 7 +- 60 files changed, 3787 insertions(+), 1 deletions(-) create mode 100644 arch/arm/cpu/arm926ejs/davinci/reset_c.c create mode 100644 arch/c6x/config.mk create mode 100644 arch/c6x/cpu/c674x/Makefile create mode 100644 arch/c6x/cpu/c674x/cache.c create mode 100644 arch/c6x/cpu/c674x/config.mk create mode 100644 arch/c6x/cpu/c674x/start.S create mode 100644 arch/c6x/cpu/u-boot.lds create mode 100644 arch/c6x/include/asm/bitops.h create mode 100644 arch/c6x/include/asm/byteorder.h create mode 100644 arch/c6x/include/asm/cache.h create mode 100644 arch/c6x/include/asm/config.h create mode 100644 arch/c6x/include/asm/errno.h create mode 100644 arch/c6x/include/asm/global_data.h create mode 100644 arch/c6x/include/asm/gpio.h create mode 100644 arch/c6x/include/asm/io.h create mode 100644 arch/c6x/include/asm/posix_types.h create mode 100644 arch/c6x/include/asm/processor.h create mode 100644 arch/c6x/include/asm/ptrace.h create mode 100644 arch/c6x/include/asm/sizes.h create mode 100644 arch/c6x/include/asm/string.h create mode 100644 arch/c6x/include/asm/types.h create mode 100644 arch/c6x/include/asm/u-boot.h create mode 100644 arch/c6x/include/asm/unaligned.h create mode 100644 arch/c6x/lib/Makefile create mode 100644 arch/c6x/lib/board.c create mode 100644 arch/c6x/lib/bootm.c create mode 100644 arch/c6x/lib/csum_64plus.S create mode 100644 arch/c6x/lib/delay.S create mode 100644 arch/c6x/lib/divi.S create mode 100644 arch/c6x/lib/divremi.S create mode 100644 arch/c6x/lib/divremu.S create mode 100644 arch/c6x/lib/divu.S create mode 100644 arch/c6x/lib/divull.c create mode 100644 arch/c6x/lib/llshl.S create mode 100644 arch/c6x/lib/llshr.S create mode 100644 arch/c6x/lib/llshru.S create mode 100644 arch/c6x/lib/memcmp.c create mode 100644 arch/c6x/lib/memcpy_64plus.S create mode 100644 arch/c6x/lib/memmove.c create mode 100644 arch/c6x/lib/memset.c create mode 100644 arch/c6x/lib/mpyll.S create mode 100644 arch/c6x/lib/negll.S create mode 100644 arch/c6x/lib/pop_rts.S create mode 100644 arch/c6x/lib/push_rts.S create mode 100644 arch/c6x/lib/remi.S create mode 100644 arch/c6x/lib/remu.S create mode 100644 arch/c6x/lib/strasgi.S create mode 100644 arch/c6x/lib/strasgi_64plus.S create mode 100644 arch/c6x/lib/unaligned.S create mode 100644 board/inmys/c6745-som/Makefile create mode 100644 board/inmys/c6745-som/c6745-som.c create mode 100644 include/configs/c6745-som-inmys.h
Dear Dmitry Bondar,
In message 1340449870-26456-1-git-send-email-bond@inmys.ru you wrote:
C6X (C6000) is family of fixed and floating-point DSPs manufactured by Texas Instruments.
Signed-off-by: Dmitry Bondar bond@inmys.ru Cc: Tom Rini trini@ti.com
Changes for v2:
- davinci SOC reset_c.c rewritten with readl/writel.
- Tom Rini trini@ti.com added to cc
Please run your patches through checkpatch and fix the issues. Then try and resubmit:
WARNING: do not add new typedefs #377: FILE: arch/c6x/include/asm/global_data.h:36: +typedef struct global_data {
WARNING: line over 80 characters #418: FILE: arch/c6x/include/asm/global_data.h:77: +#define GD_FLG_RELOC 0x00001 /* Code was relocated to RAM */
WARNING: line over 80 characters #419: FILE: arch/c6x/include/asm/global_data.h:78: +#define GD_FLG_DEVINIT 0x00002 /* Devices have been initialized */
WARNING: line over 80 characters #420: FILE: arch/c6x/include/asm/global_data.h:79: +#define GD_FLG_SILENT 0x00004 /* Silent mode */
WARNING: line over 80 characters #421: FILE: arch/c6x/include/asm/global_data.h:80: +#define GD_FLG_POSTFAIL 0x00008 /* Critical POST test failed */
WARNING: line over 80 characters #422: FILE: arch/c6x/include/asm/global_data.h:81: +#define GD_FLG_POSTSTOP 0x00010 /* POST seqeunce aborted */
WARNING: line over 80 characters #423: FILE: arch/c6x/include/asm/global_data.h:82: +#define GD_FLG_LOGINIT 0x00020 /* Log Buffer has been initialized */
WARNING: line over 80 characters #424: FILE: arch/c6x/include/asm/global_data.h:83: +#define GD_FLG_DISABLE_CONSOLE 0x00040 /* Disable console (in & out) */
WARNING: line over 80 characters #425: FILE: arch/c6x/include/asm/global_data.h:84: +#define GD_FLG_ENV_READY 0x00080 /* Environment imported into hash table */
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #427: FILE: arch/c6x/include/asm/global_data.h:86: +#define DECLARE_GLOBAL_DATA_PTR register volatile gd_t *gd asm ("B31")
WARNING: line over 80 characters #457: FILE: arch/c6x/include/asm/io.h:14: +static inline unsigned char __readb(volatile unsigned char *addr) { return (*addr); }
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #457: FILE: arch/c6x/include/asm/io.h:14: +static inline unsigned char __readb(volatile unsigned char *addr) { return (*addr); }
WARNING: line over 80 characters #458: FILE: arch/c6x/include/asm/io.h:15: +static inline unsigned short __readw(volatile unsigned short *addr) { return (*addr); }
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #458: FILE: arch/c6x/include/asm/io.h:15: +static inline unsigned short __readw(volatile unsigned short *addr) { return (*addr); }
WARNING: line over 80 characters #459: FILE: arch/c6x/include/asm/io.h:16: +static inline unsigned long __readl(volatile unsigned int *addr) { return (*addr); }
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #459: FILE: arch/c6x/include/asm/io.h:16: +static inline unsigned long __readl(volatile unsigned int *addr) { return (*addr); }
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #461: FILE: arch/c6x/include/asm/io.h:18: +#define readb(addr) __readb((volatile unsigned char *) (addr))
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #462: FILE: arch/c6x/include/asm/io.h:19: +#define readw(addr) __readw((volatile unsigned short *) (addr))
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #463: FILE: arch/c6x/include/asm/io.h:20: +#define readl(addr) __readl((volatile unsigned int *) (addr))
ERROR: space required after that ',' (ctx:VxV) #465: FILE: arch/c6x/include/asm/io.h:22: +#define writeb(b,addr) ((*(volatile unsigned char *) (addr)) = (b)) ^
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #465: FILE: arch/c6x/include/asm/io.h:22: +#define writeb(b,addr) ((*(volatile unsigned char *) (addr)) = (b))
ERROR: space required after that ',' (ctx:VxV) #466: FILE: arch/c6x/include/asm/io.h:23: +#define writew(b,addr) ((*(volatile unsigned short *) (addr)) = (b)) ^
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #466: FILE: arch/c6x/include/asm/io.h:23: +#define writew(b,addr) ((*(volatile unsigned short *) (addr)) = (b))
ERROR: space required after that ',' (ctx:VxV) #467: FILE: arch/c6x/include/asm/io.h:24: +#define writel(b,addr) ((*(volatile unsigned int *) (addr)) = (b)) ^
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #467: FILE: arch/c6x/include/asm/io.h:24: +#define writel(b,addr) ((*(volatile unsigned int *) (addr)) = (b))
WARNING: line over 80 characters #478: FILE: arch/c6x/include/asm/io.h:35: + ({ unsigned short __v = le16_to_cpu(*(volatile unsigned short *) (addr)); __v; })
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #478: FILE: arch/c6x/include/asm/io.h:35: + ({ unsigned short __v = le16_to_cpu(*(volatile unsigned short *) (addr)); __v; })
WARNING: line over 80 characters #480: FILE: arch/c6x/include/asm/io.h:37: + ({ unsigned int __v = le32_to_cpu(*(volatile unsigned int *) (addr)); __v; })
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #480: FILE: arch/c6x/include/asm/io.h:37: + ({ unsigned int __v = le32_to_cpu(*(volatile unsigned int *) (addr)); __v; })
WARNING: line over 80 characters #481: FILE: arch/c6x/include/asm/io.h:38: +#define out_le16(addr,w) (void)((*(volatile unsigned short *) (addr)) = cpu_to_le16(w))
ERROR: space required after that ',' (ctx:VxV) #481: FILE: arch/c6x/include/asm/io.h:38: +#define out_le16(addr,w) (void)((*(volatile unsigned short *) (addr)) = cpu_to_le16(w)) ^
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #481: FILE: arch/c6x/include/asm/io.h:38: +#define out_le16(addr,w) (void)((*(volatile unsigned short *) (addr)) = cpu_to_le16(w))
WARNING: line over 80 characters #482: FILE: arch/c6x/include/asm/io.h:39: +#define out_le32(addr,l) (void)((*(volatile unsigned int *) (addr)) = cpu_to_le32(l))
ERROR: space required after that ',' (ctx:VxV) #482: FILE: arch/c6x/include/asm/io.h:39: +#define out_le32(addr,l) (void)((*(volatile unsigned int *) (addr)) = cpu_to_le32(l)) ^
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #482: FILE: arch/c6x/include/asm/io.h:39: +#define out_le32(addr,l) (void)((*(volatile unsigned int *) (addr)) = cpu_to_le32(l))
WARNING: do not add new typedefs #520: FILE: arch/c6x/include/asm/posix_types.h:18: +typedef unsigned int __kernel_dev_t;
WARNING: do not add new typedefs #521: FILE: arch/c6x/include/asm/posix_types.h:19: +typedef unsigned long __kernel_ino_t;
WARNING: do not add new typedefs #522: FILE: arch/c6x/include/asm/posix_types.h:20: +typedef unsigned long long __kernel_ino64_t;
WARNING: do not add new typedefs #523: FILE: arch/c6x/include/asm/posix_types.h:21: +typedef unsigned int __kernel_mode_t;
WARNING: do not add new typedefs #524: FILE: arch/c6x/include/asm/posix_types.h:22: +typedef unsigned int __kernel_nlink_t;
WARNING: do not add new typedefs #525: FILE: arch/c6x/include/asm/posix_types.h:23: +typedef long __kernel_off_t;
WARNING: do not add new typedefs #526: FILE: arch/c6x/include/asm/posix_types.h:24: +typedef long long __kernel_loff_t;
WARNING: do not add new typedefs #527: FILE: arch/c6x/include/asm/posix_types.h:25: +typedef int __kernel_pid_t;
WARNING: do not add new typedefs #528: FILE: arch/c6x/include/asm/posix_types.h:26: +typedef unsigned short __kernel_ipc_pid_t;
WARNING: do not add new typedefs #529: FILE: arch/c6x/include/asm/posix_types.h:27: +typedef unsigned int __kernel_uid_t;
WARNING: do not add new typedefs #530: FILE: arch/c6x/include/asm/posix_types.h:28: +typedef unsigned int __kernel_gid_t;
WARNING: do not add new typedefs #531: FILE: arch/c6x/include/asm/posix_types.h:29: +typedef unsigned int __kernel_size_t;
WARNING: do not add new typedefs #532: FILE: arch/c6x/include/asm/posix_types.h:30: +typedef int __kernel_ssize_t;
WARNING: do not add new typedefs #533: FILE: arch/c6x/include/asm/posix_types.h:31: +typedef int __kernel_ptrdiff_t;
WARNING: do not add new typedefs #534: FILE: arch/c6x/include/asm/posix_types.h:32: +typedef long __kernel_time_t;
WARNING: do not add new typedefs #535: FILE: arch/c6x/include/asm/posix_types.h:33: +typedef long __kernel_suseconds_t;
WARNING: do not add new typedefs #536: FILE: arch/c6x/include/asm/posix_types.h:34: +typedef long __kernel_clock_t;
WARNING: do not add new typedefs #537: FILE: arch/c6x/include/asm/posix_types.h:35: +typedef int __kernel_daddr_t;
WARNING: do not add new typedefs #538: FILE: arch/c6x/include/asm/posix_types.h:36: +typedef char *__kernel_caddr_t;
WARNING: do not add new typedefs #539: FILE: arch/c6x/include/asm/posix_types.h:37: +typedef unsigned short __kernel_uid16_t;
WARNING: do not add new typedefs #540: FILE: arch/c6x/include/asm/posix_types.h:38: +typedef unsigned short __kernel_gid16_t;
WARNING: do not add new typedefs #541: FILE: arch/c6x/include/asm/posix_types.h:39: +typedef unsigned int __kernel_uid32_t;
WARNING: do not add new typedefs #542: FILE: arch/c6x/include/asm/posix_types.h:40: +typedef unsigned int __kernel_gid32_t;
WARNING: do not add new typedefs #544: FILE: arch/c6x/include/asm/posix_types.h:42: +typedef unsigned short __kernel_old_uid_t;
WARNING: do not add new typedefs #545: FILE: arch/c6x/include/asm/posix_types.h:43: +typedef unsigned short __kernel_old_gid_t;
WARNING: do not add new typedefs #548: FILE: arch/c6x/include/asm/posix_types.h:46: +typedef struct {
WARNING: line over 80 characters #608: FILE: arch/c6x/include/asm/ptrace.h:18: +#if defined(__TMS320C6XPLUS__) || defined(_TMS320C6400_PLUS) || defined(__TMS320C66X__)
ERROR: trailing whitespace #615: FILE: arch/c6x/include/asm/ptrace.h:25: +#define PT_LO(odd,even) odd $
ERROR: space required after that ',' (ctx:VxV) #615: FILE: arch/c6x/include/asm/ptrace.h:25: +#define PT_LO(odd,even) odd ^
ERROR: space required after that ',' (ctx:VxV) #616: FILE: arch/c6x/include/asm/ptrace.h:26: +#define PT_HI(odd,even) even ^
ERROR: space required after that ',' (ctx:VxV) #618: FILE: arch/c6x/include/asm/ptrace.h:28: +#define PT_LO(odd,even) even ^
ERROR: space required after that ',' (ctx:VxV) #619: FILE: arch/c6x/include/asm/ptrace.h:29: +#define PT_HI(odd,even) odd ^
WARNING: line over 80 characters #622: FILE: arch/c6x/include/asm/ptrace.h:32: +#if defined(__TMS320C6XPLUS__) || defined(_TMS320C6400_PLUS) || defined(__TMS320C66X__)
ERROR: space required after that ',' (ctx:VxV) #624: FILE: arch/c6x/include/asm/ptrace.h:34: +#define PT_A4_ORG PT_LO(1,0) ^
ERROR: space required after that ',' (ctx:VxV) #625: FILE: arch/c6x/include/asm/ptrace.h:35: +#define PT_TSR PT_HI(1,0) ^
ERROR: space required after that ',' (ctx:VxV) #626: FILE: arch/c6x/include/asm/ptrace.h:36: +#define PT_ILC PT_LO(3,2) ^
ERROR: space required after that ',' (ctx:VxV) #627: FILE: arch/c6x/include/asm/ptrace.h:37: +#define PT_RILC PT_HI(3,2) ^
ERROR: space required after that ',' (ctx:VxV) #628: FILE: arch/c6x/include/asm/ptrace.h:38: +#define PT_CSR PT_LO(5,4) ^
ERROR: space required after that ',' (ctx:VxV) #629: FILE: arch/c6x/include/asm/ptrace.h:39: +#define PT_PC PT_HI(5,4) ^
ERROR: space required after that ',' (ctx:VxV) #630: FILE: arch/c6x/include/asm/ptrace.h:40: +#define PT_B16 PT_LO(7,6) ^
ERROR: space required after that ',' (ctx:VxV) #631: FILE: arch/c6x/include/asm/ptrace.h:41: +#define PT_B17 PT_HI(7,6) ^
ERROR: space required after that ',' (ctx:VxV) #632: FILE: arch/c6x/include/asm/ptrace.h:42: +#define PT_B18 PT_LO(9,8) ^
ERROR: space required after that ',' (ctx:VxV) #633: FILE: arch/c6x/include/asm/ptrace.h:43: +#define PT_B19 PT_HI(9,8) ^
ERROR: space required after that ',' (ctx:VxV) #634: FILE: arch/c6x/include/asm/ptrace.h:44: +#define PT_B20 PT_LO(11,10) ^
ERROR: space required after that ',' (ctx:VxV) #635: FILE: arch/c6x/include/asm/ptrace.h:45: +#define PT_B21 PT_HI(11,10) ^
ERROR: space required after that ',' (ctx:VxV) #636: FILE: arch/c6x/include/asm/ptrace.h:46: +#define PT_B22 PT_LO(13,12) ^
ERROR: space required after that ',' (ctx:VxV) #637: FILE: arch/c6x/include/asm/ptrace.h:47: +#define PT_B23 PT_HI(13,12) ^
ERROR: space required after that ',' (ctx:VxV) #638: FILE: arch/c6x/include/asm/ptrace.h:48: +#define PT_B24 PT_LO(15,14) ^
ERROR: space required after that ',' (ctx:VxV) #639: FILE: arch/c6x/include/asm/ptrace.h:49: +#define PT_B25 PT_HI(15,14) ^
ERROR: space required after that ',' (ctx:VxV) #640: FILE: arch/c6x/include/asm/ptrace.h:50: +#define PT_B26 PT_LO(17,16) ^
ERROR: space required after that ',' (ctx:VxV) #641: FILE: arch/c6x/include/asm/ptrace.h:51: +#define PT_B27 PT_HI(17,16) ^
ERROR: space required after that ',' (ctx:VxV) #642: FILE: arch/c6x/include/asm/ptrace.h:52: +#define PT_B28 PT_LO(19,18) ^
ERROR: space required after that ',' (ctx:VxV) #643: FILE: arch/c6x/include/asm/ptrace.h:53: +#define PT_B29 PT_HI(19,18) ^
ERROR: space required after that ',' (ctx:VxV) #644: FILE: arch/c6x/include/asm/ptrace.h:54: +#define PT_B30 PT_LO(21,20) ^
ERROR: space required after that ',' (ctx:VxV) #645: FILE: arch/c6x/include/asm/ptrace.h:55: +#define PT_B31 PT_HI(21,20) ^
ERROR: space required after that ',' (ctx:VxV) #646: FILE: arch/c6x/include/asm/ptrace.h:56: +#define PT_B0 PT_LO(23,22) ^
ERROR: space required after that ',' (ctx:VxV) #647: FILE: arch/c6x/include/asm/ptrace.h:57: +#define PT_B1 PT_HI(23,22) ^
ERROR: space required after that ',' (ctx:VxV) #648: FILE: arch/c6x/include/asm/ptrace.h:58: +#define PT_B2 PT_LO(25,24) ^
ERROR: space required after that ',' (ctx:VxV) #649: FILE: arch/c6x/include/asm/ptrace.h:59: +#define PT_B3 PT_HI(25,24) ^
ERROR: space required after that ',' (ctx:VxV) #650: FILE: arch/c6x/include/asm/ptrace.h:60: +#define PT_B4 PT_LO(27,26) ^
ERROR: space required after that ',' (ctx:VxV) #651: FILE: arch/c6x/include/asm/ptrace.h:61: +#define PT_B5 PT_HI(27,26) ^
ERROR: space required after that ',' (ctx:VxV) #652: FILE: arch/c6x/include/asm/ptrace.h:62: +#define PT_B6 PT_LO(29,28) ^
ERROR: space required after that ',' (ctx:VxV) #653: FILE: arch/c6x/include/asm/ptrace.h:63: +#define PT_B7 PT_HI(29,28) ^
ERROR: space required after that ',' (ctx:VxV) #654: FILE: arch/c6x/include/asm/ptrace.h:64: +#define PT_B8 PT_LO(31,30) ^
ERROR: space required after that ',' (ctx:VxV) #655: FILE: arch/c6x/include/asm/ptrace.h:65: +#define PT_B9 PT_HI(31,30) ^
ERROR: space required after that ',' (ctx:VxV) #656: FILE: arch/c6x/include/asm/ptrace.h:66: +#define PT_B10 PT_LO(33,32) ^
ERROR: space required after that ',' (ctx:VxV) #657: FILE: arch/c6x/include/asm/ptrace.h:67: +#define PT_B11 PT_HI(33,32) ^
ERROR: space required after that ',' (ctx:VxV) #658: FILE: arch/c6x/include/asm/ptrace.h:68: +#define PT_B12 PT_LO(35,34) ^
ERROR: space required after that ',' (ctx:VxV) #659: FILE: arch/c6x/include/asm/ptrace.h:69: +#define PT_B13 PT_HI(35,34) ^
ERROR: space required after that ',' (ctx:VxV) #660: FILE: arch/c6x/include/asm/ptrace.h:70: +#define PT_A16 PT_LO(37,36) ^
ERROR: space required after that ',' (ctx:VxV) #661: FILE: arch/c6x/include/asm/ptrace.h:71: +#define PT_A17 PT_HI(37,36) ^
ERROR: space required after that ',' (ctx:VxV) #662: FILE: arch/c6x/include/asm/ptrace.h:72: +#define PT_A18 PT_LO(39,38) ^
ERROR: space required after that ',' (ctx:VxV) #663: FILE: arch/c6x/include/asm/ptrace.h:73: +#define PT_A19 PT_HI(39,38) ^
ERROR: space required after that ',' (ctx:VxV) #664: FILE: arch/c6x/include/asm/ptrace.h:74: +#define PT_A20 PT_LO(41,40) ^
ERROR: space required after that ',' (ctx:VxV) #665: FILE: arch/c6x/include/asm/ptrace.h:75: +#define PT_A21 PT_HI(41,40) ^
ERROR: space required after that ',' (ctx:VxV) #666: FILE: arch/c6x/include/asm/ptrace.h:76: +#define PT_A22 PT_LO(43,42) ^
ERROR: space required after that ',' (ctx:VxV) #667: FILE: arch/c6x/include/asm/ptrace.h:77: +#define PT_A23 PT_HI(43,42) ^
ERROR: space required after that ',' (ctx:VxV) #668: FILE: arch/c6x/include/asm/ptrace.h:78: +#define PT_A24 PT_LO(45,44) ^
ERROR: space required after that ',' (ctx:VxV) #669: FILE: arch/c6x/include/asm/ptrace.h:79: +#define PT_A25 PT_HI(45,44) ^
ERROR: space required after that ',' (ctx:VxV) #670: FILE: arch/c6x/include/asm/ptrace.h:80: +#define PT_A26 PT_LO(47,46) ^
ERROR: space required after that ',' (ctx:VxV) #671: FILE: arch/c6x/include/asm/ptrace.h:81: +#define PT_A27 PT_HI(47,46) ^
ERROR: space required after that ',' (ctx:VxV) #672: FILE: arch/c6x/include/asm/ptrace.h:82: +#define PT_A28 PT_LO(49,48) ^
ERROR: space required after that ',' (ctx:VxV) #673: FILE: arch/c6x/include/asm/ptrace.h:83: +#define PT_A29 PT_HI(49,48) ^
ERROR: space required after that ',' (ctx:VxV) #674: FILE: arch/c6x/include/asm/ptrace.h:84: +#define PT_A30 PT_LO(51,50) ^
ERROR: space required after that ',' (ctx:VxV) #675: FILE: arch/c6x/include/asm/ptrace.h:85: +#define PT_A31 PT_HI(51,50) ^
ERROR: space required after that ',' (ctx:VxV) #676: FILE: arch/c6x/include/asm/ptrace.h:86: +#define PT_A0 PT_LO(53,52) ^
ERROR: space required after that ',' (ctx:VxV) #677: FILE: arch/c6x/include/asm/ptrace.h:87: +#define PT_A1 PT_HI(53,52) ^
ERROR: space required after that ',' (ctx:VxV) #678: FILE: arch/c6x/include/asm/ptrace.h:88: +#define PT_A2 PT_LO(55,54) ^
ERROR: space required after that ',' (ctx:VxV) #679: FILE: arch/c6x/include/asm/ptrace.h:89: +#define PT_A3 PT_HI(55,54) ^
ERROR: space required after that ',' (ctx:VxV) #680: FILE: arch/c6x/include/asm/ptrace.h:90: +#define PT_A4 PT_LO(57,56) ^
ERROR: space required after that ',' (ctx:VxV) #681: FILE: arch/c6x/include/asm/ptrace.h:91: +#define PT_A5 PT_HI(57,56) ^
ERROR: space required after that ',' (ctx:VxV) #682: FILE: arch/c6x/include/asm/ptrace.h:92: +#define PT_A6 PT_LO(59,58) ^
ERROR: space required after that ',' (ctx:VxV) #683: FILE: arch/c6x/include/asm/ptrace.h:93: +#define PT_A7 PT_HI(59,58) ^
ERROR: space required after that ',' (ctx:VxV) #684: FILE: arch/c6x/include/asm/ptrace.h:94: +#define PT_A8 PT_LO(61,60) ^
ERROR: space required after that ',' (ctx:VxV) #685: FILE: arch/c6x/include/asm/ptrace.h:95: +#define PT_A9 PT_HI(61,60) ^
ERROR: space required after that ',' (ctx:VxV) #686: FILE: arch/c6x/include/asm/ptrace.h:96: +#define PT_A10 PT_LO(63,62) ^
ERROR: space required after that ',' (ctx:VxV) #687: FILE: arch/c6x/include/asm/ptrace.h:97: +#define PT_A11 PT_HI(63,62) ^
ERROR: space required after that ',' (ctx:VxV) #688: FILE: arch/c6x/include/asm/ptrace.h:98: +#define PT_A12 PT_LO(65,64) ^
ERROR: space required after that ',' (ctx:VxV) #689: FILE: arch/c6x/include/asm/ptrace.h:99: +#define PT_A13 PT_HI(65,64) ^
ERROR: space required after that ',' (ctx:VxV) #690: FILE: arch/c6x/include/asm/ptrace.h:100: +#define PT_A14 PT_LO(67,66) ^
ERROR: space required after that ',' (ctx:VxV) #691: FILE: arch/c6x/include/asm/ptrace.h:101: +#define PT_A15 PT_HI(67,66) ^
ERROR: space required after that ',' (ctx:VxV) #692: FILE: arch/c6x/include/asm/ptrace.h:102: +#define PT_B14 PT_LO(69,68) ^
ERROR: space required after that ',' (ctx:VxV) #693: FILE: arch/c6x/include/asm/ptrace.h:103: +#define PT_B15 PT_HI(69,68) ^
ERROR: space required after that ',' (ctx:VxV) #697: FILE: arch/c6x/include/asm/ptrace.h:107: +#define PT_A4_ORG PT_LO(1,0) ^
ERROR: space required after that ',' (ctx:VxV) #698: FILE: arch/c6x/include/asm/ptrace.h:108: +#define PT_STKADJ PT_HI(1,0) ^
ERROR: space required after that ',' (ctx:VxV) #699: FILE: arch/c6x/include/asm/ptrace.h:109: +#define PT_CSR PT_LO(3,2) ^
ERROR: space required after that ',' (ctx:VxV) #700: FILE: arch/c6x/include/asm/ptrace.h:110: +#define PT_PC PT_HI(3,2) ^
ERROR: space required after that ',' (ctx:VxV) #702: FILE: arch/c6x/include/asm/ptrace.h:112: +#define PT_B16 PT_LO(5,4) ^
ERROR: space required after that ',' (ctx:VxV) #703: FILE: arch/c6x/include/asm/ptrace.h:113: +#define PT_B17 PT_HI(5,4) ^
ERROR: space required after that ',' (ctx:VxV) #704: FILE: arch/c6x/include/asm/ptrace.h:114: +#define PT_B18 PT_LO(7,6) ^
ERROR: space required after that ',' (ctx:VxV) #705: FILE: arch/c6x/include/asm/ptrace.h:115: +#define PT_B19 PT_HI(7,6) ^
ERROR: space required after that ',' (ctx:VxV) #706: FILE: arch/c6x/include/asm/ptrace.h:116: +#define PT_B20 PT_LO(9,8) ^
ERROR: space required after that ',' (ctx:VxV) #707: FILE: arch/c6x/include/asm/ptrace.h:117: +#define PT_B21 PT_HI(9,8) ^
ERROR: space required after that ',' (ctx:VxV) #708: FILE: arch/c6x/include/asm/ptrace.h:118: +#define PT_B22 PT_LO(11,10) ^
ERROR: space required after that ',' (ctx:VxV) #709: FILE: arch/c6x/include/asm/ptrace.h:119: +#define PT_B23 PT_HI(11,10) ^
ERROR: space required after that ',' (ctx:VxV) #710: FILE: arch/c6x/include/asm/ptrace.h:120: +#define PT_B24 PT_LO(13,12) ^
ERROR: space required after that ',' (ctx:VxV) #711: FILE: arch/c6x/include/asm/ptrace.h:121: +#define PT_B25 PT_HI(13,12) ^
ERROR: space required after that ',' (ctx:VxV) #712: FILE: arch/c6x/include/asm/ptrace.h:122: +#define PT_B26 PT_LO(15,14) ^
ERROR: space required after that ',' (ctx:VxV) #713: FILE: arch/c6x/include/asm/ptrace.h:123: +#define PT_B27 PT_HI(15,14) ^
ERROR: space required after that ',' (ctx:VxV) #714: FILE: arch/c6x/include/asm/ptrace.h:124: +#define PT_B28 PT_LO(17,16) ^
ERROR: space required after that ',' (ctx:VxV) #715: FILE: arch/c6x/include/asm/ptrace.h:125: +#define PT_B29 PT_HI(17,16) ^
ERROR: space required after that ',' (ctx:VxV) #716: FILE: arch/c6x/include/asm/ptrace.h:126: +#define PT_B30 PT_LO(19,18) ^
ERROR: space required after that ',' (ctx:VxV) #717: FILE: arch/c6x/include/asm/ptrace.h:127: +#define PT_B31 PT_HI(19,18) ^
ERROR: space required after that ',' (ctx:VxV) #719: FILE: arch/c6x/include/asm/ptrace.h:129: +#define PT_B0 PT_LO(21,20) ^
ERROR: space required after that ',' (ctx:VxV) #720: FILE: arch/c6x/include/asm/ptrace.h:130: +#define PT_B1 PT_HI(21,20) ^
ERROR: space required after that ',' (ctx:VxV) #721: FILE: arch/c6x/include/asm/ptrace.h:131: +#define PT_B2 PT_LO(23,22) ^
ERROR: space required after that ',' (ctx:VxV) #722: FILE: arch/c6x/include/asm/ptrace.h:132: +#define PT_B3 PT_HI(23,22) ^
ERROR: space required after that ',' (ctx:VxV) #723: FILE: arch/c6x/include/asm/ptrace.h:133: +#define PT_B4 PT_LO(25,24) ^
ERROR: space required after that ',' (ctx:VxV) #724: FILE: arch/c6x/include/asm/ptrace.h:134: +#define PT_B5 PT_HI(25,24) ^
ERROR: space required after that ',' (ctx:VxV) #725: FILE: arch/c6x/include/asm/ptrace.h:135: +#define PT_B6 PT_LO(27,26) ^
ERROR: space required after that ',' (ctx:VxV) #726: FILE: arch/c6x/include/asm/ptrace.h:136: +#define PT_B7 PT_HI(27,26) ^
ERROR: space required after that ',' (ctx:VxV) #727: FILE: arch/c6x/include/asm/ptrace.h:137: +#define PT_B8 PT_LO(29,28) ^
ERROR: space required after that ',' (ctx:VxV) #728: FILE: arch/c6x/include/asm/ptrace.h:138: +#define PT_B9 PT_HI(29,28) ^
ERROR: space required after that ',' (ctx:VxV) #729: FILE: arch/c6x/include/asm/ptrace.h:139: +#define PT_B10 PT_LO(31,30) ^
ERROR: space required after that ',' (ctx:VxV) #730: FILE: arch/c6x/include/asm/ptrace.h:140: +#define PT_B11 PT_HI(31,30) ^
ERROR: space required after that ',' (ctx:VxV) #731: FILE: arch/c6x/include/asm/ptrace.h:141: +#define PT_B12 PT_LO(33,32) ^
ERROR: space required after that ',' (ctx:VxV) #732: FILE: arch/c6x/include/asm/ptrace.h:142: +#define PT_B13 PT_HI(33,32) ^
ERROR: space required after that ',' (ctx:VxV) #734: FILE: arch/c6x/include/asm/ptrace.h:144: +#define PT_A16 PT_LO(35,34) ^
ERROR: space required after that ',' (ctx:VxV) #735: FILE: arch/c6x/include/asm/ptrace.h:145: +#define PT_A17 PT_HI(35,34) ^
ERROR: space required after that ',' (ctx:VxV) #736: FILE: arch/c6x/include/asm/ptrace.h:146: +#define PT_A18 PT_LO(37,36) ^
ERROR: space required after that ',' (ctx:VxV) #737: FILE: arch/c6x/include/asm/ptrace.h:147: +#define PT_A19 PT_HI(37,36) ^
ERROR: space required after that ',' (ctx:VxV) #738: FILE: arch/c6x/include/asm/ptrace.h:148: +#define PT_A20 PT_LO(39,38) ^
ERROR: space required after that ',' (ctx:VxV) #739: FILE: arch/c6x/include/asm/ptrace.h:149: +#define PT_A21 PT_HI(39,38) ^
ERROR: space required after that ',' (ctx:VxV) #740: FILE: arch/c6x/include/asm/ptrace.h:150: +#define PT_A22 PT_LO(41,40) ^
ERROR: space required after that ',' (ctx:VxV) #741: FILE: arch/c6x/include/asm/ptrace.h:151: +#define PT_A23 PT_HI(41,40) ^
ERROR: space required after that ',' (ctx:VxV) #742: FILE: arch/c6x/include/asm/ptrace.h:152: +#define PT_A24 PT_LO(43,42) ^
ERROR: space required after that ',' (ctx:VxV) #743: FILE: arch/c6x/include/asm/ptrace.h:153: +#define PT_A25 PT_HI(43,42) ^
ERROR: space required after that ',' (ctx:VxV) #744: FILE: arch/c6x/include/asm/ptrace.h:154: +#define PT_A26 PT_LO(45,44) ^
ERROR: space required after that ',' (ctx:VxV) #745: FILE: arch/c6x/include/asm/ptrace.h:155: +#define PT_A27 PT_HI(45,44) ^
ERROR: space required after that ',' (ctx:VxV) #746: FILE: arch/c6x/include/asm/ptrace.h:156: +#define PT_A28 PT_LO(47,46) ^
ERROR: space required after that ',' (ctx:VxV) #747: FILE: arch/c6x/include/asm/ptrace.h:157: +#define PT_A29 PT_HI(47,46) ^
ERROR: space required after that ',' (ctx:VxV) #748: FILE: arch/c6x/include/asm/ptrace.h:158: +#define PT_A30 PT_LO(49,48) ^
ERROR: space required after that ',' (ctx:VxV) #749: FILE: arch/c6x/include/asm/ptrace.h:159: +#define PT_A31 PT_HI(49,48) ^
ERROR: space required after that ',' (ctx:VxV) #751: FILE: arch/c6x/include/asm/ptrace.h:161: +#define PT_A0 PT_LO(51,50) ^
ERROR: space required after that ',' (ctx:VxV) #752: FILE: arch/c6x/include/asm/ptrace.h:162: +#define PT_A1 PT_HI(51,50) ^
ERROR: space required after that ',' (ctx:VxV) #753: FILE: arch/c6x/include/asm/ptrace.h:163: +#define PT_A2 PT_LO(53,52) ^
ERROR: space required after that ',' (ctx:VxV) #754: FILE: arch/c6x/include/asm/ptrace.h:164: +#define PT_A3 PT_HI(53,52) ^
ERROR: space required after that ',' (ctx:VxV) #755: FILE: arch/c6x/include/asm/ptrace.h:165: +#define PT_A4 PT_LO(55,54) ^
ERROR: space required after that ',' (ctx:VxV) #756: FILE: arch/c6x/include/asm/ptrace.h:166: +#define PT_A5 PT_HI(55,54) ^
ERROR: space required after that ',' (ctx:VxV) #757: FILE: arch/c6x/include/asm/ptrace.h:167: +#define PT_A6 PT_LO(57,56) ^
ERROR: space required after that ',' (ctx:VxV) #758: FILE: arch/c6x/include/asm/ptrace.h:168: +#define PT_A7 PT_HI(57,56) ^
ERROR: space required after that ',' (ctx:VxV) #759: FILE: arch/c6x/include/asm/ptrace.h:169: +#define PT_A8 PT_LO(59,58) ^
ERROR: space required after that ',' (ctx:VxV) #760: FILE: arch/c6x/include/asm/ptrace.h:170: +#define PT_A9 PT_HI(59,58) ^
ERROR: space required after that ',' (ctx:VxV) #761: FILE: arch/c6x/include/asm/ptrace.h:171: +#define PT_A10 PT_LO(61,60) ^
ERROR: space required after that ',' (ctx:VxV) #762: FILE: arch/c6x/include/asm/ptrace.h:172: +#define PT_A11 PT_HI(61,60) ^
ERROR: space required after that ',' (ctx:VxV) #763: FILE: arch/c6x/include/asm/ptrace.h:173: +#define PT_A12 PT_LO(63,62) ^
ERROR: space required after that ',' (ctx:VxV) #764: FILE: arch/c6x/include/asm/ptrace.h:174: +#define PT_A13 PT_HI(63,62) ^
ERROR: space required after that ',' (ctx:VxV) #765: FILE: arch/c6x/include/asm/ptrace.h:175: +#define PT_A14 PT_LO(65,64) ^
ERROR: space required after that ',' (ctx:VxV) #766: FILE: arch/c6x/include/asm/ptrace.h:176: +#define PT_A15 PT_HI(65,64) ^
ERROR: space required after that ',' (ctx:VxV) #767: FILE: arch/c6x/include/asm/ptrace.h:177: +#define PT_B14 PT_LO(67,66) ^
ERROR: space required after that ',' (ctx:VxV) #768: FILE: arch/c6x/include/asm/ptrace.h:178: +#define PT_B15 PT_HI(67,66) ^
ERROR: space required after that ',' (ctx:VxV) #778: FILE: arch/c6x/include/asm/ptrace.h:188: +#define REG_PAIR(odd,even) unsigned long odd; unsigned long even ^
ERROR: space required after that ',' (ctx:VxV) #780: FILE: arch/c6x/include/asm/ptrace.h:190: +#define REG_PAIR(odd,even) unsigned long even; unsigned long odd ^
WARNING: line over 80 characters #790: FILE: arch/c6x/include/asm/ptrace.h:200: +#if defined(__TMS320C6XPLUS__) || defined(_TMS320C6400_PLUS) || defined(__TMS320C66X__)
ERROR: space required after that ',' (ctx:VxV) #791: FILE: arch/c6x/include/asm/ptrace.h:201: + REG_PAIR(tsr,orig_a4); ^
ERROR: space required after that ',' (ctx:VxV) #792: FILE: arch/c6x/include/asm/ptrace.h:202: + REG_PAIR(rilc,ilc); ^
ERROR: space required after that ',' (ctx:VxV) #794: FILE: arch/c6x/include/asm/ptrace.h:204: + REG_PAIR(stkadj,orig_a4); ^
ERROR: space required after that ',' (ctx:VxV) #796: FILE: arch/c6x/include/asm/ptrace.h:206: + REG_PAIR(pc,csr); ^
ERROR: space required after that ',' (ctx:VxV) #799: FILE: arch/c6x/include/asm/ptrace.h:209: + REG_PAIR(b17,b16); ^
ERROR: space required after that ',' (ctx:VxV) #800: FILE: arch/c6x/include/asm/ptrace.h:210: + REG_PAIR(b19,b18); ^
ERROR: space required after that ',' (ctx:VxV) #801: FILE: arch/c6x/include/asm/ptrace.h:211: + REG_PAIR(b21,b20); ^
ERROR: space required after that ',' (ctx:VxV) #802: FILE: arch/c6x/include/asm/ptrace.h:212: + REG_PAIR(b23,b22); ^
ERROR: space required after that ',' (ctx:VxV) #803: FILE: arch/c6x/include/asm/ptrace.h:213: + REG_PAIR(b25,b24); ^
ERROR: space required after that ',' (ctx:VxV) #804: FILE: arch/c6x/include/asm/ptrace.h:214: + REG_PAIR(b27,b26); ^
ERROR: space required after that ',' (ctx:VxV) #805: FILE: arch/c6x/include/asm/ptrace.h:215: + REG_PAIR(b29,b28); ^
ERROR: space required after that ',' (ctx:VxV) #806: FILE: arch/c6x/include/asm/ptrace.h:216: + REG_PAIR(b31,b30); ^
ERROR: space required after that ',' (ctx:VxV) #809: FILE: arch/c6x/include/asm/ptrace.h:219: + REG_PAIR(b1,b0); ^
ERROR: space required after that ',' (ctx:VxV) #810: FILE: arch/c6x/include/asm/ptrace.h:220: + REG_PAIR(b3,b2); ^
ERROR: space required after that ',' (ctx:VxV) #811: FILE: arch/c6x/include/asm/ptrace.h:221: + REG_PAIR(b5,b4); ^
ERROR: space required after that ',' (ctx:VxV) #812: FILE: arch/c6x/include/asm/ptrace.h:222: + REG_PAIR(b7,b6); ^
ERROR: space required after that ',' (ctx:VxV) #813: FILE: arch/c6x/include/asm/ptrace.h:223: + REG_PAIR(b9,b8); ^
ERROR: space required after that ',' (ctx:VxV) #814: FILE: arch/c6x/include/asm/ptrace.h:224: + REG_PAIR(b11,b10); ^
ERROR: space required after that ',' (ctx:VxV) #815: FILE: arch/c6x/include/asm/ptrace.h:225: + REG_PAIR(b13,b12); ^
ERROR: space required after that ',' (ctx:VxV) #818: FILE: arch/c6x/include/asm/ptrace.h:228: + REG_PAIR(a17,a16); ^
ERROR: space required after that ',' (ctx:VxV) #819: FILE: arch/c6x/include/asm/ptrace.h:229: + REG_PAIR(a19,a18); ^
ERROR: space required after that ',' (ctx:VxV) #820: FILE: arch/c6x/include/asm/ptrace.h:230: + REG_PAIR(a21,a20); ^
ERROR: space required after that ',' (ctx:VxV) #821: FILE: arch/c6x/include/asm/ptrace.h:231: + REG_PAIR(a23,a22); ^
ERROR: space required after that ',' (ctx:VxV) #822: FILE: arch/c6x/include/asm/ptrace.h:232: + REG_PAIR(a25,a24); ^
ERROR: space required after that ',' (ctx:VxV) #823: FILE: arch/c6x/include/asm/ptrace.h:233: + REG_PAIR(a27,a26); ^
ERROR: space required after that ',' (ctx:VxV) #824: FILE: arch/c6x/include/asm/ptrace.h:234: + REG_PAIR(a29,a28); ^
ERROR: space required after that ',' (ctx:VxV) #825: FILE: arch/c6x/include/asm/ptrace.h:235: + REG_PAIR(a31,a30); ^
ERROR: space required after that ',' (ctx:VxV) #828: FILE: arch/c6x/include/asm/ptrace.h:238: + REG_PAIR(a1,a0); ^
ERROR: space required after that ',' (ctx:VxV) #829: FILE: arch/c6x/include/asm/ptrace.h:239: + REG_PAIR(a3,a2); ^
ERROR: space required after that ',' (ctx:VxV) #830: FILE: arch/c6x/include/asm/ptrace.h:240: + REG_PAIR(a5,a4); ^
ERROR: space required after that ',' (ctx:VxV) #831: FILE: arch/c6x/include/asm/ptrace.h:241: + REG_PAIR(a7,a6); ^
ERROR: space required after that ',' (ctx:VxV) #832: FILE: arch/c6x/include/asm/ptrace.h:242: + REG_PAIR(a9,a8); ^
ERROR: space required after that ',' (ctx:VxV) #833: FILE: arch/c6x/include/asm/ptrace.h:243: + REG_PAIR(a11,a10); ^
ERROR: space required after that ',' (ctx:VxV) #834: FILE: arch/c6x/include/asm/ptrace.h:244: + REG_PAIR(a13,a12); ^
ERROR: space required after that ',' (ctx:VxV) #836: FILE: arch/c6x/include/asm/ptrace.h:246: + REG_PAIR(a15,a14); ^
ERROR: space required after that ',' (ctx:VxV) #837: FILE: arch/c6x/include/asm/ptrace.h:247: + REG_PAIR(sp,dp); ^
WARNING: line over 80 characters #844: FILE: arch/c6x/include/asm/ptrace.h:254: +#if defined(__TMS320C6XPLUS__) || defined(_TMS320C6400_PLUS) || defined(__TMS320C66X__)
ERROR: space required after that ',' (ctx:VxV) #845: FILE: arch/c6x/include/asm/ptrace.h:255: + REG_PAIR(rilc,ilc); ^
ERROR: space required after that ',' (ctx:VxV) #847: FILE: arch/c6x/include/asm/ptrace.h:257: + REG_PAIR(a11,a10); ^
ERROR: space required after that ',' (ctx:VxV) #848: FILE: arch/c6x/include/asm/ptrace.h:258: + REG_PAIR(a13,a12); ^
ERROR: space required after that ',' (ctx:VxV) #849: FILE: arch/c6x/include/asm/ptrace.h:259: + REG_PAIR(a15,a14); ^
ERROR: space required after that ',' (ctx:VxV) #850: FILE: arch/c6x/include/asm/ptrace.h:260: + REG_PAIR(b11,b10); ^
ERROR: space required after that ',' (ctx:VxV) #851: FILE: arch/c6x/include/asm/ptrace.h:261: + REG_PAIR(b13,b12); ^
WARNING: line over 80 characters #872: FILE: arch/c6x/include/asm/ptrace.h:282: +#define PTRACE_GETDSBT_EXEC 0 /* [addr] request the executable loadmap */
WARNING: line over 80 characters #873: FILE: arch/c6x/include/asm/ptrace.h:283: +#define PTRACE_GETDSBT_INTERP 1 /* [addr] request the interpreter loadmap */
WARNING: line over 80 characters #877: FILE: arch/c6x/include/asm/ptrace.h:287: +#define DEFAULT_CSR 0x0001 /* interrupt enable by default */
WARNING: line over 80 characters #878: FILE: arch/c6x/include/asm/ptrace.h:288: + /* used in /include/asm/processor.h*/
ERROR: code indent should use tabs where possible #878: FILE: arch/c6x/include/asm/ptrace.h:288: + /* used in /include/asm/processor.h*/$
WARNING: line over 80 characters #882: FILE: arch/c6x/include/asm/ptrace.h:292: +#define user_mode(regs) (((((regs)->sp) ^ current_ksp) >> PAGE_SHIFT) != 0)
ERROR: "foo * bar" should be "foo *bar" #971: FILE: arch/c6x/include/asm/string.h:16: +extern void * memcpy(void *to, const void *from, size_t n);
ERROR: "foo * bar" should be "foo *bar" #972: FILE: arch/c6x/include/asm/string.h:17: +extern void * memset(void *s, int c, size_t count);
WARNING: do not add new typedefs #991: FILE: arch/c6x/include/asm/types.h:4: +typedef unsigned short umode_t;
WARNING: do not add new typedefs #1035: FILE: arch/c6x/include/asm/types.h:48: +typedef unsigned long phys_addr_t;
WARNING: do not add new typedefs #1036: FILE: arch/c6x/include/asm/types.h:49: +typedef unsigned long phys_size_t;
WARNING: do not add new typedefs #1085: FILE: arch/c6x/include/asm/u-boot.h:39: +typedef struct bd_info {
WARNING: externs should be avoided in .c files #1244: FILE: arch/c6x/lib/board.c:71: +extern int print_cpuinfo(void);
WARNING: externs should be avoided in .c files #1271: FILE: arch/c6x/lib/board.c:98: +extern ulong __bss_start;
WARNING: externs should be avoided in .c files #1272: FILE: arch/c6x/lib/board.c:99: +extern ulong __bss_end__;
ERROR: spaces required around that ':' (ctx:VxW) #1290: FILE: arch/c6x/lib/board.c:117: + __asm__ __volatile__("": : :"memory"); ^
ERROR: spaces required around that ':' (ctx:WxV) #1290: FILE: arch/c6x/lib/board.c:117: + __asm__ __volatile__("": : :"memory"); ^
WARNING: Whitespace before semicolon #1366: FILE: arch/c6x/lib/board.c:193: + ;
WARNING: line over 80 characters #1416: FILE: arch/c6x/lib/bootm.c:36: +int do_bootm_linux(int flag, int argc, char * const argv[], bootm_headers_t *images)
WARNING: space prohibited between function name and open parenthesis '(' #1419: FILE: arch/c6x/lib/bootm.c:39: + char *commandline = getenv ("bootargs");
WARNING: do not add new typedefs #2361: FILE: arch/c6x/lib/divull.c:132: +typedef union {
total: 197 errors, 76 warnings, 3033 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or scripts/cleanfile
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE
/home/wd/Mail/U-Boot/19345 has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 0 warnings, 159 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE
ERROR: trailing whitespace #153: FILE: arch/arm/cpu/arm926ejs/davinci/reset_c.c:17: +^Istruct davinci_timer * const wdttimer = $
ERROR: space required before the open parenthesis '(' #166: FILE: arch/arm/cpu/arm926ejs/davinci/reset_c.c:30: + while(1);
ERROR: trailing statements should be on next line #166: FILE: arch/arm/cpu/arm926ejs/davinci/reset_c.c:30: + while(1);
total: 3 errors, 0 warnings, 63 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or scripts/cleanfile
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE
/home/wd/Mail/U-Boot/19347 has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ERROR: space required before the open brace '{' #336: FILE: board/inmys/c6745-som/c6745-som.c:191: + for (j = 0; j < 15; j++){
WARNING: braces {} are not necessary for single statement blocks #336: FILE: board/inmys/c6745-som/c6745-som.c:191: + for (j = 0; j < 15; j++){ + REG(DAVINCI_UART2_BASE + (j*4)) = 0; + }
WARNING: line over 80 characters #596: FILE: include/configs/c6745-som-inmys.h:186: +#define CONFIG_BOOTARGS "mem=32M console=ttyS2,115200n8 root=/dev/mtdblock/2 rw noinitrd ip=dhcp"
total: 1 errors, 2 warnings, 584 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE
/home/wd/Mail/U-Boot/19348 has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 0 warnings, 18 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE
Best regards,
Wolfgang Denk
Dear Wolfgang Denk, In message 20120623123302.5ABCA2000F1@gemini.denx.de you wrote:
Dear Dmitry Bondar,
In message 1340449870-26456-1-git-send-email-bond@inmys.ru you wrote:
C6X (C6000) is family of fixed and floating-point DSPs manufactured by Texas Instruments.
Signed-off-by: Dmitry Bondar bond@inmys.ru Cc: Tom Rini trini@ti.com
Changes for v2:
- davinci SOC reset_c.c rewritten with readl/writel.
- Tom Rini trini@ti.com added to cc
Please run your patches through checkpatch and fix the issues. Then try and resubmit:
( tools/checkpatch.pl out removed )
After rework, code in arch/c6x tools/checkpatch.pl 0001-Add-support-new-arch-c6x.patch tell me: "total: 0 errors, 39 warnings, 3065 lines checked" can i try send patch to list, or if not, what i must do with typedefs of global_data, volatile in asm/io.h and __kernel... types in asm/posix_types.h (all other arch has same code)?
tools/checkpatch.pl out now: $ tools/checkpatch.pl 0001-Add-support-new-arch-c6x.patch WARNING: do not add new typedefs #306: FILE: arch/c6x/include/asm/global_data.h:36: +typedef struct global_data {
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #364: FILE: arch/c6x/include/asm/global_data.h:94: +#define DECLARE_GLOBAL_DATA_PTR register volatile gd_t *gd asm ("B31")
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #394: FILE: arch/c6x/include/asm/io.h:14: +#define readb(addr) (*(volatile unsigned char *) (addr))
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #395: FILE: arch/c6x/include/asm/io.h:15: +#define readw(addr) (*(volatile unsigned short *) (addr))
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #396: FILE: arch/c6x/include/asm/io.h:16: +#define readl(addr) (*(volatile unsigned int *) (addr))
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #398: FILE: arch/c6x/include/asm/io.h:18: +#define writeb(b, addr) ((*(volatile unsigned char *) (addr)) = (b))
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #399: FILE: arch/c6x/include/asm/io.h:19: +#define writew(b, addr) ((*(volatile unsigned short *) (addr)) = (b))
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #400: FILE: arch/c6x/include/asm/io.h:20: +#define writel(b, addr) ((*(volatile unsigned int *) (addr)) = (b))
WARNING: do not add new typedefs #463: FILE: arch/c6x/include/asm/posix_types.h:18: +typedef unsigned int __kernel_dev_t;
WARNING: do not add new typedefs #464: FILE: arch/c6x/include/asm/posix_types.h:19: +typedef unsigned long __kernel_ino_t;
WARNING: do not add new typedefs #465: FILE: arch/c6x/include/asm/posix_types.h:20: +typedef unsigned long long __kernel_ino64_t;
WARNING: do not add new typedefs #466: FILE: arch/c6x/include/asm/posix_types.h:21: +typedef unsigned int __kernel_mode_t;
WARNING: do not add new typedefs #467: FILE: arch/c6x/include/asm/posix_types.h:22: +typedef unsigned int __kernel_nlink_t;
WARNING: do not add new typedefs #468: FILE: arch/c6x/include/asm/posix_types.h:23: +typedef long __kernel_off_t;
WARNING: do not add new typedefs #469: FILE: arch/c6x/include/asm/posix_types.h:24: +typedef long long __kernel_loff_t;
WARNING: do not add new typedefs #470: FILE: arch/c6x/include/asm/posix_types.h:25: +typedef int __kernel_pid_t;
WARNING: do not add new typedefs #471: FILE: arch/c6x/include/asm/posix_types.h:26: +typedef unsigned short __kernel_ipc_pid_t;
WARNING: do not add new typedefs #472: FILE: arch/c6x/include/asm/posix_types.h:27: +typedef unsigned int __kernel_uid_t;
WARNING: do not add new typedefs #473: FILE: arch/c6x/include/asm/posix_types.h:28: +typedef unsigned int __kernel_gid_t;
WARNING: do not add new typedefs #474: FILE: arch/c6x/include/asm/posix_types.h:29: +typedef unsigned int __kernel_size_t;
WARNING: do not add new typedefs #475: FILE: arch/c6x/include/asm/posix_types.h:30: +typedef int __kernel_ssize_t;
WARNING: do not add new typedefs #476: FILE: arch/c6x/include/asm/posix_types.h:31: +typedef int __kernel_ptrdiff_t;
WARNING: do not add new typedefs #477: FILE: arch/c6x/include/asm/posix_types.h:32: +typedef long __kernel_time_t;
WARNING: do not add new typedefs #478: FILE: arch/c6x/include/asm/posix_types.h:33: +typedef long __kernel_suseconds_t;
WARNING: do not add new typedefs #479: FILE: arch/c6x/include/asm/posix_types.h:34: +typedef long __kernel_clock_t;
WARNING: do not add new typedefs #480: FILE: arch/c6x/include/asm/posix_types.h:35: +typedef int __kernel_daddr_t;
WARNING: do not add new typedefs #481: FILE: arch/c6x/include/asm/posix_types.h:36: +typedef char *__kernel_caddr_t;
WARNING: do not add new typedefs #482: FILE: arch/c6x/include/asm/posix_types.h:37: +typedef unsigned short __kernel_uid16_t;
WARNING: do not add new typedefs #483: FILE: arch/c6x/include/asm/posix_types.h:38: +typedef unsigned short __kernel_gid16_t;
WARNING: do not add new typedefs #484: FILE: arch/c6x/include/asm/posix_types.h:39: +typedef unsigned int __kernel_uid32_t;
WARNING: do not add new typedefs #485: FILE: arch/c6x/include/asm/posix_types.h:40: +typedef unsigned int __kernel_gid32_t;
WARNING: do not add new typedefs #487: FILE: arch/c6x/include/asm/posix_types.h:42: +typedef unsigned short __kernel_old_uid_t;
WARNING: do not add new typedefs #488: FILE: arch/c6x/include/asm/posix_types.h:43: +typedef unsigned short __kernel_old_gid_t;
WARNING: do not add new typedefs #491: FILE: arch/c6x/include/asm/posix_types.h:46: +typedef struct {
WARNING: do not add new typedefs #942: FILE: arch/c6x/include/asm/types.h:4: +typedef unsigned short umode_t;
WARNING: do not add new typedefs #986: FILE: arch/c6x/include/asm/types.h:48: +typedef unsigned long phys_addr_t;
WARNING: do not add new typedefs #987: FILE: arch/c6x/include/asm/types.h:49: +typedef unsigned long phys_size_t;
WARNING: do not add new typedefs #1056: FILE: arch/c6x/include/asm/u-boot.h:39: +typedef struct bd_info {
WARNING: do not add new typedefs #2328: FILE: arch/c6x/lib/divull.c:132: +typedef union {
total: 0 errors, 39 warnings, 3065 lines checked
Dear bond@inmys.ru,
In message 31ab63da18246416f011fefc86653461.squirrel@78.108.93.81 you wrote:
After rework, code in arch/c6x tools/checkpatch.pl 0001-Add-support-new-arch-c6x.patch tell me: "total: 0 errors, 39 warnings, 3065 lines checked"
Thanks.
can i try send patch to list, or if not, what i must do with typedefs of global_data, volatile in asm/io.h and __kernel... types in asm/posix_types.h (all other arch has same code)?
If you really need to come up with your own versions of asm/io.h, asm/posix_types.h etc. the typedefs are probably OK.
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #394: FILE: arch/c6x/include/asm/io.h:14: +#define readb(addr) (*(volatile unsigned char *) (addr))
This is indeed unacceptable code, as it does not contain any kind of memory barrier instructions. Please use proper I/O accessors, resp. define such.
Best regards,
Wolfgang Denk
participants (3)
-
bond＠inmys.ru -
Dmitry Bondar
-
Wolfgang Denk