[U-Boot] [PATCH 1/2] gpio: da8xx: Add k2g compatible
Add k2g compatible so that k3 SoCs can be supported
Signed-off-by: Keerthy j-keerthy@ti.com --- drivers/gpio/da8xx_gpio.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/da8xx_gpio.c b/drivers/gpio/da8xx_gpio.c index b0d49cb..494fc5f 100644 --- a/drivers/gpio/da8xx_gpio.c +++ b/drivers/gpio/da8xx_gpio.c @@ -530,6 +530,7 @@ static int davinci_gpio_probe(struct udevice *dev)
static const struct udevice_id davinci_gpio_ids[] = { { .compatible = "ti,dm6441-gpio" }, + { .compatible = "ti,k2g-gpio" }, { } };
Push generic defines of gpio.h out of mach-davinci to drivers/gpio now that non-davinci architectures are beginning to use this IP.
Signed-off-by: Keerthy j-keerthy@ti.com --- arch/arm/mach-davinci/include/mach/gpio.h | 32 ---------------------- drivers/gpio/da8xx_gpio.c | 7 +++-- drivers/gpio/da8xx_gpio.h | 44 +++++++++++++++++++++++++++++++ 3 files changed, 49 insertions(+), 34 deletions(-) create mode 100644 drivers/gpio/da8xx_gpio.h
diff --git a/arch/arm/mach-davinci/include/mach/gpio.h b/arch/arm/mach-davinci/include/mach/gpio.h index d4b25c3..3981978 100644 --- a/arch/arm/mach-davinci/include/mach/gpio.h +++ b/arch/arm/mach-davinci/include/mach/gpio.h @@ -21,27 +21,6 @@ #define DAVINCI_GPIO_BANK8 0x01E260B0 #endif /* CONFIG_SOC_DA8XX */
-struct davinci_gpio { - unsigned int dir; - unsigned int out_data; - unsigned int set_data; - unsigned int clr_data; - unsigned int in_data; - unsigned int set_rising; - unsigned int clr_rising; - unsigned int set_falling; - unsigned int clr_falling; - unsigned int intstat; -}; - -struct davinci_gpio_bank { - int num_gpio; - unsigned int irq_num; - unsigned int irq_mask; - unsigned long *in_use; - struct davinci_gpio *base; -}; - #define davinci_gpio_bank01 ((struct davinci_gpio *)DAVINCI_GPIO_BANK01) #define davinci_gpio_bank23 ((struct davinci_gpio *)DAVINCI_GPIO_BANK23) #define davinci_gpio_bank45 ((struct davinci_gpio *)DAVINCI_GPIO_BANK45) @@ -61,18 +40,7 @@ struct davinci_gpio_bank { #define MAX_NUM_GPIOS 144 #endif #define GPIO_BANK(gp) (davinci_gpio_bank01 + ((gp) >> 5)) -#define GPIO_BIT(gp) ((gp) & 0x1F)
void gpio_info(void);
-#ifdef CONFIG_DM_GPIO - -/* Information about a GPIO bank */ -struct davinci_gpio_platdata { - int bank_index; - ulong base; /* address of registers in physical memory */ - const char *port_name; -}; -#endif - #endif diff --git a/drivers/gpio/da8xx_gpio.c b/drivers/gpio/da8xx_gpio.c index 494fc5f..bd79448 100644 --- a/drivers/gpio/da8xx_gpio.c +++ b/drivers/gpio/da8xx_gpio.c @@ -11,11 +11,14 @@ #include <fdtdec.h> #include <asm/io.h> #include <asm/gpio.h> -#include <asm/arch/hardware.h> -#include <asm/arch/davinci_misc.h> #include <dt-bindings/gpio/gpio.h>
+#include "da8xx_gpio.h" + #ifndef CONFIG_DM_GPIO +#include <asm/arch/hardware.h> +#include <asm/arch/davinci_misc.h> + static struct gpio_registry { int is_registered; char name[GPIO_NAME_SIZE]; diff --git a/drivers/gpio/da8xx_gpio.h b/drivers/gpio/da8xx_gpio.h new file mode 100644 index 0000000..ffaa567 --- /dev/null +++ b/drivers/gpio/da8xx_gpio.h @@ -0,0 +1,44 @@ +/* + * Copyright (C) 2009 Texas Instruments Incorporated + * + * SPDX-License-Identifier: GPL-2.0+ + */ +#ifndef _GPIO_DA8XX_DEFS_H_ +#define _GPIO_DA8XX_DEFS_H_ + +struct davinci_gpio { + unsigned int dir; + unsigned int out_data; + unsigned int set_data; + unsigned int clr_data; + unsigned int in_data; + unsigned int set_rising; + unsigned int clr_rising; + unsigned int set_falling; + unsigned int clr_falling; + unsigned int intstat; +}; + +struct davinci_gpio_bank { + int num_gpio; + unsigned int irq_num; + unsigned int irq_mask; + unsigned long *in_use; + struct davinci_gpio *base; +}; + +#define GPIO_NAME_SIZE 20 +#define MAX_NUM_GPIOS 144 +#define GPIO_BIT(gp) ((gp) & 0x1F) + +#ifdef CONFIG_DM_GPIO + +/* Information about a GPIO bank */ +struct davinci_gpio_platdata { + int bank_index; + ulong base; /* address of registers in physical memory */ + const char *port_name; +}; +#endif + +#endif
On Wed, Oct 03, 2018 at 04:09:31PM +0530, Keerthy wrote:
Push generic defines of gpio.h out of mach-davinci to drivers/gpio now that non-davinci architectures are beginning to use this IP.
Signed-off-by: Keerthy j-keerthy@ti.com
[snip]
diff --git a/drivers/gpio/da8xx_gpio.h b/drivers/gpio/da8xx_gpio.h new file mode 100644 index 0000000..ffaa567 --- /dev/null +++ b/drivers/gpio/da8xx_gpio.h @@ -0,0 +1,44 @@ +/*
- Copyright (C) 2009 Texas Instruments Incorporated
- SPDX-License-Identifier: GPL-2.0+
- */
The tag should be the first line as: // SPDX-License-Identifier: GPL-2.0+ just like in Linux, thanks!
On Wednesday 03 October 2018 05:41 PM, Tom Rini wrote:
On Wed, Oct 03, 2018 at 04:09:31PM +0530, Keerthy wrote:
Push generic defines of gpio.h out of mach-davinci to drivers/gpio now that non-davinci architectures are beginning to use this IP.
Signed-off-by: Keerthy j-keerthy@ti.com
[snip]
diff --git a/drivers/gpio/da8xx_gpio.h b/drivers/gpio/da8xx_gpio.h new file mode 100644 index 0000000..ffaa567 --- /dev/null +++ b/drivers/gpio/da8xx_gpio.h @@ -0,0 +1,44 @@ +/*
- Copyright (C) 2009 Texas Instruments Incorporated
- SPDX-License-Identifier: GPL-2.0+
- */
The tag should be the first line as: // SPDX-License-Identifier: GPL-2.0+ just like in Linux, thanks!
Oops will fix that. Thanks for catching it.
On Wed, Oct 03, 2018 at 04:09:30PM +0530, Keerthy wrote:
Add k2g compatible so that k3 SoCs can be supported
Signed-off-by: Keerthy j-keerthy@ti.com
Reviewed-by: Tom Rini trini@konsulko.com
participants (2)
-
Keerthy -
Tom Rini