[U-Boot] [PATCH] video: mxsfb: Break the line in videomode message
Currently we have the following on boot:
CPU: Freescale i.MX28 rev1.2 at 454 MHz BOOT: SSP SD/MMC #0, 3V3 DRAM: 128 MiB MMC: MXS MMC: 0 Video: MXSFB: 'videomode' variable not set!In: serial
Break the line of the warning message in order to have a better reading format.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- drivers/video/mxsfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index b189419..411d356 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -137,7 +137,7 @@ void *video_hw_init(void) /* Suck display configuration from "videomode" variable */ penv = getenv("videomode"); if (!penv) { - printf("MXSFB: 'videomode' variable not set!"); + printf("MXSFB: 'videomode' variable not set!\n"); return NULL; }
Dear Fabio Estevam,
Currently we have the following on boot:
CPU: Freescale i.MX28 rev1.2 at 454 MHz BOOT: SSP SD/MMC #0, 3V3 DRAM: 128 MiB MMC: MXS MMC: 0 Video: MXSFB: 'videomode' variable not set!In: serial
Break the line of the warning message in order to have a better reading format.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
drivers/video/mxsfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index b189419..411d356 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -137,7 +137,7 @@ void *video_hw_init(void) /* Suck display configuration from "videomode" variable */ penv = getenv("videomode"); if (!penv) {
printf("MXSFB: 'videomode' variable not set!");
printf("MXSFB: 'videomode' variable not set!\n");
puts() ... and you might want to fix it in all drivers ;-)
return NULL;}
Best regards, Marek Vasut
Hi Fabio, hi Marek,
On 26/06/2013 21:56, Marek Vasut wrote:
Dear Fabio Estevam,
Currently we have the following on boot:
CPU: Freescale i.MX28 rev1.2 at 454 MHz BOOT: SSP SD/MMC #0, 3V3 DRAM: 128 MiB MMC: MXS MMC: 0 Video: MXSFB: 'videomode' variable not set!In: serial
Break the line of the warning message in order to have a better reading format.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
drivers/video/mxsfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index b189419..411d356 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -137,7 +137,7 @@ void *video_hw_init(void) /* Suck display configuration from "videomode" variable */ penv = getenv("videomode"); if (!penv) {
printf("MXSFB: 'videomode' variable not set!");
printf("MXSFB: 'videomode' variable not set!\n");puts() ... and you might want to fix it in all drivers ;-)
That is correct - as it is a very small change, I fix it myself by applying the patch.
Applied to u-boot-imx, thanks !
Best regards, Stefano Babic
On Fri, Jun 28, 2013 at 11:57 AM, Stefano Babic sbabic@denx.de wrote:
That is correct - as it is a very small change, I fix it myself by applying the patch.
Thanks, Stefano!
Applied to u-boot-imx, thanks !
Best regards, Stefano Babic
participants (4)
-
Fabio Estevam -
Fabio Estevam -
Marek Vasut -
Stefano Babic