RE: [U-Boot-Users] .../board/fads/flash.c confuses me - give me a hint

Hi
I am not convinced drivers/cfi.flash.c performs correctly on the VersatilePB board - I am currently working on a patch.....
I believe::
static int flash_full_status_check (flash_info_t * info, flash_sect_t sector, ulong tout, char *prompt) { int retcode;
retcode = flash_status_check (info, sector, tout, prompt); switch (info->vendor) { case CFI_CMDSET_INTEL_EXTENDED: case CFI_CMDSET_INTEL_STANDARD: if ((retcode != ERR_OK) && !flash_isequal (info, sector, 0, FLASH_STATUS_DONE)) {
**
retcode = ERR_INVAL;
should be
static int flash_full_status_check (flash_info_t * info, flash_sect_t sector, ulong tout, char *prompt) { int retcode;
retcode = flash_status_check (info, sector, tout, prompt); switch (info->vendor) { case CFI_CMDSET_INTEL_EXTENDED: case CFI_CMDSET_INTEL_STANDARD: if ((retcode != ERR_OK) || !flash_isequal (info, sector, 0, FLASH_STATUS_DONE)) {
**
retcode = ERR_INVAL;
But perhaps only on VersatilePB.
Regards
Peter
participants (1)
-
Peter Pearse