[U-Boot] [PATCH] fastboot: Dynamic controller index for usb_gadget_handle_interrupts
Since we're now using a dynamic controller index for fastboot too, usb_gadget_handle_interrupts should be using it instead of 0 (despite the fact that it's currently not being used at all in the musb-new implementation).
Signed-off-by: Paul Kocialkowski contact@paulk.fr --- common/cmd_fastboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c index 86fbddf..b9d1c8c 100644 --- a/common/cmd_fastboot.c +++ b/common/cmd_fastboot.c @@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) break; if (ctrlc()) break; - usb_gadget_handle_interrupts(0); + usb_gadget_handle_interrupts(controller_index); }
ret = CMD_RET_SUCCESS;
Hi Paul,
Since we're now using a dynamic controller index for fastboot too, usb_gadget_handle_interrupts should be using it instead of 0 (despite the fact that it's currently not being used at all in the musb-new implementation).
Signed-off-by: Paul Kocialkowski contact@paulk.fr
common/cmd_fastboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c index 86fbddf..b9d1c8c 100644 --- a/common/cmd_fastboot.c +++ b/common/cmd_fastboot.c @@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) break; if (ctrlc()) break;
usb_gadget_handle_interrupts(0);
usb_gadget_handle_interrupts(controller_index);}
ret = CMD_RET_SUCCESS;
Reviewed-by: Lukasz Majewski l.majewski@samsung.com
On 25 May 2015 at 08:50, Lukasz Majewski l.majewski@samsung.com wrote:
Hi Paul,
Since we're now using a dynamic controller index for fastboot too, usb_gadget_handle_interrupts should be using it instead of 0 (despite the fact that it's currently not being used at all in the musb-new implementation).
Signed-off-by: Paul Kocialkowski contact@paulk.fr
common/cmd_fastboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c index 86fbddf..b9d1c8c 100644 --- a/common/cmd_fastboot.c +++ b/common/cmd_fastboot.c @@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) break; if (ctrlc()) break;
usb_gadget_handle_interrupts(0);
usb_gadget_handle_interrupts(controller_index); } ret = CMD_RET_SUCCESS;Reviewed-by: Lukasz Majewski l.majewski@samsung.com
This is in my queue and looks like a fix, so I'm picking it up.
Applied to u-boot-x86, thanks!
On Sun, 7 Jun 2015 08:48:31 -0600 Simon Glass sjg@chromium.org wrote:
On 25 May 2015 at 08:50, Lukasz Majewski l.majewski@samsung.com wrote:
Hi Paul,
Since we're now using a dynamic controller index for fastboot too, usb_gadget_handle_interrupts should be using it instead of 0 (despite the fact that it's currently not being used at all in the musb-new implementation).
Signed-off-by: Paul Kocialkowski contact@paulk.fr
common/cmd_fastboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c index 86fbddf..b9d1c8c 100644 --- a/common/cmd_fastboot.c +++ b/common/cmd_fastboot.c @@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) break; if (ctrlc()) break;
usb_gadget_handle_interrupts(0);
usb_gadget_handle_interrupts(controller_index); } ret = CMD_RET_SUCCESS;Reviewed-by: Lukasz Majewski l.majewski@samsung.com
This is in my queue and looks like a fix, so I'm picking it up.
Applied to u-boot-x86, thanks!
One less to go ;-).
Thanks Simon.
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Hi Paul,
On 7 June 2015 at 08:48, Simon Glass sjg@chromium.org wrote:
On 25 May 2015 at 08:50, Lukasz Majewski l.majewski@samsung.com wrote:
Hi Paul,
Since we're now using a dynamic controller index for fastboot too, usb_gadget_handle_interrupts should be using it instead of 0 (despite the fact that it's currently not being used at all in the musb-new implementation).
Signed-off-by: Paul Kocialkowski contact@paulk.fr
common/cmd_fastboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c index 86fbddf..b9d1c8c 100644 --- a/common/cmd_fastboot.c +++ b/common/cmd_fastboot.c @@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) break; if (ctrlc()) break;
usb_gadget_handle_interrupts(0);
usb_gadget_handle_interrupts(controller_index); } ret = CMD_RET_SUCCESS;Reviewed-by: Lukasz Majewski l.majewski@samsung.com
This is in my queue and looks like a fix, so I'm picking it up.
Applied to u-boot-x86, thanks!
Unfortunately in my final build test this breaks a number of boards, including:
am335x_boneblack_vboot
common/cmd_fastboot.c:36:32: error: ‘controller_index’ undeclared (first use in this function) usb_gadget_handle_interrupts(controller_index);
Can you please take a look and respin it?
For now I've dropped it from u-boot-x86.
Regards, Simon
[snip]
Reviewed-by: Lukasz Majewski l.majewski@samsung.com
This is in my queue and looks like a fix, so I'm picking it up.
Applied to u-boot-x86, thanks!
Unfortunately in my final build test this breaks a number of boards, including:
am335x_boneblack_vboot
common/cmd_fastboot.c:36:32: error: ‘controller_index’ undeclared (first use in this function) usb_gadget_handle_interrupts(controller_index);
Can you please take a look and respin it?
Of course, this makes perfect sense. I didn't think about it until now, but this patch goes on top of the four fastboot-related dfu patches that I sent out (again) yesterday.
I think this should be picked up along with those patches. Lukasz, could you do that?
Thanks
For now I've dropped it from u-boot-x86.
Makes sense.
Le lundi 25 mai 2015 à 16:50 +0200, Lukasz Majewski a écrit :
Hi Paul,
Since we're now using a dynamic controller index for fastboot too, usb_gadget_handle_interrupts should be using it instead of 0 (despite the fact that it's currently not being used at all in the musb-new implementation).
Signed-off-by: Paul Kocialkowski contact@paulk.fr
common/cmd_fastboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c index 86fbddf..b9d1c8c 100644 --- a/common/cmd_fastboot.c +++ b/common/cmd_fastboot.c @@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) break; if (ctrlc()) break;
usb_gadget_handle_interrupts(0);
usb_gadget_handle_interrupts(controller_index);}
ret = CMD_RET_SUCCESS;
Reviewed-by: Lukasz Majewski l.majewski@samsung.com
Now that the other patches have been merged, this one could be as well.
Lukasz, is there anything else holding it back?
Le mardi 07 juillet 2015 à 14:29 +0200, Paul Kocialkowski a écrit :
Le lundi 25 mai 2015 à 16:50 +0200, Lukasz Majewski a écrit :
Hi Paul,
Since we're now using a dynamic controller index for fastboot too, usb_gadget_handle_interrupts should be using it instead of 0 (despite the fact that it's currently not being used at all in the musb-new implementation).
Signed-off-by: Paul Kocialkowski contact@paulk.fr
common/cmd_fastboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c index 86fbddf..b9d1c8c 100644 --- a/common/cmd_fastboot.c +++ b/common/cmd_fastboot.c @@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) break; if (ctrlc()) break;
usb_gadget_handle_interrupts(0);
usb_gadget_handle_interrupts(controller_index);}
ret = CMD_RET_SUCCESS;
Reviewed-by: Lukasz Majewski l.majewski@samsung.com
Now that the other patches have been merged, this one could be as well.
Lukasz, is there anything else holding it back?
It's been a week since I asked this. Any news?
Thanks!
Hi Paul,
Le mardi 07 juillet 2015 à 14:29 +0200, Paul Kocialkowski a écrit :
Le lundi 25 mai 2015 à 16:50 +0200, Lukasz Majewski a écrit :
Hi Paul,
Since we're now using a dynamic controller index for fastboot too, usb_gadget_handle_interrupts should be using it instead of 0 (despite the fact that it's currently not being used at all in the musb-new implementation).
Signed-off-by: Paul Kocialkowski contact@paulk.fr
common/cmd_fastboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c index 86fbddf..b9d1c8c 100644 --- a/common/cmd_fastboot.c +++ b/common/cmd_fastboot.c @@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) break; if (ctrlc()) break;
usb_gadget_handle_interrupts(0);
usb_gadget_handle_interrupts(controller_index);}
ret = CMD_RET_SUCCESS;
Reviewed-by: Lukasz Majewski l.majewski@samsung.com
Now that the other patches have been merged, this one could be as well.
Lukasz, is there anything else holding it back?
It's been a week since I asked this. Any news?
Applied to u-boot-dfu tree.
Thanks for the patch!
Thanks!
participants (4)
-
Lukasz Majewski -
Lukasz Majewski -
Paul Kocialkowski -
Simon Glass