[PATCH 1/1] include/ata.h: remove invalid links
Remove invalid URLs for "Information Technology - AT Attachment-3 Interface (ATA-3)".
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- include/ata.h | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/include/ata.h b/include/ata.h index 3f4e4a0234..aecb9cd589 100644 --- a/include/ata.h +++ b/include/ata.h @@ -7,10 +7,6 @@ /* * Most of the following information was derived from the document * "Information Technology - AT Attachment-3 Interface (ATA-3)" - * which can be found at: - * http://www.dt.wdc.com/ata/ata-3/ata3r5v.zip - * ftp://poctok.iae.nsk.su/pub/asm/Documents/IDE/ATA3R5V.ZIP - * ftp://ftp.fee.vutbr.cz/pub/doc/io/ata/ata-3/ata3r5v.zip */
#ifndef _ATA_H -- 2.25.0
On Tue, Feb 25, 2020 at 10:04:53PM +0100, Heinrich Schuchardt wrote:
Remove invalid URLs for "Information Technology - AT Attachment-3 Interface (ATA-3)".
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
include/ata.h | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/include/ata.h b/include/ata.h index 3f4e4a0234..aecb9cd589 100644 --- a/include/ata.h +++ b/include/ata.h @@ -7,10 +7,6 @@ /*
- Most of the following information was derived from the document
- "Information Technology - AT Attachment-3 Interface (ATA-3)"
- which can be found at:
- ftp://poctok.iae.nsk.su/pub/asm/Documents/IDE/ATA3R5V.ZIP
*/
- ftp://ftp.fee.vutbr.cz/pub/doc/io/ata/ata-3/ata3r5v.zip
#ifndef _ATA_H
In this case, it looks like some of the relevant information about the spec, "Revision 5v" is encoded in the URL. I can't find a new link for it, but we should keep that information in the comment. Thanks!
On 2/25/20 10:30 PM, Tom Rini wrote:
On Tue, Feb 25, 2020 at 10:04:53PM +0100, Heinrich Schuchardt wrote:
Remove invalid URLs for "Information Technology - AT Attachment-3 Interface (ATA-3)".
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
include/ata.h | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/include/ata.h b/include/ata.h index 3f4e4a0234..aecb9cd589 100644 --- a/include/ata.h +++ b/include/ata.h @@ -7,10 +7,6 @@ /*
- Most of the following information was derived from the document
- "Information Technology - AT Attachment-3 Interface (ATA-3)"
- which can be found at:
- ftp://poctok.iae.nsk.su/pub/asm/Documents/IDE/ATA3R5V.ZIP
- ftp://ftp.fee.vutbr.cz/pub/doc/io/ata/ata-3/ata3r5v.zip
*/
#ifndef _ATA_H
In this case, it looks like some of the relevant information about the spec, "Revision 5v" is encoded in the URL. I can't find a new link for it, but we should keep that information in the comment. Thanks!
Hello Tom,
revision 5v is an early draft of ANSI X3.298-1997. On Jan 27th, 1997 there was a draft 7b. Google finds it when you look for 'ata-3-std.pdf site:github.com'.
The final standard ANSI X3.298-1997 is for sale here: https://webstore.ansi.org/standards/incits/ansix32981997
So I think we should simply point to the standard.
Best regards
Heinrich
On Wed, Feb 26, 2020 at 04:57:51AM +0100, Heinrich Schuchardt wrote:
On 2/25/20 10:30 PM, Tom Rini wrote:
On Tue, Feb 25, 2020 at 10:04:53PM +0100, Heinrich Schuchardt wrote:
Remove invalid URLs for "Information Technology - AT Attachment-3 Interface (ATA-3)".
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
include/ata.h | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/include/ata.h b/include/ata.h index 3f4e4a0234..aecb9cd589 100644 --- a/include/ata.h +++ b/include/ata.h @@ -7,10 +7,6 @@ /*
- Most of the following information was derived from the document
- "Information Technology - AT Attachment-3 Interface (ATA-3)"
- which can be found at:
- ftp://poctok.iae.nsk.su/pub/asm/Documents/IDE/ATA3R5V.ZIP
- ftp://ftp.fee.vutbr.cz/pub/doc/io/ata/ata-3/ata3r5v.zip
*/
#ifndef _ATA_H
In this case, it looks like some of the relevant information about the spec, "Revision 5v" is encoded in the URL. I can't find a new link for it, but we should keep that information in the comment. Thanks!
Hello Tom,
revision 5v is an early draft of ANSI X3.298-1997. On Jan 27th, 1997 there was a draft 7b. Google finds it when you look for 'ata-3-std.pdf site:github.com'.
The final standard ANSI X3.298-1997 is for sale here: https://webstore.ansi.org/standards/incits/ansix32981997
Yes.
So I think we should simply point to the standard.
I think we need to note what revision of the standard we wrote to, for future "hey, wait, there's a corner case we get wrong because we coded to an old draft" issues.
On 2/26/20 5:05 AM, Tom Rini wrote:
On Wed, Feb 26, 2020 at 04:57:51AM +0100, Heinrich Schuchardt wrote:
On 2/25/20 10:30 PM, Tom Rini wrote:
On Tue, Feb 25, 2020 at 10:04:53PM +0100, Heinrich Schuchardt wrote:
Remove invalid URLs for "Information Technology - AT Attachment-3 Interface (ATA-3)".
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
include/ata.h | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/include/ata.h b/include/ata.h index 3f4e4a0234..aecb9cd589 100644 --- a/include/ata.h +++ b/include/ata.h @@ -7,10 +7,6 @@ /* * Most of the following information was derived from the document * "Information Technology - AT Attachment-3 Interface (ATA-3)"
- which can be found at:
- ftp://poctok.iae.nsk.su/pub/asm/Documents/IDE/ATA3R5V.ZIP
- ftp://ftp.fee.vutbr.cz/pub/doc/io/ata/ata-3/ata3r5v.zip */
#ifndef _ATA_H
In this case, it looks like some of the relevant information about the spec, "Revision 5v" is encoded in the URL. I can't find a new link for it, but we should keep that information in the comment. Thanks!
Hello Tom,
revision 5v is an early draft of ANSI X3.298-1997. On Jan 27th, 1997 there was a draft 7b. Google finds it when you look for 'ata-3-std.pdf site:github.com'.
The final standard ANSI X3.298-1997 is for sale here: https://webstore.ansi.org/standards/incits/ansix32981997
Yes.
So I think we should simply point to the standard.
I think we need to note what revision of the standard we wrote to, for future "hey, wait, there's a corner case we get wrong because we coded to an old draft" issues.
ata.h includes libata.h which is at least partially based on ATA/ATAPI-7 (a later standard than ATA-3). Many defines in ata.h are simply duplicate or unused and should be removed. ata.h contains definitions of variables that are not in the draft 7b ATA-3 standard.
I have no document indicating if there ever was a revision 5v or if this is just our assumption due to the file name.
As ata.h is not based on a single revision of the ATA standard a reference to some draft revision will not provide guidance to any future developer. The future developer anyway will not have access to such a revision.
Best regards
Heinrich
participants (2)
-
Heinrich Schuchardt -
Tom Rini