[PATCH 1/1] efi_loader remove __packed from struct efi_configuration_table
struct efi_configuration_table is naturally packed. There is no need for a __packed attribute. Hence remove it.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- include/efi_api.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/efi_api.h b/include/efi_api.h index 22396172e1..a3ff140ac9 100644 --- a/include/efi_api.h +++ b/include/efi_api.h @@ -322,7 +322,7 @@ struct efi_runtime_services { struct efi_configuration_table { efi_guid_t guid; void *table; -} __packed; +};
#define EFI_SYSTEM_TABLE_SIGNATURE ((u64)0x5453595320494249ULL)
-- 2.24.1
On 12/28/19 3:54 PM, Heinrich Schuchardt wrote:
struct efi_configuration_table is naturally packed. There is no need for a __packed attribute. Hence remove it.
This holds true only on 64bit systems as we defined efi_guid_t to be 8-byte aligned. Instead adjust guidcpy to accept void *. See
https://lists.denx.de/pipermail/u-boot/2020-January/395409.html [PATCH v5 1/1] efi_loader: Add guidcpy function
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
include/efi_api.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/efi_api.h b/include/efi_api.h index 22396172e1..a3ff140ac9 100644 --- a/include/efi_api.h +++ b/include/efi_api.h @@ -322,7 +322,7 @@ struct efi_runtime_services { struct efi_configuration_table { efi_guid_t guid; void *table; -} __packed; +};
#define EFI_SYSTEM_TABLE_SIGNATURE ((u64)0x5453595320494249ULL)
-- 2.24.1
participants (1)
-
Heinrich Schuchardt