[PATCH v2] usb: dwc3-generic: Use combined glue and ctrl node for RK3588
Like Rockchip RK3328 and RK3568, the RK3588 also have a single node to represent the glue and ctrl for USB 3.0.
Use rk_ops as driver data to select correct ctrl node for RK3588 DWC3.
Signed-off-by: Jonas Karlman jonas@kwiboo.se Reviewed-by: Kever Yang kever.yang@rock-chips.com --- Changes in v2: - Required device tree changes have been merged into master - Collect r-b tag
The commit c1710bfc4fa0 ("rockchip: rk3588-rock-5b: Sync USB3 nodes from mainline linux patches") changed DT to use nodes matching the upstreamed dt-binding for DWC3 on RK3588. It is now safe to merge this patch.
drivers/usb/dwc3/dwc3-generic.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c index 744fde806948..6fb2de8a5ace 100644 --- a/drivers/usb/dwc3/dwc3-generic.c +++ b/drivers/usb/dwc3/dwc3-generic.c @@ -610,6 +610,7 @@ static const struct udevice_id dwc3_glue_ids[] = { { .compatible = "rockchip,rk3328-dwc3", .data = (ulong)&rk_ops }, { .compatible = "rockchip,rk3399-dwc3" }, { .compatible = "rockchip,rk3568-dwc3", .data = (ulong)&rk_ops }, + { .compatible = "rockchip,rk3588-dwc3", .data = (ulong)&rk_ops }, { .compatible = "qcom,dwc3" }, { .compatible = "fsl,imx8mp-dwc3", .data = (ulong)&imx8mp_ops }, { .compatible = "fsl,imx8mq-dwc3" },
On 11/12/23 16:25, Jonas Karlman wrote:
Like Rockchip RK3328 and RK3568, the RK3588 also have a single node to represent the glue and ctrl for USB 3.0.
Use rk_ops as driver data to select correct ctrl node for RK3588 DWC3.
Signed-off-by: Jonas Karlman jonas@kwiboo.se Reviewed-by: Kever Yang kever.yang@rock-chips.com
Reviewed-by: Marek Vasut marex@denx.de
Do you still want this in 2024.01 ? The MW closed just a few days ago, but this seems OKish to put in still .
Hi Marek,
On 2023-11-13 04:11, Marek Vasut wrote:
On 11/12/23 16:25, Jonas Karlman wrote:
Like Rockchip RK3328 and RK3568, the RK3588 also have a single node to represent the glue and ctrl for USB 3.0.
Use rk_ops as driver data to select correct ctrl node for RK3588 DWC3.
Signed-off-by: Jonas Karlman jonas@kwiboo.se Reviewed-by: Kever Yang kever.yang@rock-chips.com
Reviewed-by: Marek Vasut marex@denx.de
Do you still want this in 2024.01 ? The MW closed just a few days ago, but this seems OKish to put in still .
It should not matter if this goes to master or next. Next linux DT sync when this may be needed will probably not be until around v6.8-rc1.
Regards, Jonas
On 11/18/23 00:30, Jonas Karlman wrote:
Hi Marek,
Hi,
On 2023-11-13 04:11, Marek Vasut wrote:
On 11/12/23 16:25, Jonas Karlman wrote:
Like Rockchip RK3328 and RK3568, the RK3588 also have a single node to represent the glue and ctrl for USB 3.0.
Use rk_ops as driver data to select correct ctrl node for RK3588 DWC3.
Signed-off-by: Jonas Karlman jonas@kwiboo.se Reviewed-by: Kever Yang kever.yang@rock-chips.com
Reviewed-by: Marek Vasut marex@denx.de
Do you still want this in 2024.01 ? The MW closed just a few days ago, but this seems OKish to put in still .
It should not matter if this goes to master or next. Next linux DT sync when this may be needed will probably not be until around v6.8-rc1.
Applied to usb/master, thanks
participants (2)
-
Jonas Karlman -
Marek Vasut