[U-Boot] [PATCH] ncb: Check return value of write()
This prevents the compilation warning:
ncb.c: In function 'main': ncb.c:32: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result
Signed-off-by: Peter Tyser ptyser@xes-inc.com --- tools/ncb.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/tools/ncb.c b/tools/ncb.c index 30acbea..ec8d8a7 100644 --- a/tools/ncb.c +++ b/tools/ncb.c @@ -1,3 +1,4 @@ +#include <stdio.h> #include <stdlib.h> #include <unistd.h> #include <sys/socket.h> @@ -29,7 +30,8 @@ int main (int argc, char *argv[]) len = recvfrom (s, buf, sizeof buf, 0, (struct sockaddr *) &addr, &addr_len); if (len < 0) break; - write (1, buf, len); + if (write (1, buf, len) != len) + fprintf(stderr, "WARNING: serial characters dropped\n"); }
return 0;
Dear Peter Tyser,
In message 1240606786-32082-1-git-send-email-ptyser@xes-inc.com you wrote:
VGhpcyBwcmV2ZW50cyB0aGUgY29tcGlsYXRpb24gd2FybmluZzoKCm5jYi5jOiBJbiBmdW5jdGlv biAnbWFpbic6Cm5jYi5jOjMyOiB3YXJuaW5nOiBpZ25vcmluZyByZXR1cm4gdmFsdWUgb2Yg4oCY d3JpdGXigJksIGRlY2xhcmVkIHdpdGgKYXR0cmlidXRlIHdhcm5fdW51c2VkX3Jlc3VsdAoKU2ln bmVkLW9mZi1ieTogUGV0ZXIgVHlzZXIgPHB0eXNlckB4ZXMtaW5jLmNvbT4KLS0tCiB0b29scy9u Y2IuYyB8ICAgIDQgKysrLQogMSBmaWxlcyBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDEgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvdG9vbHMvbmNiLmMgYi90b29scy9uY2IuYwppbmRleCAz MGFjYmVhLi5lYzhkOGE3IDEwMDY0NAotLS0gYS90b29scy9uY2IuYworKysgYi90b29scy9uY2Iu YwpAQCAtMSwzICsxLDQgQEAKKyNpbmNsdWRlIDxzdGRpby5oPgogI2luY2x1ZGUgPHN0ZGxpYi5o PgogI2luY2x1ZGUgPHVuaXN0ZC5oPgogI2luY2x1ZGUgPHN5cy9zb2NrZXQuaD4KQEAgLTI5LDcg KzMwLDggQEAgaW50IG1haW4gKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAJCWxlbiA9IHJlY3Zm cm9tIChzLCBidWYsIHNpemVvZiBidWYsIDAsIChzdHJ1Y3Qgc29ja2FkZHIgKikgJmFkZHIsICZh ZGRyX2xlbik7CiAJCWlmIChsZW4gPCAwKQogCQkJYnJlYWs7Ci0JCXdyaXRlICgxLCBidWYsIGxl bik7CisJCWlmICh3cml0ZSAoMSwgYnVmLCBsZW4pICE9IGxlbikKKwkJCWZwcmludGYoc3RkZXJy LCAiV0FSTklORzogc2VyaWFsIGNoYXJhY3RlcnMgZHJvcHBlZFxuIik7CiAJfQogCiAJcmV0dXJu IDA7Ci0tIAoxLjYuMi4xCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpVLUJvb3QgbWFpbGluZyBsaXN0ClUtQm9vdEBsaXN0cy5kZW54LmRlCmh0dHA6Ly9s aXN0cy5kZW54LmRlL21haWxtYW4vbGlzdGluZm8vdS1ib290Cg==
Please don't post base64 encoded messages.
This prevents the compilation warning:
ncb.c: In function 'main': ncb.c:32: warning: ignoring return value of `write', declared with attribute warn_unused_result
Signed-off-by: Peter Tyser ptyser@xes-inc.com
tools/ncb.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (2)
-
Peter Tyser -
Wolfgang Denk