[U-Boot] [PATCH 1/5] wandboard: Staticize usdhc1_pads

From: Fabio Estevam fabio.estevam@freescale.com
Fix the following sparse warning:
wandboard.c:58:22: warning: symbol 'usdhc1_pads' was not declared. Should it be static?
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- board/wandboard/wandboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c index 72e9bb2..dbced1c 100644 --- a/board/wandboard/wandboard.c +++ b/board/wandboard/wandboard.c @@ -55,7 +55,7 @@ static iomux_v3_cfg_t const uart1_pads[] = { MX6_PAD_CSI0_DAT11__UART1_RX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL), };
-iomux_v3_cfg_t const usdhc1_pads[] = { +static iomux_v3_cfg_t const usdhc1_pads[] = { MX6_PAD_SD1_CLK__SD1_CLK | MUX_PAD_CTRL(USDHC_PAD_CTRL), MX6_PAD_SD1_CMD__SD1_CMD | MUX_PAD_CTRL(USDHC_PAD_CTRL), MX6_PAD_SD1_DAT0__SD1_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL),

From: Fabio Estevam fabio.estevam@freescale.com
Fixes the following sparse warning:
wandboard.c:137:5: warning: symbol 'board_mmc_init' was not declared. Should it be static?
Cc: Pantelis Antoniou panto@antoniou-consulting.com Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- include/mmc.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/include/mmc.h b/include/mmc.h index e1060b9..218c03f 100644 --- a/include/mmc.h +++ b/include/mmc.h @@ -349,4 +349,6 @@ struct mmc *mmc_spi_init(uint bus, uint cs, uint speed, uint mode); int mmc_legacy_init(int verbose); #endif
+int board_mmc_init(bd_t *bis); + #endif /* _MMC_H_ */

On 15/02/2014 17:51, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
Fixes the following sparse warning:
wandboard.c:137:5: warning: symbol 'board_mmc_init' was not declared. Should it be static?
Cc: Pantelis Antoniou panto@antoniou-consulting.com Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Applied to u-boot-imx, thanks !
Best regards, Stefano Babic

From: Fabio Estevam fabio.estevam@freescale.com
Add a prototype for board_phy_config() to fix the following sparse warning:
wandboard.c:200:5: warning: symbol 'board_phy_config' was not declared. Should it be static?
Cc: Joe Hershberger joe.hershberger@ni.com Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- board/wandboard/wandboard.c | 1 + include/phy.h | 2 ++ 2 files changed, 3 insertions(+)
diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c index dbced1c..6918614 100644 --- a/board/wandboard/wandboard.c +++ b/board/wandboard/wandboard.c @@ -25,6 +25,7 @@ #include <miiphy.h> #include <netdev.h> #include <linux/fb.h> +#include <phy.h>
DECLARE_GLOBAL_DATA_PTR;
diff --git a/include/phy.h b/include/phy.h index 1f22fa1..d3ecd63 100644 --- a/include/phy.h +++ b/include/phy.h @@ -234,6 +234,8 @@ int phy_smsc_init(void); int phy_teranetics_init(void); int phy_vitesse_init(void);
+int board_phy_config(struct phy_device *phydev); + /* PHY UIDs for various PHYs that are referenced in external code */ #define PHY_UID_TN2020 0x00a19410

On 15/02/2014 17:52, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
Add a prototype for board_phy_config() to fix the following sparse warning:
wandboard.c:200:5: warning: symbol 'board_phy_config' was not declared. Should it be static?
Cc: Joe Hershberger joe.hershberger@ni.com Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Applied to u-boot-imx, thanks !
Best regards, Stefano Babic

From: Fabio Estevam fabio.estevam@freescale.com
Include <input.h> in order to fix the following sparse warning:
wandboard.c:278:5: warning: symbol 'overwrite_console' was not declared. Should it be static?
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- board/wandboard/wandboard.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c index 6918614..c2c0e2e 100644 --- a/board/wandboard/wandboard.c +++ b/board/wandboard/wandboard.c @@ -26,6 +26,7 @@ #include <netdev.h> #include <linux/fb.h> #include <phy.h> +#include <input.h>
DECLARE_GLOBAL_DATA_PTR;

On 15/02/2014 17:52, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
Include <input.h> in order to fix the following sparse warning:
wandboard.c:278:5: warning: symbol 'overwrite_console' was not declared. Should it be static?
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Applied to u-boot-imx, thanks !
Best regards, Stefano Babic

From: Fabio Estevam fabio.estevam@freescale.com
Add a prototype for board_video_skip() in order to fix the following sparse warning:
wandboard.c:227:5: warning: symbol 'board_video_skip' was not declared. Should it be static?
Cc: Anatolij Gustschin agust@denx.de Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- include/linux/fb.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/include/linux/fb.h b/include/linux/fb.h index 111372c..652cf3b 100644 --- a/include/linux/fb.h +++ b/include/linux/fb.h @@ -612,6 +612,8 @@ struct fb_videomode { u32 flag; };
+int board_video_skip(void); + #endif /* __KERNEL__ */
#endif /* _LINUX_FB_H */

On 15/02/2014 17:52, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
Add a prototype for board_video_skip() in order to fix the following sparse warning:
wandboard.c:227:5: warning: symbol 'board_video_skip' was not declared. Should it be static?
Cc: Anatolij Gustschin agust@denx.de Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Applied to u-boot-imx, thanks !
Best regards, Stefano Babic

Hi Fabio,
On 15/02/2014 17:51, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
Fix the following sparse warning:
wandboard.c:58:22: warning: symbol 'usdhc1_pads' was not declared. Should it be static?
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
board/wandboard/wandboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c index 72e9bb2..dbced1c 100644 --- a/board/wandboard/wandboard.c +++ b/board/wandboard/wandboard.c @@ -55,7 +55,7 @@ static iomux_v3_cfg_t const uart1_pads[] = { MX6_PAD_CSI0_DAT11__UART1_RX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL), };
-iomux_v3_cfg_t const usdhc1_pads[] = { +static iomux_v3_cfg_t const usdhc1_pads[] = { MX6_PAD_SD1_CLK__SD1_CLK | MUX_PAD_CTRL(USDHC_PAD_CTRL), MX6_PAD_SD1_CMD__SD1_CMD | MUX_PAD_CTRL(USDHC_PAD_CTRL), MX6_PAD_SD1_DAT0__SD1_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
Thanks for fix it. However, which gcc version reports these warnings ? Surely I must update and test with a newer one: with gcc 4.6.4/4.7.2 I saw no error.
Regards, Stefano

Hi Stefano,
On Sun, Feb 16, 2014 at 9:15 AM, Stefano Babic sbabic@denx.de wrote:
Thanks for fix it. However, which gcc version reports these warnings ? Surely I must update and test with a newer one: with gcc 4.6.4/4.7.2 I saw no error.
In order to trigger the sparse warnings we need to build it as:
make -j4 C=1 2>wandboard.txt
Regards,
Fabio Estevam

On 16/02/2014 15:42, Fabio Estevam wrote:
make -j4 C=1 2>wandboard.txt
Thanks, Stefano

On 15/02/2014 17:51, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
Fix the following sparse warning:
wandboard.c:58:22: warning: symbol 'usdhc1_pads' was not declared. Should it be static?
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Applied to u-boot-imx, thanks !
Best regards, Stefano Babic
participants (2)
-
Fabio Estevam
-
Stefano Babic