[U-Boot] [PATCH 1/6] wandboard: Return from cpu_eth_init() directly
From: Fabio Estevam fabio.estevam@freescale.com
There is no need to print an error message when cpu_eth_init() fails because net/eth.c already prints it.
In order to simplify the code, just return the value from cpu_eth_init(bis) directly.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- board/wandboard/wandboard.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c index 0043bc6..72e9bb2 100644e --- a/board/wandboard/wandboard.c +++ b/board/wandboard/wandboard.c @@ -257,15 +257,9 @@ static void setup_display(void)
int board_eth_init(bd_t *bis) { - int ret; - setup_iomux_enet();
- ret = cpu_eth_init(bis); - if (ret) - printf("FEC MXC: %s:failed\n", __func__); - - return ret; + return cpu_eth_init(bis); }
int board_early_init_f(void)
From: Fabio Estevam fabio.estevam@freescale.com
There is no need to print an error message when cpu_eth_init() fails because net/eth.c already prints it.
In order to simplify the code, just return the value from cpu_eth_init(bis) directly.
Cc: Stefan Roese sr@denx.de Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- board/barco/titanium/titanium.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/board/barco/titanium/titanium.c b/board/barco/titanium/titanium.c index 6db4488..84a7b84 100644 --- a/board/barco/titanium/titanium.c +++ b/board/barco/titanium/titanium.c @@ -264,15 +264,9 @@ int board_phy_config(struct phy_device *phydev)
int board_eth_init(bd_t *bis) { - int ret; - setup_iomux_enet();
- ret = cpu_eth_init(bis); - if (ret) - printf("FEC MXC: %s:failed\n", __func__); - - return ret; + return cpu_eth_init(bis); }
int board_early_init_f(void)
From: Fabio Estevam fabio.estevam@freescale.com
There is no need to print an error message when cpu_eth_init() fails because net/eth.c already prints it.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- board/freescale/mx6qarm2/mx6qarm2.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/board/freescale/mx6qarm2/mx6qarm2.c b/board/freescale/mx6qarm2/mx6qarm2.c index e063407..79cd3fc 100644 --- a/board/freescale/mx6qarm2/mx6qarm2.c +++ b/board/freescale/mx6qarm2/mx6qarm2.c @@ -186,13 +186,9 @@ int fecmxc_mii_postcall(int phy) int board_eth_init(bd_t *bis) { struct eth_device *dev; - int ret; - - ret = cpu_eth_init(bis); - if (ret) { - printf("FEC MXC: %s:failed\n", __func__); + int ret = cpu_eth_init(bis); + if (ret) return ret; - }
dev = eth_get_dev_by_name("FEC"); if (!dev) {
Dear Fabio Estevam,
In message 1388853097-3068-3-git-send-email-festevam@gmail.com you wrote:
- int ret = cpu_eth_init(bis);
- if (ret) return ret;
Please separate declarations and code by a blank line. Thanks.
Best regards,
Wolfgang Denk
Hi Wolfgang,
On Sat, Jan 4, 2014 at 5:26 PM, Wolfgang Denk wd@denx.de wrote:
Dear Fabio Estevam,
In message 1388853097-3068-3-git-send-email-festevam@gmail.com you wrote:
int ret = cpu_eth_init(bis);if (ret) return ret;Please separate declarations and code by a blank line. Thanks.
Fixed in v2, thanks.
From: Fabio Estevam fabio.estevam@freescale.com
There is no need to print an error message when cpu_eth_init() fails because net/eth.c already prints it.
In order to simplify the code, just return the value from cpu_eth_init(bis) directly.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- board/freescale/mx6qsabreauto/mx6qsabreauto.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/board/freescale/mx6qsabreauto/mx6qsabreauto.c b/board/freescale/mx6qsabreauto/mx6qsabreauto.c index fc75eae..928dadf 100644 --- a/board/freescale/mx6qsabreauto/mx6qsabreauto.c +++ b/board/freescale/mx6qsabreauto/mx6qsabreauto.c @@ -192,15 +192,9 @@ int board_phy_config(struct phy_device *phydev)
int board_eth_init(bd_t *bis) { - int ret; - setup_iomux_enet();
- ret = cpu_eth_init(bis); - if (ret) - printf("FEC MXC: %s:failed\n", __func__); - - return ret; + return cpu_eth_init(bis); }
#define BOARD_REV_B 0x200
From: Fabio Estevam fabio.estevam@freescale.com
There is no need to print an error message when cpu_eth_init() fails because net/eth.c already prints it.
In order to simplify the code, just return the value from cpu_eth_init(bis) directly.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- board/freescale/mx6sabresd/mx6sabresd.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c index 2ffc3b8..12d8c56 100644 --- a/board/freescale/mx6sabresd/mx6sabresd.c +++ b/board/freescale/mx6sabresd/mx6sabresd.c @@ -453,15 +453,9 @@ int overwrite_console(void)
int board_eth_init(bd_t *bis) { - int ret; - setup_iomux_enet();
- ret = cpu_eth_init(bis); - if (ret) - printf("FEC MXC: %s:failed\n", __func__); - - return ret; + return cpu_eth_init(bis); }
int board_early_init_f(void)
From: Fabio Estevam fabio.estevam@freescale.com
There is no need to print an error message when cpu_eth_init() fails because net/eth.c already prints it.
In order to simplify the code, just return the value from cpu_eth_init(bis) directly.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- board/freescale/mx6slevk/mx6slevk.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/board/freescale/mx6slevk/mx6slevk.c b/board/freescale/mx6slevk/mx6slevk.c index 47c04ce..c496254 100644 --- a/board/freescale/mx6slevk/mx6slevk.c +++ b/board/freescale/mx6slevk/mx6slevk.c @@ -106,17 +106,9 @@ int board_mmc_init(bd_t *bis) #ifdef CONFIG_FEC_MXC int board_eth_init(bd_t *bis) { - int ret; - setup_iomux_fec();
- ret = cpu_eth_init(bis); - if (ret) { - printf("FEC MXC: %s:failed\n", __func__); - return ret; - } - - return 0; + return cpu_eth_init(bis); }
static int setup_fec(void)
participants (2)
-
Fabio Estevam -
Wolfgang Denk