On 1/27/21 9:19 PM, Gary Bisson wrote:

Fixes issues when switching from GPT to MBR partition tables.

This does not catch all cases of changing the MBR. See function write_mbr_partitions() with writes both the MBR and EBRs (if applicable).

Android devices typically have more than 4 partitions. Why does fastboot not update the extended boot records?

Best regards

Heinrich

Signed-off-by: Gary Bisson gary.bisson@boundarydevices.com

Hi,

Sending this patch as a follow-up to the other one [1] doing the same thing for GPT write.

Let me know if you have any questions.

Regards, Gary

[1] https://lists.denx.de/pipermail/u-boot/2021-January/438764.html

disk/part_dos.c | 3 +++ 1 file changed, 3 insertions(+)

diff --git a/disk/part_dos.c b/disk/part_dos.c index f431925745..470886f4bb 100644 --- a/disk/part_dos.c +++ b/disk/part_dos.c @@ -499,6 +499,9 @@ int write_mbr_sector(struct blk_desc *dev_desc, void *buf) return 1; }

• /* Update the partition table entries*/
• part_init(dev_desc);
• return 0; }

Fixes issues when switching from GPT to MBR partition tables.

Signed-off-by: Gary Bisson gary.bisson@boundarydevices.com --- Changes for v2: - added part_init() inside write_mbr_partitions(), as suggested by Heinrich --- disk/part_dos.c | 6 ++++++ 1 file changed, 6 insertions(+)

diff --git a/disk/part_dos.c b/disk/part_dos.c index f431925745c..60addc6e00d 100644 --- a/disk/part_dos.c +++ b/disk/part_dos.c @@ -423,6 +423,9 @@ int write_mbr_partitions(struct blk_desc *dev, ext_part_sect = next_ebr; }

+ /* Update the partition table entries*/ + part_init(dev_desc); + return 0; }

@@ -499,6 +502,9 @@ int write_mbr_sector(struct blk_desc *dev_desc, void *buf) return 1; }

+ /* Update the partition table entries*/ + part_init(dev_desc); + return 0; }