[U-Boot-Users] CFG_LOAD_ADDR vs. CONFIG_LOADADDR vs. CFG_TFTP_LOADADDR

What's the difference between CFG_LOAD_ADDR and CONFIG_LOADADDR? Looking at the code, it looks like their both used as default load addresses, but I don't see why they should have different values (they do in most header files).
The README also talks about CFG_TFTP_LOADADDR, but I don't see where that's used in the code.

In message 45A51B26.4030803@freescale.com you wrote:
What's the difference between CFG_LOAD_ADDR and CONFIG_LOADADDR? Looking at the
One underscore, a 'O', a 'N', and a 'I' ;-)
CFG_LOAD_ADDR is what you are supposed to use in the code.
CONFIG_LOADADDR is the value used to initialize the "loadaddr" variable in the default environment.
code, it looks like their both used as default load addresses, but I don't see why they should have different values (they do in most header files).
I see little reason to define CONFIG_LOADADDR at all.
The README also talks about CFG_TFTP_LOADADDR, but I don't see where that's used in the code.
It ain't used, and should be removed.
Best regards,
Wolfgang Denk

Wolfgang Denk wrote:
What's the difference between CFG_LOAD_ADDR and CONFIG_LOADADDR? Looking at the
One underscore, a 'O', a 'N', and a 'I' ;-)
Otto Waalkes could take lessons from you.
CFG_LOAD_ADDR is what you are supposed to use in the code.
CONFIG_LOADADDR is the value used to initialize the "loadaddr" variable in the default environment.
code, it looks like their both used as default load addresses, but I don't see why they should have different values (they do in most header files).
I see little reason to define CONFIG_LOADADDR at all.
Then what's the best way to define a default value for the "loadaddr" variable?

In message 45A5776C.9060409@freescale.com you wrote:
CONFIG_LOADADDR is the value used to initialize the "loadaddr" variable in the default environment.
...
I see little reason to define CONFIG_LOADADDR at all.
Then what's the best way to define a default value for the "loadaddr" variable?
Define CONFIG_LOADADDR.
But, as mentioned implicitely before, I see little reason to define the "loadaddr" variable at all.
Define CFG_LOAD_ADDR, and that's it. Having more than one defualt value seems a broken design to me.
Best regards,
Wolfgang Denk
participants (2)
-
Timur Tabi
-
Wolfgang Denk