[U-Boot-Users] [PATCH] cmdbootz

Hi Wolfgang,
I've rewritten the bootm command to recognize an ARM zImage the same way as it already does with i368 zImages, hope that's ok with you.
ChangeLog:
* Patch by Robert Schwebel, 15 May 2004 Modify the bootm command to be also able to start Linux zImages on ARM (x86 already works this way). Made processor detection more readable. Print warning when verify is switched off because of faked headers (was silently droped). Make CRC vs. Checksum output consistent.
Robert

In message 20040515145022.GK27774@pengutronix.de you wrote:
I've rewritten the bootm command to recognize an ARM zImage the same way as it already does with i368 zImages, hope that's ok with you.
Sorry, but it is not. I reject this modification.
As the comment in bootm says:
-#ifdef __I386__ /* correct image format not implemented yet - fake it */
if (fake_header(hdr, (void*)addr, -1) != NULL) {
The fact that one implementation, which is far from being complete, fails to implement something correctly, does not justuify to make this failure a standard.
Also, it makes no sense to me to implement this feature (should it be useful and needed) just for ARM - if it gets accepted, then I want to have a consistent interface for ALL architectures.
Anyway. "bootm" is a command to boot U-Boot images, which include the header. If you want to boot something else, then bootm is not the right command to use.
Best regards,
Wolfgang Denk
participants (2)
-
Robert Schwebel
-
Wolfgang Denk