[U-Boot] [PATCH] cmd: i2c: Fix help output of i2c command.

In case SYS_I2C or DM_I2C are defined, then the "i2c " prefix of the "i2c crc32" command is missing. This patch addresses this, so that users can't get confused by the "crc32" command.
Without the patch we get
=> i2c help i2c - I2C sub-system
Usage: i2c bus [muxtype:muxaddr:muxchannel] - show I2C bus info crc32 chip address[.0, .1, .2] count - compute CRC32 checksum i2c dev [dev] - show or set current I2C bus [...]
With the patch we get
=> i2c help i2c - I2C sub-system
Usage: i2c bus [muxtype:muxaddr:muxchannel] - show I2C bus info i2c crc32 chip address[.0, .1, .2] count - compute CRC32 checksum i2c dev [dev] - show or set current I2C bus ...
Signed-off-by: Christoph Muellner christoph.muellner@theobroma-systems.com --- cmd/i2c.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/cmd/i2c.c b/cmd/i2c.c index 56df8eb3bca..09c4ba9a1c7 100644 --- a/cmd/i2c.c +++ b/cmd/i2c.c @@ -2023,6 +2023,7 @@ static int do_i2c(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[]) static char i2c_help_text[] = #if defined(CONFIG_SYS_I2C) || defined(CONFIG_DM_I2C) "bus [muxtype:muxaddr:muxchannel] - show I2C bus info\n" + "i2c " /* That's the prefix for the crc32 command below. */ #endif "crc32 chip address[.0, .1, .2] count - compute CRC32 checksum\n" #if defined(CONFIG_SYS_I2C) || \

On 04.12.2018, at 11:27, Christoph Muellner christoph.muellner@theobroma-systems.com wrote:
In case SYS_I2C or DM_I2C are defined, then the "i2c " prefix of the "i2c crc32" command is missing. This patch addresses this, so that users can't get confused by the "crc32" command.
Without the patch we get
=> i2c help i2c - I2C sub-system
Usage: i2c bus [muxtype:muxaddr:muxchannel] - show I2C bus info crc32 chip address[.0, .1, .2] count - compute CRC32 checksum i2c dev [dev] - show or set current I2C bus [...]
With the patch we get
=> i2c help i2c - I2C sub-system
Usage: i2c bus [muxtype:muxaddr:muxchannel] - show I2C bus info i2c crc32 chip address[.0, .1, .2] count - compute CRC32 checksum i2c dev [dev] - show or set current I2C bus ...
Signed-off-by: Christoph Muellner christoph.muellner@theobroma-systems.com
Reviewed-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com

Hello Christoph,
Am 04.12.2018 um 11:27 schrieb Christoph Muellner:
In case SYS_I2C or DM_I2C are defined, then the "i2c " prefix of the "i2c crc32" command is missing. This patch addresses this, so that users can't get confused by the "crc32" command.
Without the patch we get
=> i2c help i2c - I2C sub-system Usage: i2c bus [muxtype:muxaddr:muxchannel] - show I2C bus info crc32 chip address[.0, .1, .2] count - compute CRC32 checksum i2c dev [dev] - show or set current I2C bus [...]
With the patch we get
=> i2c help i2c - I2C sub-system Usage: i2c bus [muxtype:muxaddr:muxchannel] - show I2C bus info i2c crc32 chip address[.0, .1, .2] count - compute CRC32 checksum i2c dev [dev] - show or set current I2C bus ...
Signed-off-by: Christoph Muellner christoph.muellner@theobroma-systems.com
cmd/i2c.c | 1 + 1 file changed, 1 insertion(+)
Good catch, thanks!
Reviewed-by: Heiko Schocher hs@denx.de
bye, Heiko
participants (3)
-
Christoph Muellner
-
Heiko Schocher
-
Philipp Tomsich