[U-Boot] [PATCH] ls1021a: QSPI: update the node for QSPI support
From: Yuan Yao yao.yuan@nxp.com
Add the address value and size value name for QSPI dts node.
Signed-off-by: Yuan Yao yao.yuan@nxp.com --- arch/arm/dts/ls1021a.dtsi | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/dts/ls1021a.dtsi b/arch/arm/dts/ls1021a.dtsi index 119b1af..37be169 100644 --- a/arch/arm/dts/ls1021a.dtsi +++ b/arch/arm/dts/ls1021a.dtsi @@ -176,6 +176,7 @@ #size-cells = <0>; reg = <0x1550000 0x10000>, <0x40000000 0x4000000>; + reg-names = "QuadSPI", "QuadSPI-memory"; num-cs = <2>; big-endian; status = "disabled";
On 10/10/2016 11:09 PM, Yuan Yao wrote:
From: Yuan Yao yao.yuan@nxp.com
Add the address value and size value name for QSPI dts node.
This message doesn't match the change. Do you call "QuadSPI" the address value name?
Signed-off-by: Yuan Yao yao.yuan@nxp.com
arch/arm/dts/ls1021a.dtsi | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/dts/ls1021a.dtsi b/arch/arm/dts/ls1021a.dtsi index 119b1af..37be169 100644 --- a/arch/arm/dts/ls1021a.dtsi +++ b/arch/arm/dts/ls1021a.dtsi @@ -176,6 +176,7 @@ #size-cells = <0>; reg = <0x1550000 0x10000>, <0x40000000 0x4000000>;
reg-names = "QuadSPI", "QuadSPI-memory"; num-cs = <2>; big-endian; status = "disabled";
On 11/08/2016 02:27 AM, York Sun wrote:
On 10/10/2016 11:09 PM, Yuan Yao wrote:
From: Yuan Yao yao.yuan@nxp.com
Add the address value and size value name for QSPI dts node.
This message doesn't match the change. Do you call "QuadSPI" the address value name?
Yes, I always call QuadSPI as QSPI. Here <0x1550000 0x10000 > is the QSPI register space. <0x40000000 0x4000000> is the QSPI memory space.
So, need I update the QSPI as QuadSPI?
Thanks for your review.
Signed-off-by: Yuan Yao yao.yuan@nxp.com
arch/arm/dts/ls1021a.dtsi | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/dts/ls1021a.dtsi b/arch/arm/dts/ls1021a.dtsi index 119b1af..37be169 100644 --- a/arch/arm/dts/ls1021a.dtsi +++ b/arch/arm/dts/ls1021a.dtsi @@ -176,6 +176,7 @@ #size-cells = <0>; reg = <0x1550000 0x10000>, <0x40000000 0x4000000>;
reg-names = "QuadSPI", "QuadSPI-memory"; num-cs = <2>; big-endian; status = "disabled";
On 11/07/2016 07:58 PM, Yao Yuan wrote:
On 11/08/2016 02:27 AM, York Sun wrote:
On 10/10/2016 11:09 PM, Yuan Yao wrote:
From: Yuan Yao yao.yuan@nxp.com
Add the address value and size value name for QSPI dts node.
This message doesn't match the change. Do you call "QuadSPI" the address value name?
Yes, I always call QuadSPI as QSPI. Here <0x1550000 0x10000 > is the QSPI register space. <0x40000000 0x4000000> is the QSPI memory space.
So, need I update the QSPI as QuadSPI?
You have QSPI register space and memory space. I can understand those. But your commit message says "Add address value and size value name". I can't match which one is which.
York
On 11/08/2016 12:46 PM, York Sun wrote:
On 11/07/2016 07:58 PM, Yao Yuan wrote:
On 11/08/2016 02:27 AM, York Sun wrote:
On 10/10/2016 11:09 PM, Yuan Yao wrote:
From: Yuan Yao yao.yuan@nxp.com
Add the address value and size value name for QSPI dts node.
This message doesn't match the change. Do you call "QuadSPI" the address value name?
Yes, I always call QuadSPI as QSPI. Here <0x1550000 0x10000 > is the QSPI register space. <0x40000000 0x4000000> is the QSPI memory space.
So, need I update the QSPI as QuadSPI?
You have QSPI register space and memory space. I can understand those. But your commit message says "Add address value and size value name". I can't match which one is which.
OK, Get it. I will update the commit message to resend it soon.
participants (3)
-
Yao Yuan -
york sun -
Yuan Yao