[U-Boot] Building fw_env tools seems broken

Hi,
I came across this issue recently, that affects 2014.10 as well as master, but used to work fine in 2014.07 and older. Please let me know if I'm missing something or you need additional info. Thanks!
$ make CROSS_COMPILE=arm-linux-gnueabihf- am335x_evm_defconfig HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf # # configuration written to .config # # # configuration written to spl/.config #
$ make CROSS_COMPILE=arm-linux-gnueabihf- env scripts/kconfig/conf --silentoldconfig Kconfig scripts/kconfig/conf --silentoldconfig Kconfig CHK include/config.h GEN include/autoconf.mk GEN include/autoconf.mk.dep GEN spl/include/autoconf.mk HOSTCC tools/env/fw_env.o In file included from tools/env/fw_env.c:117:0: include/env_default.h:110:11: error: expected ‘}’ before ‘CONFIG_SYS_ARCH’ scripts/Makefile.host:108: recipe for target 'tools/env/fw_env.o' failed make[1]: *** [tools/env/fw_env.o] Error 1 Makefile:1208: recipe for target 'env' failed make: *** [env] Error 2

Ping on this one.
I tried few different defconfigs - the results are mixed, where sandbox and some other machines do work, but some are broken as below. Tried different toolchains as well - gcc-4.7 and 4.9. Any pointers or any help in resolving this issue would be greatly appreciated! Thanks.
On Mon, Nov 24, 2014 at 04:19:17PM -0500, Denys Dmytriyenko wrote:
Hi,
I came across this issue recently, that affects 2014.10 as well as master, but used to work fine in 2014.07 and older. Please let me know if I'm missing something or you need additional info. Thanks!
$ make CROSS_COMPILE=arm-linux-gnueabihf- am335x_evm_defconfig HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf # # configuration written to .config # # # configuration written to spl/.config #
$ make CROSS_COMPILE=arm-linux-gnueabihf- env scripts/kconfig/conf --silentoldconfig Kconfig scripts/kconfig/conf --silentoldconfig Kconfig CHK include/config.h GEN include/autoconf.mk GEN include/autoconf.mk.dep GEN spl/include/autoconf.mk HOSTCC tools/env/fw_env.o In file included from tools/env/fw_env.c:117:0: include/env_default.h:110:11: error: expected ‘}’ before ‘CONFIG_SYS_ARCH’ scripts/Makefile.host:108: recipe for target 'tools/env/fw_env.o' failed make[1]: *** [tools/env/fw_env.o] Error 1 Makefile:1208: recipe for target 'env' failed make: *** [env] Error 2
-- Denys

Hi Denys,
Sorry, I missed your mail.
On Tue, 2 Dec 2014 13:09:11 -0500 Denys Dmytriyenko denys@ti.com wrote:
Ping on this one.
I tried few different defconfigs - the results are mixed, where sandbox and some other machines do work, but some are broken as below. Tried different toolchains as well - gcc-4.7 and 4.9. Any pointers or any help in resolving this issue would be greatly appreciated! Thanks.
The build fails if CONFIG_ENV_VARS_UBOOT_CONFIG is defined.
am335x_evm defines it, whereas sandbox does not.
Could you check if this patch solves your problem? http://patchwork.ozlabs.org/patch/417192/
On Mon, Nov 24, 2014 at 04:19:17PM -0500, Denys Dmytriyenko wrote:
Hi,
I came across this issue recently, that affects 2014.10 as well as master, but used to work fine in 2014.07 and older. Please let me know if I'm missing something or you need additional info. Thanks!
$ make CROSS_COMPILE=arm-linux-gnueabihf- am335x_evm_defconfig HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf # # configuration written to .config # # # configuration written to spl/.config #
$ make CROSS_COMPILE=arm-linux-gnueabihf- env scripts/kconfig/conf --silentoldconfig Kconfig scripts/kconfig/conf --silentoldconfig Kconfig CHK include/config.h GEN include/autoconf.mk GEN include/autoconf.mk.dep GEN spl/include/autoconf.mk HOSTCC tools/env/fw_env.o In file included from tools/env/fw_env.c:117:0: include/env_default.h:110:11: error: expected ‘}’ before ‘CONFIG_SYS_ARCH’ scripts/Makefile.host:108: recipe for target 'tools/env/fw_env.o' failed make[1]: *** [tools/env/fw_env.o] Error 1 Makefile:1208: recipe for target 'env' failed make: *** [env] Error 2
-- Denys
Best Regards Masahiro Yamada

On Wed, Dec 03, 2014 at 10:28:11AM +0900, Masahiro Yamada wrote:
Hi Denys,
Sorry, I missed your mail.
On Tue, 2 Dec 2014 13:09:11 -0500 Denys Dmytriyenko denys@ti.com wrote:
Ping on this one.
I tried few different defconfigs - the results are mixed, where sandbox and some other machines do work, but some are broken as below. Tried different toolchains as well - gcc-4.7 and 4.9. Any pointers or any help in resolving this issue would be greatly appreciated! Thanks.
The build fails if CONFIG_ENV_VARS_UBOOT_CONFIG is defined.
am335x_evm defines it, whereas sandbox does not.
Could you check if this patch solves your problem? http://patchwork.ozlabs.org/patch/417192/
Thanks! The patch works for me and is good enough for my current needs.
Since you don't think this fix is very correct, I hope you'll be able to find the proper fix by the next release. Good luck! :)
On Mon, Nov 24, 2014 at 04:19:17PM -0500, Denys Dmytriyenko wrote:
Hi,
I came across this issue recently, that affects 2014.10 as well as master, but used to work fine in 2014.07 and older. Please let me know if I'm missing something or you need additional info. Thanks!
$ make CROSS_COMPILE=arm-linux-gnueabihf- am335x_evm_defconfig HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf # # configuration written to .config # # # configuration written to spl/.config #
$ make CROSS_COMPILE=arm-linux-gnueabihf- env scripts/kconfig/conf --silentoldconfig Kconfig scripts/kconfig/conf --silentoldconfig Kconfig CHK include/config.h GEN include/autoconf.mk GEN include/autoconf.mk.dep GEN spl/include/autoconf.mk HOSTCC tools/env/fw_env.o In file included from tools/env/fw_env.c:117:0: include/env_default.h:110:11: error: expected ‘}’ before ‘CONFIG_SYS_ARCH’ scripts/Makefile.host:108: recipe for target 'tools/env/fw_env.o' failed make[1]: *** [tools/env/fw_env.o] Error 1 Makefile:1208: recipe for target 'env' failed make: *** [env] Error 2
-- Denys
Best Regards Masahiro Yamada
participants (2)
-
Denys Dmytriyenko
-
Masahiro Yamada