[U-Boot] [PATCH 1/2] dfu:ext4:fix Fix ext4{read|write} command formatting
In the following commit: "dfu: Support larger than memory transfers." SHA1: ea2453d56b8860dbd18a3c517531ffc8dcb5c839
The ext4{read|write} command formatting has been changed. It removed a write mandatory [sizebytes] parameter.
It extents DFU_FS_EXT4 case at mmc_file_op to provide mandatory parameter for DFU write.
Signed-off-by: Lukasz Majewski l.majewski@samsung.com Cc: Tom Rini trini@ti.com Cc: Pantelis Antoniou panto@antoniou-consulting.com Cc: Marek Vasut marex@denx.de Cc: Heiko Schocher hs@denx.de --- drivers/dfu/dfu_mmc.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/dfu/dfu_mmc.c b/drivers/dfu/dfu_mmc.c index e2f3978..e7ee077 100644 --- a/drivers/dfu/dfu_mmc.c +++ b/drivers/dfu/dfu_mmc.c @@ -98,6 +98,8 @@ static int mmc_file_op(enum dfu_mmc_op op, struct dfu_entity *dfu, op == DFU_OP_READ ? "load" : "write", dfu->data.mmc.dev, dfu->data.mmc.part, (unsigned int) buf, dfu->name); + if (op == DFU_OP_WRITE) + sprintf(cmd_buf + strlen(cmd_buf), " %ld", *len); break; default: printf("%s: Layout (%s) not (yet) supported!\n", __func__,
For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].
For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.
Signed-off-by: Lukasz Majewski l.majewski@samsung.com Cc: Tom Rini trini@ti.com Cc: Pantelis Antoniou panto@antoniou-consulting.com Cc: Marek Vasut marex@denx.de Cc: Heiko Schocher hs@denx.de --- drivers/dfu/dfu.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c index e429d74..0521752 100644 --- a/drivers/dfu/dfu.c +++ b/drivers/dfu/dfu.c @@ -248,7 +248,11 @@ int dfu_read(struct dfu_entity *dfu, void *buf, int size, int blk_seq_num) __func__, dfu->name, buf, size, blk_seq_num, dfu->i_buf);
if (!dfu->inited) { - ret = dfu->read_medium(dfu, 0, buf, &dfu->r_left); + dfu->i_buf_start = dfu_get_buf(); + if (dfu->i_buf_start == NULL) + return -ENOMEM; + + ret = dfu->read_medium(dfu, 0, dfu->i_buf_start, &dfu->r_left); if (ret != 0) { debug("%s: failed to get r_left\n", __func__); return ret; @@ -259,9 +263,6 @@ int dfu_read(struct dfu_entity *dfu, void *buf, int size, int blk_seq_num) dfu->i_blk_seq_num = 0; dfu->crc = 0; dfu->offset = 0; - dfu->i_buf_start = dfu_get_buf(); - if (dfu->i_buf_start == NULL) - return -ENOMEM; dfu->i_buf_end = dfu_get_buf() + dfu_buf_size; dfu->i_buf = dfu->i_buf_start; dfu->b_left = 0;
On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski wrote:
For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].
For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.
Signed-off-by: Lukasz Majewski l.majewski@samsung.com Cc: Tom Rini trini@ti.com Cc: Pantelis Antoniou panto@antoniou-consulting.com Cc: Marek Vasut marex@denx.de Cc: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
Dear Tom Rini,
On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski wrote:
For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].
For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.
Signed-off-by: Lukasz Majewski l.majewski@samsung.com Cc: Tom Rini trini@ti.com Cc: Pantelis Antoniou panto@antoniou-consulting.com Cc: Marek Vasut marex@denx.de Cc: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
Tom, why are you picking USB changes now? This is creating quite some mess ...
Best regards, Marek Vasut
On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote:
Dear Tom Rini,
On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski wrote:
For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].
For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.
Signed-off-by: Lukasz Majewski l.majewski@samsung.com Cc: Tom Rini trini@ti.com Cc: Pantelis Antoniou panto@antoniou-consulting.com Cc: Marek Vasut marex@denx.de Cc: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
Tom, why are you picking USB changes now? This is creating quite some mess ...
Just trying to clear up the queue of fixes.
Dear Tom Rini,
On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote:
Dear Tom Rini,
On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski wrote:
For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].
For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.
Signed-off-by: Lukasz Majewski l.majewski@samsung.com Cc: Tom Rini trini@ti.com Cc: Pantelis Antoniou panto@antoniou-consulting.com Cc: Marek Vasut marex@denx.de Cc: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
Tom, why are you picking USB changes now? This is creating quite some mess ...
Just trying to clear up the queue of fixes.
Ok, if you manage to merge it with the USB PR ...
Best regards, Marek Vasut
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 07/05/2013 09:55 AM, Marek Vasut wrote:
Dear Tom Rini,
On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote:
Dear Tom Rini,
On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski wrote:
For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].
For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.
Signed-off-by: Lukasz Majewski l.majewski@samsung.com Cc: Tom Rini trini@ti.com Cc: Pantelis Antoniou panto@antoniou-consulting.com Cc: Marek Vasut marex@denx.de Cc: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
Tom, why are you picking USB changes now? This is creating quite some mess ...
Just trying to clear up the queue of fixes.
Ok, if you manage to merge it with the USB PR ...
Yup, fit right on top. I'll stop being an overarching custodian and let you grab the copyright fix :)
- -- Tom
Dear Tom Rini,
On 07/05/2013 09:55 AM, Marek Vasut wrote:
Dear Tom Rini,
On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote:
Dear Tom Rini,
On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski
wrote:
For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].
For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.
Signed-off-by: Lukasz Majewski l.majewski@samsung.com Cc: Tom Rini trini@ti.com Cc: Pantelis Antoniou panto@antoniou-consulting.com Cc: Marek Vasut marex@denx.de Cc: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
Tom, why are you picking USB changes now? This is creating quite some mess ...
Just trying to clear up the queue of fixes.
Ok, if you manage to merge it with the USB PR ...
Yup, fit right on top. I'll stop being an overarching custodian and let you grab the copyright fix :)
I see discussion , not patch. Link?
Best regards, Marek Vasut
On Fri, 05 Jul 2013 16:32:03 +0200, Marek Vasut wrote:
Hi,
Dear Tom Rini,
On 07/05/2013 09:55 AM, Marek Vasut wrote:
Dear Tom Rini,
On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote:
Dear Tom Rini,
On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski
wrote: > For the first eMMC read of data for upload, use the "large" > dfu_buf (now configurable) instead of usb request buffer > allocated at composite layer (which is 4KiB) [*]. > > For eMMC the whole file is read, which usually is larger > than the buffer [*] provided with usb request. > > Signed-off-by: Lukasz Majewski l.majewski@samsung.com Cc: > Tom Rini trini@ti.com Cc: Pantelis Antoniou > panto@antoniou-consulting.com Cc: Marek Vasut > marex@denx.de Cc: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
Tom, why are you picking USB changes now? This is creating quite some mess ...
Just trying to clear up the queue of fixes.
Ok, if you manage to merge it with the USB PR ...
Yup, fit right on top. I'll stop being an overarching custodian and let you grab the copyright fix :)
I see discussion , not patch. Link?
Here you are: http://patchwork.ozlabs.org/patch/257068/
:-)
Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
HI All, May i know how DFU upload functionality resolved as still i am facing problem, when i tried to upload binaries from dfu devices it copied only 4kb images and shoes upload done.
Please give me pointer to solution of this problem
Regards ~Sumit Gemini
On Fri, Jul 5, 2013 at 8:55 PM, Lukasz Majewski l.majewski@samsung.comwrote:
On Fri, 05 Jul 2013 16:32:03 +0200, Marek Vasut wrote:
Hi,
Dear Tom Rini,
On 07/05/2013 09:55 AM, Marek Vasut wrote:
Dear Tom Rini,
On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote:
Dear Tom Rini,
> On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski > > wrote: >> For the first eMMC read of data for upload, use the "large" >> dfu_buf (now configurable) instead of usb request buffer >> allocated at composite layer (which is 4KiB) [*]. >> >> For eMMC the whole file is read, which usually is larger >> than the buffer [*] provided with usb request. >> >> Signed-off-by: Lukasz Majewski l.majewski@samsung.com Cc: >> Tom Rini trini@ti.com Cc: Pantelis Antoniou >> panto@antoniou-consulting.com Cc: Marek Vasut >> marex@denx.de Cc: Heiko Schocher hs@denx.de > > Applied to u-boot/master, thanks!
Tom, why are you picking USB changes now? This is creating quite some mess ...
Just trying to clear up the queue of fixes.
Ok, if you manage to merge it with the USB PR ...
Yup, fit right on top. I'll stop being an overarching custodian and let you grab the copyright fix :)
I see discussion , not patch. Link?
Here you are: http://patchwork.ozlabs.org/patch/257068/
:-)
Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
-- Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
On Sun, 07 Jul 2013 12:13:48 +0530, Sumit Gemini wrote:
Hi Sumit,
HI All, May i know how DFU upload functionality resolved as still i am facing problem, when i tried to upload binaries from dfu devices it copied only 4kb images and shoes upload done.
From what medium do you copy? Is that NAND or eMMC device.
Have you applied all fixes related to DFU (which were posted recently)? One interesting change it the "configurable" buffer, which might be defined from envs.
Please give me pointer to solution of this problem
Regards ~Sumit Gemini
On Fri, Jul 5, 2013 at 8:55 PM, Lukasz Majewski l.majewski@samsung.comwrote:
On Fri, 05 Jul 2013 16:32:03 +0200, Marek Vasut wrote:
Hi,
Dear Tom Rini,
On 07/05/2013 09:55 AM, Marek Vasut wrote:
Dear Tom Rini,
On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote: > Dear Tom Rini, > >> On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski >> >> wrote: >>> For the first eMMC read of data for upload, use the >>> "large" dfu_buf (now configurable) instead of usb request >>> buffer allocated at composite layer (which is 4KiB) [*]. >>> >>> For eMMC the whole file is read, which usually is larger >>> than the buffer [*] provided with usb request. >>> >>> Signed-off-by: Lukasz Majewski l.majewski@samsung.com >>> Cc: Tom Rini trini@ti.com Cc: Pantelis Antoniou >>> panto@antoniou-consulting.com Cc: Marek Vasut >>> marex@denx.de Cc: Heiko Schocher hs@denx.de >> >> Applied to u-boot/master, thanks! > > Tom, why are you picking USB changes now? This is creating > quite some mess ...
Just trying to clear up the queue of fixes.
Ok, if you manage to merge it with the USB PR ...
Yup, fit right on top. I'll stop being an overarching custodian and let you grab the copyright fix :)
I see discussion , not patch. Link?
Here you are: http://patchwork.ozlabs.org/patch/257068/
:-)
Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
-- Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
HI Lukasz,
I am using spi nor flash, and may i know the fixes which you fixed, and all changes. because i am facing problem only in upload.
Please help me in this issue.
Thanks ~Sumit
On Mon, Jul 8, 2013 at 11:52 AM, Lukasz Majewski l.majewski@samsung.comwrote:
On Sun, 07 Jul 2013 12:13:48 +0530, Sumit Gemini wrote:
Hi Sumit,
HI All, May i know how DFU upload functionality resolved as still i am facing problem, when i tried to upload binaries from dfu devices it copied only 4kb images and shoes upload done.
From what medium do you copy? Is that NAND or eMMC device.
Have you applied all fixes related to DFU (which were posted recently)? One interesting change it the "configurable" buffer, which might be defined from envs.
Please give me pointer to solution of this problem
Regards ~Sumit Gemini
On Fri, Jul 5, 2013 at 8:55 PM, Lukasz Majewski l.majewski@samsung.comwrote:
On Fri, 05 Jul 2013 16:32:03 +0200, Marek Vasut wrote:
Hi,
Dear Tom Rini,
On 07/05/2013 09:55 AM, Marek Vasut wrote:
Dear Tom Rini,
> On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote: >> Dear Tom Rini, >> >>> On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski >>> >>> wrote: >>>> For the first eMMC read of data for upload, use the >>>> "large" dfu_buf (now configurable) instead of usb request >>>> buffer allocated at composite layer (which is 4KiB) [*]. >>>> >>>> For eMMC the whole file is read, which usually is larger >>>> than the buffer [*] provided with usb request. >>>> >>>> Signed-off-by: Lukasz Majewski l.majewski@samsung.com >>>> Cc: Tom Rini trini@ti.com Cc: Pantelis Antoniou >>>> panto@antoniou-consulting.com Cc: Marek Vasut >>>> marex@denx.de Cc: Heiko Schocher hs@denx.de >>> >>> Applied to u-boot/master, thanks! >> >> Tom, why are you picking USB changes now? This is creating >> quite some mess ... > > Just trying to clear up the queue of fixes.
Ok, if you manage to merge it with the USB PR ...
Yup, fit right on top. I'll stop being an overarching custodian and let you grab the copyright fix :)
I see discussion , not patch. Link?
Here you are: http://patchwork.ozlabs.org/patch/257068/
:-)
Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
-- Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
-- Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 07/08/2013 04:59 AM, Sumit Gemini wrote:
HI Lukasz,
I am using spi nor flash, and may i know the fixes which you fixed, and all changes. because i am facing problem only in upload.
This means you are not using mainline, as we do not have DFU for SPI. Please post it, or hassle your vendor (I suspect I know who it is) to get the patches posted. Thanks!
- -- Tom
On Fri, Jun 28, 2013 at 06:41:49PM +0200, ??ukasz Majewski wrote:
In the following commit: "dfu: Support larger than memory transfers." SHA1: ea2453d56b8860dbd18a3c517531ffc8dcb5c839
The ext4{read|write} command formatting has been changed. It removed a write mandatory [sizebytes] parameter.
It extents DFU_FS_EXT4 case at mmc_file_op to provide mandatory parameter for DFU write.
Signed-off-by: Lukasz Majewski l.majewski@samsung.com Cc: Tom Rini trini@ti.com Cc: Pantelis Antoniou panto@antoniou-consulting.com Cc: Marek Vasut marex@denx.de Cc: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
participants (4)
-
Lukasz Majewski -
Marek Vasut -
Sumit Gemini -
Tom Rini