Re: [U-Boot] [PATCH] drivers: net: fsl-mc: Fixup MAC addresses in DPC
-----Original Message----- From: Bogdan Purcareata [mailto:bogdan.purcareata@nxp.com] Sent: Thursday, January 11, 2017 9:35 AM To: u-boot@lists.denx.de Cc: Bogdan Purcareata bogdan.purcareata@nxp.com Subject: [PATCH] drivers: net: fsl-mc: Fixup MAC addresses in DPC
Fixup port_mac_address property in MC DPC with values from the u-boot environment. Since u-boot already reads the environment MAC addresses when probing the PHYs, use these values.
The u-boot environment MAC addresses take precedence over any eventual ones defined in the DPC, except for the case where they are randomly assigned (no u-boot env value declared for port).
The patch assumes the "/board_info/ports/" node is present in the DPC.
Signed-off-by: Bogdan Purcareata bogdan.purcareata@nxp.com
Reviewed-by: Prabhakar Kushwaha prabhakar.kushwaha@nxp.com
On 01/26/2017 05:05 AM, Prabhakar Kushwaha wrote:
-----Original Message----- From: Bogdan Purcareata [mailto:bogdan.purcareata@nxp.com] Sent: Thursday, January 11, 2017 9:35 AM To: u-boot@lists.denx.de Cc: Bogdan Purcareata bogdan.purcareata@nxp.com Subject: [PATCH] drivers: net: fsl-mc: Fixup MAC addresses in DPC
Fixup port_mac_address property in MC DPC with values from the u-boot environment. Since u-boot already reads the environment MAC addresses when probing the PHYs, use these values.
The u-boot environment MAC addresses take precedence over any eventual ones defined in the DPC, except for the case where they are randomly assigned (no u-boot env value declared for port).
The patch assumes the "/board_info/ports/" node is present in the DPC.
Signed-off-by: Bogdan Purcareata bogdan.purcareata@nxp.com
Reviewed-by: Prabhakar Kushwaha prabhakar.kushwaha@nxp.com
Prabhakar,
I don't know how you replied with your comment. But your email client changed the message ID so patchwork couldn't match it.
York
Hi York,
-----Original Message----- From: york sun Sent: Saturday, January 28, 2017 2:15 AM To: Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; Bogdan Purcareata bogdan.purcareata@nxp.com; u-boot@lists.denx.de Subject: Re: [PATCH] drivers: net: fsl-mc: Fixup MAC addresses in DPC
On 01/26/2017 05:05 AM, Prabhakar Kushwaha wrote:
-----Original Message----- From: Bogdan Purcareata [mailto:bogdan.purcareata@nxp.com] Sent: Thursday, January 11, 2017 9:35 AM To: u-boot@lists.denx.de Cc: Bogdan Purcareata bogdan.purcareata@nxp.com Subject: [PATCH] drivers: net: fsl-mc: Fixup MAC addresses in DPC
Fixup port_mac_address property in MC DPC with values from the u-boot environment. Since u-boot already reads the environment MAC addresses when probing the PHYs, use these values.
The u-boot environment MAC addresses take precedence over any eventual ones defined in the DPC, except for the case where they are randomly assigned (no u-boot env value declared for port).
The patch assumes the "/board_info/ports/" node is present in the DPC.
Signed-off-by: Bogdan Purcareata bogdan.purcareata@nxp.com
Reviewed-by: Prabhakar Kushwaha prabhakar.kushwaha@nxp.com
Prabhakar,
I don't know how you replied with your comment. But your email client changed the message ID so patchwork couldn't match it.
Oh.. Looks like I did some mistake...
Will it be possible to provide original message/mail which was sent on the mailing list so that I can provide "review-by" again
--prabhakar
On 01/30/2017 03:09 AM, Prabhakar Kushwaha wrote:
Hi York,
-----Original Message----- From: york sun Sent: Saturday, January 28, 2017 2:15 AM To: Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; Bogdan Purcareata bogdan.purcareata@nxp.com; u-boot@lists.denx.de Subject: Re: [PATCH] drivers: net: fsl-mc: Fixup MAC addresses in DPC
On 01/26/2017 05:05 AM, Prabhakar Kushwaha wrote:
-----Original Message----- From: Bogdan Purcareata [mailto:bogdan.purcareata@nxp.com] Sent: Thursday, January 11, 2017 9:35 AM To: u-boot@lists.denx.de Cc: Bogdan Purcareata bogdan.purcareata@nxp.com Subject: [PATCH] drivers: net: fsl-mc: Fixup MAC addresses in DPC
Fixup port_mac_address property in MC DPC with values from the u-boot environment. Since u-boot already reads the environment MAC addresses when probing the PHYs, use these values.
The u-boot environment MAC addresses take precedence over any eventual ones defined in the DPC, except for the case where they are randomly assigned (no u-boot env value declared for port).
The patch assumes the "/board_info/ports/" node is present in the DPC.
Signed-off-by: Bogdan Purcareata bogdan.purcareata@nxp.com
Reviewed-by: Prabhakar Kushwaha prabhakar.kushwaha@nxp.com
Prabhakar,
I don't know how you replied with your comment. But your email client changed the message ID so patchwork couldn't match it.
Oh.. Looks like I did some mistake...
Will it be possible to provide original message/mail which was sent on the mailing list so that I can provide "review-by" again
--prabhakar
I will manually add your review signature when merging this one. Just curious how it was messed up.
York
participants (2)
-
Prabhakar Kushwaha -
york sun