Re: [PATCH 17/18] riscv: qemu: Remove out-of-date "riscv, kernel-start" handling
From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Bin Meng Sent: Sunday, July 23, 2023 12:41 PM To: Simon Glass sjg@chromium.org; u-boot@lists.denx.de Cc: Bin Meng bmeng.cn@gmail.com Subject: [PATCH 17/18] riscv: qemu: Remove out-of-date "riscv, kernel-start" handling
Commit 66ffe57 ("riscv: qemu: detect and boot the kernel passed by QEMU") added some logic to handle "riscv,kernel-start" in DT and stored the address to an environment variable kernel_start.
However this "riscv,kernel-start" has never been an upstream DT binding. The upstream QEMU never generates such a DT either. Presumably U-Boot development was based on a downstream QEMU fork.
Now we drop all codes in commit 66ffe57, except that BOARD_LATE_INIT is kept for later use.
Signed-off-by: Bin Meng bmeng@tinylab.org
board/emulation/qemu-riscv/qemu-riscv.c | 24 ------------------------ include/configs/qemu-riscv.h | 10 ---------- 2 files changed, 34 deletions(-)
Reviewed-by: Rick Chen rick@andestech.com
On Tue, 25 Jul 2023 at 01:17, Rick Chen rickchen36@gmail.com wrote:
From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Bin Meng Sent: Sunday, July 23, 2023 12:41 PM To: Simon Glass sjg@chromium.org; u-boot@lists.denx.de Cc: Bin Meng bmeng.cn@gmail.com Subject: [PATCH 17/18] riscv: qemu: Remove out-of-date "riscv, kernel-start" handling
Commit 66ffe57 ("riscv: qemu: detect and boot the kernel passed by QEMU") added some logic to handle "riscv,kernel-start" in DT and stored the address to an environment variable kernel_start.
However this "riscv,kernel-start" has never been an upstream DT binding. The upstream QEMU never generates such a DT either. Presumably U-Boot development was based on a downstream QEMU fork.
Now we drop all codes in commit 66ffe57, except that BOARD_LATE_INIT is kept for later use.
Signed-off-by: Bin Meng bmeng@tinylab.org
board/emulation/qemu-riscv/qemu-riscv.c | 24 ------------------------ include/configs/qemu-riscv.h | 10 ---------- 2 files changed, 34 deletions(-)
Reviewed-by: Rick Chen rick@andestech.com
Reviewed-by: Simon Glass sjg@chromium.org
participants (2)
-
Rick Chen -
Simon Glass