[U-Boot] [PATCH v2] spl: Change debug to printf for "Unsupported boot-device"
We had the problem on an AM33xx platform, that SPL detected an unsupported boot-device. But since this message is a debug message it took a bit of time to really know, where the hangup in SPL resulted from. So let's change this debug message to a printf and also print the detected boot-device that is not supported. This makes debugging of such cases much easier.
Signed-off-by: Stefan Roese sr@denx.de Cc: Wolfgang Denk wd@denx.de Cc: Tom Rini trini@ti.com --- v2: - Added #if check so that the printf is only included when serial support is enabled. - Compile tested on all ARM boards
common/spl/spl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/common/spl/spl.c b/common/spl/spl.c index d85bab3..cef7bca 100644 --- a/common/spl/spl.c +++ b/common/spl/spl.c @@ -216,7 +216,9 @@ void board_init_r(gd_t *dummy1, ulong dummy2) break; #endif default: - debug("SPL: Un-supported Boot Device\n"); +#if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT) + printf("SPL: Unsupported Boot Device %d\n", boot_device); +#endif hang(); }
Hello Stefan,
Am 11.11.2014 19:03, schrieb Stefan Roese:
We had the problem on an AM33xx platform, that SPL detected an unsupported boot-device. But since this message is a debug message it took a bit of time to really know, where the hangup in SPL resulted from. So let's change this debug message to a printf and also print the detected boot-device that is not supported. This makes debugging of such cases much easier.
Signed-off-by: Stefan Roese sr@denx.de Cc: Wolfgang Denk wd@denx.de Cc: Tom Rini trini@ti.com
v2:
Added #if check so that the printf is only included when serial support is enabled.
Compile tested on all ARM boards
common/spl/spl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Yes, I think this is a good idea, as I stepped also in the same problem. I tend to first activate debug when I have not working SPL code ... but this is not possible for example on running systems ... on the other side, this problem should raise only in the development state ...
The same for other places ... like UBI ... see my question [1]. It would be nice to have this ubi errormessages enabled, but this cost a lot of space ...
But for this patch, I think it is okay to enable it by default ... so:
Acked-by: Heiko Schocher hs@denx.de
bye, Heiko
[1] [U-Boot] mtd, ubi: errormessage handling https://patchwork.ozlabs.org/patch/405259/
diff --git a/common/spl/spl.c b/common/spl/spl.c index d85bab3..cef7bca 100644 --- a/common/spl/spl.c +++ b/common/spl/spl.c @@ -216,7 +216,9 @@ void board_init_r(gd_t *dummy1, ulong dummy2) break; #endif default:
debug("SPL: Un-supported Boot Device\n");+#if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
printf("SPL: Unsupported Boot Device %d\n", boot_device);+#endif hang(); }
On Tue, Nov 11, 2014 at 07:03:55PM +0100, Stefan Roese wrote:
We had the problem on an AM33xx platform, that SPL detected an unsupported boot-device. But since this message is a debug message it took a bit of time to really know, where the hangup in SPL resulted from. So let's change this debug message to a printf and also print the detected boot-device that is not supported. This makes debugging of such cases much easier.
Signed-off-by: Stefan Roese sr@denx.de Cc: Wolfgang Denk wd@denx.de Cc: Tom Rini trini@ti.com Acked-by: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
Hi guys,
2014-11-24 23:10 GMT+01:00 Tom Rini trini@ti.com:
On Tue, Nov 11, 2014 at 07:03:55PM +0100, Stefan Roese wrote:
We had the problem on an AM33xx platform, that SPL detected an unsupported boot-device. But since this message is a debug message it took a bit of time to really know, where the hangup in SPL resulted from. So let's change this debug message to a printf and also print the detected boot-device that is not supported. This makes debugging of such cases much easier.
Signed-off-by: Stefan Roese sr@denx.de Cc: Wolfgang Denk wd@denx.de Cc: Tom Rini trini@ti.com Acked-by: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
This patch is causing problem on Microblaze because SPL exceed 4k limit. It is only one printf which is called in entire SPL that's why this should be solved a little bit differently.
Thanks, Michal
Hi Michal,
On 27.01.2015 14:43, Michal Simek wrote:
On Tue, Nov 11, 2014 at 07:03:55PM +0100, Stefan Roese wrote: > We had the problem on an AM33xx platform, that SPL detected an > unsupported boot-device. But since this message is a debug message > it took a bit of time to really know, where the hangup in SPL > resulted from. So let's change this debug message to a printf > and also print the detected boot-device that is not supported. > This makes debugging of such cases much easier. > > Signed-off-by: Stefan Roese <sr@denx.de <mailto:sr@denx.de>> > Cc: Wolfgang Denk <wd@denx.de <mailto:wd@denx.de>> > Cc: Tom Rini <trini@ti.com <mailto:trini@ti.com>> > Acked-by: Heiko Schocher <hs@denx.de <mailto:hs@denx.de>> Applied to u-boot/master, thanks!This patch is causing problem on Microblaze because SPL exceed 4k limit. It is only one printf which is called in entire SPL that's why this should be solved a little bit differently.
Ups. Yes, sorry. This one line definitely shouldn't cause all the printf stuff to be included. I'll try to address this quickly...
Thanks, Stefan
On Tue, Jan 27, 2015 at 02:43:57PM +0100, Michal Simek wrote:
Hi guys,
2014-11-24 23:10 GMT+01:00 Tom Rini trini@ti.com:
On Tue, Nov 11, 2014 at 07:03:55PM +0100, Stefan Roese wrote:
We had the problem on an AM33xx platform, that SPL detected an unsupported boot-device. But since this message is a debug message it took a bit of time to really know, where the hangup in SPL resulted from. So let's change this debug message to a printf and also print the detected boot-device that is not supported. This makes debugging of such cases much easier.
Signed-off-by: Stefan Roese sr@denx.de Cc: Wolfgang Denk wd@denx.de Cc: Tom Rini trini@ti.com Acked-by: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
This patch is causing problem on Microblaze because SPL exceed 4k limit. It is only one printf which is called in entire SPL that's why this should be solved a little bit differently.
OK, but for clarity you need and are using both CONFIG_SPL_SERIAL_SUPPORT and CONFIG_SPL_LIBCOMMON_SUPPORT because you're using puts but not printf, yes?
On 27.01.2015 15:22, Tom Rini wrote:
We had the problem on an AM33xx platform, that SPL detected an unsupported boot-device. But since this message is a debug message it took a bit of time to really know, where the hangup in SPL resulted from. So let's change this debug message to a printf and also print the detected boot-device that is not supported. This makes debugging of such cases much easier.
Signed-off-by: Stefan Roese sr@denx.de Cc: Wolfgang Denk wd@denx.de Cc: Tom Rini trini@ti.com Acked-by: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
This patch is causing problem on Microblaze because SPL exceed 4k limit. It is only one printf which is called in entire SPL that's why this should be solved a little bit differently.
OK, but for clarity you need and are using both CONFIG_SPL_SERIAL_SUPPORT and CONFIG_SPL_LIBCOMMON_SUPPORT because you're using puts but not printf, yes?
Right. If this is the case (only puts usage on Microblaze), then its perhaps best that I change this line to puts as well. Okay?
Thanks, Stefan
2015-01-27 15:38 GMT+01:00 Stefan Roese sr@denx.de:
On 27.01.2015 15:22, Tom Rini wrote:
We had the problem on an AM33xx platform, that SPL detected an
unsupported boot-device. But since this message is a debug message it took a bit of time to really know, where the hangup in SPL resulted from. So let's change this debug message to a printf and also print the detected boot-device that is not supported. This makes debugging of such cases much easier.
Signed-off-by: Stefan Roese sr@denx.de Cc: Wolfgang Denk wd@denx.de Cc: Tom Rini trini@ti.com Acked-by: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
This patch is causing problem on Microblaze because SPL exceed 4k
limit. It is only one printf which is called in entire SPL that's why this should be solved a little bit differently.
OK, but for clarity you need and are using both CONFIG_SPL_SERIAL_SUPPORT and CONFIG_SPL_LIBCOMMON_SUPPORT because you're using puts but not printf, yes?
Right. If this is the case (only puts usage on Microblaze), then its perhaps best that I change this line to puts as well. Okay?
Changing this to puts is definitely fine. Microblaze is using just puts.
Thanks, Michal
participants (4)
-
Heiko Schocher -
Michal Simek -
Stefan Roese -
Tom Rini