[PATCH v2 1/2] board: samsung: fix menu entries for a{3,7}y17lte
a7y17lte is called SM-A720F, and a3y17lte SM-A320F. a3y17lte also should select PINCTRL_EXYNOS78x0, not the (non-existent) PINCTRL_EXYNOS7880, and it has an Exynos 7870 SoC and not 7880.
Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series of 2017 (a5y17lte)") Signed-off-by: Henrik Grimler henrik@grimler.se Reviewed-by: Dzmitry Sankouski dsankouski@gmail.com --- Changes since v1: none, added Dzmitry's reviewed-by tag. --- arch/arm/mach-exynos/Kconfig | 6 +++--- board/samsung/axy17lte/Kconfig | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index 7f3aee571290..32b81728c389 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -161,7 +161,7 @@ config TARGET_A5Y17LTE select SUPPORT_SPL
config TARGET_A7Y17LTE - bool "Samsung SM-A520F board" + bool "Samsung SM-A720F board" select ARM64 select CLK_EXYNOS select OF_CONTROL @@ -170,12 +170,12 @@ config TARGET_A7Y17LTE select SUPPORT_SPL
config TARGET_A3Y17LTE - bool "Samsung SM-A520F board" + bool "Samsung SM-A320F board" select ARM64 select CLK_EXYNOS select OF_CONTROL select PINCTRL - select PINCTRL_EXYNOS7880 + select PINCTRL_EXYNOS78x0 select SUPPORT_SPL
endchoice diff --git a/board/samsung/axy17lte/Kconfig b/board/samsung/axy17lte/Kconfig index 2abf8e7acfca..a018547ff5d4 100644 --- a/board/samsung/axy17lte/Kconfig +++ b/board/samsung/axy17lte/Kconfig @@ -27,7 +27,7 @@ if TARGET_A7Y17LTE config SYS_BOARD default "axy17lte" help - a5y17lte is a production board for SM-A520F phone on Exynos7880 SoC. + a7y17lte is a production board for SM-A720F phone on Exynos7880 SoC.
config SYS_VENDOR default "samsung" @@ -44,7 +44,7 @@ if TARGET_A3Y17LTE config SYS_BOARD default "axy17lte" help - a3y17lte is a production board for SM-A520F phone on Exynos7880 SoC. + a3y17lte is a production board for SM-A320F phone on Exynos7870 SoC.
config SYS_VENDOR default "samsung"
base-commit: a14af7216a220fe8f1b2a5308ed632abe6f9f97f
Model names are SM-A{3,5,7}20, just SM-{3,5,7}20 could also refer to SM-J{3,5,7}20 or SM-T{3,5,7}20.
Also fix a5y17lte->a7y17lte for SM-A720.
Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series of 2017 (a5y17lte)") Signed-off-by: Henrik Grimler henrik@grimler.se Reviewed-by: Dzmitry Sankouski dsankouski@gmail.com --- Changes since v1: fix a5y17lte->a7y17lte, pointed out by Dzmitry, and add reviewed-by tag. --- doc/board/samsung/axy17lte.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/board/samsung/axy17lte.rst b/doc/board/samsung/axy17lte.rst index 511cd57a22f5..b13a19af8a35 100644 --- a/doc/board/samsung/axy17lte.rst +++ b/doc/board/samsung/axy17lte.rst @@ -14,7 +14,7 @@ It is loaded as an Android boot image through SBOOT.
Phone specs ----------- -A3 (SM-320) (a3y17lte) +A3 (SM-A320) (a3y17lte) ^^^^^^^^^^^^^^^^^^^^^^ - 4.7 AMOLED display - Exynos 7870 SoC @@ -23,7 +23,7 @@ A3 (SM-320) (a3y17lte)
.. A3 2017 wiki page: https://en.wikipedia.org/wiki/Samsung_Galaxy_A3_(2017)
-A5 (SM-520) (a5y17lte) +A5 (SM-A520) (a5y17lte) ^^^^^^^^^^^^^^^^^^^^^^ - 5.2 AMOLED display - Exynos 7880 SoC @@ -32,7 +32,7 @@ A5 (SM-520) (a5y17lte)
.. A5 2017 wiki page: https://en.wikipedia.org/wiki/Samsung_Galaxy_A5_(2017)
-A7 (SM-720) (a5y17lte) +A7 (SM-A720) (a7y17lte) ^^^^^^^^^^^^^^^^^^^^^^ - 5.7 AMOLED display - Exynos 7880 SoC
On 1/12/22 3:06 AM, Henrik Grimler wrote:
Model names are SM-A{3,5,7}20, just SM-{3,5,7}20 could also refer to SM-J{3,5,7}20 or SM-T{3,5,7}20.
Also fix a5y17lte->a7y17lte for SM-A720.
Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series of 2017 (a5y17lte)") Signed-off-by: Henrik Grimler henrik@grimler.se Reviewed-by: Dzmitry Sankouski dsankouski@gmail.com
Reviewed-by: Jaehoon Chung jh80.chung@samsung.com
Best Regards, Jaehoon Chung
Changes since v1: fix a5y17lte->a7y17lte, pointed out by Dzmitry, and add reviewed-by tag.
doc/board/samsung/axy17lte.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/board/samsung/axy17lte.rst b/doc/board/samsung/axy17lte.rst index 511cd57a22f5..b13a19af8a35 100644 --- a/doc/board/samsung/axy17lte.rst +++ b/doc/board/samsung/axy17lte.rst @@ -14,7 +14,7 @@ It is loaded as an Android boot image through SBOOT.
Phone specs
-A3 (SM-320) (a3y17lte) +A3 (SM-A320) (a3y17lte) ^^^^^^^^^^^^^^^^^^^^^^
- 4.7 AMOLED display
- Exynos 7870 SoC
@@ -23,7 +23,7 @@ A3 (SM-320) (a3y17lte)
.. A3 2017 wiki page: https://en.wikipedia.org/wiki/Samsung_Galaxy_A3_(2017)
-A5 (SM-520) (a5y17lte) +A5 (SM-A520) (a5y17lte) ^^^^^^^^^^^^^^^^^^^^^^
- 5.2 AMOLED display
- Exynos 7880 SoC
@@ -32,7 +32,7 @@ A5 (SM-520) (a5y17lte)
.. A5 2017 wiki page: https://en.wikipedia.org/wiki/Samsung_Galaxy_A5_(2017)
-A7 (SM-720) (a5y17lte) +A7 (SM-A720) (a7y17lte) ^^^^^^^^^^^^^^^^^^^^^^
- 5.7 AMOLED display
- Exynos 7880 SoC
Dear Henrik Grmler,
On Wed, 12 Jan 2022 at 08:07, Jaehoon Chung jh80.chung@samsung.com wrote:
On 1/12/22 3:06 AM, Henrik Grimler wrote:
Model names are SM-A{3,5,7}20, just SM-{3,5,7}20 could also refer to SM-J{3,5,7}20 or SM-T{3,5,7}20.
Also fix a5y17lte->a7y17lte for SM-A720.
Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series of 2017 (a5y17lte)") Signed-off-by: Henrik Grimler henrik@grimler.se Reviewed-by: Dzmitry Sankouski dsankouski@gmail.com
Reviewed-by: Jaehoon Chung jh80.chung@samsung.com
Best Regards, Jaehoon Chung
applied to u-boot-samsung.
On 1/12/22 3:06 AM, Henrik Grimler wrote:
a7y17lte is called SM-A720F, and a3y17lte SM-A320F. a3y17lte also should select PINCTRL_EXYNOS78x0, not the (non-existent) PINCTRL_EXYNOS7880, and it has an Exynos 7870 SoC and not 7880.
Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series of 2017 (a5y17lte)") Signed-off-by: Henrik Grimler henrik@grimler.se Reviewed-by: Dzmitry Sankouski dsankouski@gmail.com
Reviewed-by: Jaehoon Chung jh80.chung@samsung.com
Best Regards, Jaehoon Chung
Changes since v1: none, added Dzmitry's reviewed-by tag.
arch/arm/mach-exynos/Kconfig | 6 +++--- board/samsung/axy17lte/Kconfig | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index 7f3aee571290..32b81728c389 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -161,7 +161,7 @@ config TARGET_A5Y17LTE select SUPPORT_SPL
config TARGET_A7Y17LTE
- bool "Samsung SM-A520F board"
- bool "Samsung SM-A720F board" select ARM64 select CLK_EXYNOS select OF_CONTROL
@@ -170,12 +170,12 @@ config TARGET_A7Y17LTE select SUPPORT_SPL
config TARGET_A3Y17LTE
- bool "Samsung SM-A520F board"
- bool "Samsung SM-A320F board" select ARM64 select CLK_EXYNOS select OF_CONTROL select PINCTRL
- select PINCTRL_EXYNOS7880
- select PINCTRL_EXYNOS78x0 select SUPPORT_SPL
endchoice diff --git a/board/samsung/axy17lte/Kconfig b/board/samsung/axy17lte/Kconfig index 2abf8e7acfca..a018547ff5d4 100644 --- a/board/samsung/axy17lte/Kconfig +++ b/board/samsung/axy17lte/Kconfig @@ -27,7 +27,7 @@ if TARGET_A7Y17LTE config SYS_BOARD default "axy17lte" help
a5y17lte is a production board for SM-A520F phone on Exynos7880 SoC.
a7y17lte is a production board for SM-A720F phone on Exynos7880 SoC.config SYS_VENDOR default "samsung" @@ -44,7 +44,7 @@ if TARGET_A3Y17LTE config SYS_BOARD default "axy17lte" help
a3y17lte is a production board for SM-A520F phone on Exynos7880 SoC.
a3y17lte is a production board for SM-A320F phone on Exynos7870 SoC.config SYS_VENDOR default "samsung"
base-commit: a14af7216a220fe8f1b2a5308ed632abe6f9f97f
Dear Henrik Grimler
On Wed, 12 Jan 2022 at 08:06, Jaehoon Chung jh80.chung@samsung.com wrote:
On 1/12/22 3:06 AM, Henrik Grimler wrote:
a7y17lte is called SM-A720F, and a3y17lte SM-A320F. a3y17lte also should select PINCTRL_EXYNOS78x0, not the (non-existent) PINCTRL_EXYNOS7880, and it has an Exynos 7870 SoC and not 7880.
Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series of 2017 (a5y17lte)") Signed-off-by: Henrik Grimler henrik@grimler.se Reviewed-by: Dzmitry Sankouski dsankouski@gmail.com
Reviewed-by: Jaehoon Chung jh80.chung@samsung.com
Best Regards, Jaehoon Chung
Changes since v1: none, added Dzmitry's reviewed-by tag.
arch/arm/mach-exynos/Kconfig | 6 +++--- board/samsung/axy17lte/Kconfig | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-)
applied to u-boot-samsung.
participants (3)
-
Henrik Grimler -
Jaehoon Chung -
Minkyu Kang