[PATCH 0/1] cmd: change the return value when argc error
When the number of parameters is wrong, the return value should be processed in the same way as other cmds, return CMD_RET_USAGE so that it can print the information.
Shenlin Liang (1): cmd: change the return value when arguments missing
cmd/mvebu/comphy_rx_training.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
When the number of parameters is wrong, the return value should be processed in the same way as other cmds, return CMD_RET_USAGE so that it can print the information.
Signed-off-by: Shenlin Liang liangshenlin@eswincomputing.com --- cmd/mvebu/comphy_rx_training.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/mvebu/comphy_rx_training.c b/cmd/mvebu/comphy_rx_training.c index 25a9e153de..4ee8f54ea9 100644 --- a/cmd/mvebu/comphy_rx_training.c +++ b/cmd/mvebu/comphy_rx_training.c @@ -22,7 +22,7 @@ int mvebu_comphy_rx_training_cmd(struct cmd_tbl *cmdtp, int flag, int argc,
if (argc != 3) { printf("missing arguments\n"); - return -1; + return CMD_RET_USAGE; }
cp_index = hextoul(argv[1], NULL);
On Sat, 10 Dec 2022 at 01:50, Shenlin Liang liangshenlin@eswincomputing.com wrote:
When the number of parameters is wrong, the return value should be processed in the same way as other cmds, return CMD_RET_USAGE so that it can print the information.
Signed-off-by: Shenlin Liang liangshenlin@eswincomputing.com
cmd/mvebu/comphy_rx_training.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
On Fri, Dec 09, 2022 at 05:17:43PM +0800, Shenlin Liang wrote:
When the number of parameters is wrong, the return value should be processed in the same way as other cmds, return CMD_RET_USAGE so that it can print the information.
Signed-off-by: Shenlin Liang liangshenlin@eswincomputing.com Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
participants (3)
-
Shenlin Liang -
Simon Glass -
Tom Rini