[U-Boot] [PATCH 1/2] warp7: Remove CONFIG_SYS_FSL_ESDHC_ADDR
warp7 uses the driver model and it retrieves the ESDHC base address from device tree.
Remove the unneeded CONFIG_SYS_FSL_ESDHC_ADDR definition.
Signed-off-by: Fabio Estevam festevam@gmail.com --- include/configs/warp7.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/warp7.h b/include/configs/warp7.h index 73541fe176..9c6ee6997f 100644 --- a/include/configs/warp7.h +++ b/include/configs/warp7.h @@ -17,7 +17,6 @@ #define CONFIG_SYS_MALLOC_LEN (35 * SZ_1M)
/* MMC Config*/ -#define CONFIG_SYS_FSL_ESDHC_ADDR USDHC3_BASE_ADDR #define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE #define CONFIG_SYS_MMC_IMG_LOAD_PART 1
The "mmc dev" command is being called twice.
Remove the extra call.
Signed-off-by: Fabio Estevam festevam@gmail.com --- include/configs/warp7.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/warp7.h b/include/configs/warp7.h index 9c6ee6997f..f1fc6c714f 100644 --- a/include/configs/warp7.h +++ b/include/configs/warp7.h @@ -94,7 +94,6 @@ "fi;\0" \
#define CONFIG_BOOTCOMMAND \ - "mmc dev ${mmcdev};" \ "mmc dev ${mmcdev}; if mmc rescan; then " \ "run do_bootscript_hab;" \ "if run loadbootscript; then " \
Hi Fabio,
Le 23/10/2019 à 16:20, Fabio Estevam a écrit :
The "mmc dev" command is being called twice.
Remove the extra call.
Signed-off-by: Fabio Estevam festevam@gmail.com
include/configs/warp7.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/warp7.h b/include/configs/warp7.h index 9c6ee6997f..f1fc6c714f 100644 --- a/include/configs/warp7.h +++ b/include/configs/warp7.h @@ -94,7 +94,6 @@ "fi;\0" \
#define CONFIG_BOOTCOMMAND \
"mmc dev ${mmcdev};" \ "mmc dev ${mmcdev}; if mmc rescan; then " \ "run do_bootscript_hab;" \ "if run loadbootscript; then " \
Reviewed-by: Pierre-Jean Texier pjtexier@koncepto.io Tested-by: Pierre-Jean Texier pjtexier@koncepto.io
Thanks !
Hi Fabio,
Le 23/10/2019 à 16:20, Fabio Estevam a écrit :
The "mmc dev" command is being called twice.
Remove the extra call.
Signed-off-by: Fabio Estevam festevam@gmail.com
include/configs/warp7.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/warp7.h b/include/configs/warp7.h index 9c6ee6997f..f1fc6c714f 100644 --- a/include/configs/warp7.h +++ b/include/configs/warp7.h @@ -94,7 +94,6 @@ "fi;\0" \
#define CONFIG_BOOTCOMMAND \
"mmc dev ${mmcdev};" \ "mmc dev ${mmcdev}; if mmc rescan; then " \ "run do_bootscript_hab;" \ "if run loadbootscript; then " \
Reviewed-by: Joris Offouga offougajoris@gmail.com
Best regards,
Joris Offouga
Hi Fabio,
Le 23/10/2019 à 16:20, Fabio Estevam a écrit :
warp7 uses the driver model and it retrieves the ESDHC base address from device tree.
Remove the unneeded CONFIG_SYS_FSL_ESDHC_ADDR definition.
Signed-off-by: Fabio Estevam festevam@gmail.com
include/configs/warp7.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/warp7.h b/include/configs/warp7.h index 73541fe176..9c6ee6997f 100644 --- a/include/configs/warp7.h +++ b/include/configs/warp7.h @@ -17,7 +17,6 @@ #define CONFIG_SYS_MALLOC_LEN (35 * SZ_1M)
/* MMC Config*/ -#define CONFIG_SYS_FSL_ESDHC_ADDR USDHC3_BASE_ADDR #define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE #define CONFIG_SYS_MMC_IMG_LOAD_PART 1
Reviewed-by: Pierre-Jean Texier pjtexier@koncepto.io Tested-by: Pierre-Jean Texier pjtexier@koncepto.io
Thanks !
Hi Fabio,
Le 23/10/2019 à 16:20, Fabio Estevam a écrit :
warp7 uses the driver model and it retrieves the ESDHC base address from device tree.
Remove the unneeded CONFIG_SYS_FSL_ESDHC_ADDR definition.
Signed-off-by: Fabio Estevam festevam@gmail.com
include/configs/warp7.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/warp7.h b/include/configs/warp7.h index 73541fe176..9c6ee6997f 100644 --- a/include/configs/warp7.h +++ b/include/configs/warp7.h @@ -17,7 +17,6 @@ #define CONFIG_SYS_MALLOC_LEN (35 * SZ_1M)
/* MMC Config*/ -#define CONFIG_SYS_FSL_ESDHC_ADDR USDHC3_BASE_ADDR #define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE #define CONFIG_SYS_MMC_IMG_LOAD_PART 1
Reviewed-by: Joris Offouga offougajoris@gmail.com
Tested-by: Joris Offouga offougajoris@gmail.com
Best regards,
Joris Offouga
participants (3)
-
Fabio Estevam -
Joris Offouga -
Pierre-Jean Texier