[U-Boot] [PATCH] ppc4xx: AMCC PPC460GT/EX PCI-E de-emphasis adjustment fix
From: Tirumala R Marri tmarri@amcc.com
During recent PCI-E tests it has been found that current driverl level and de-emphasis values are not set correctly. After sweeping throgh all de-ephasis values, it was found that 0x130 is a right value. Where 0x13 is driver level and 0 is de-emphasis.
Signed-off-by: Tirumala R Marri tmarri@amcc.com --- cpu/ppc4xx/4xx_pcie.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/cpu/ppc4xx/4xx_pcie.c b/cpu/ppc4xx/4xx_pcie.c index 9803fcc..0aadc06 100644 --- a/cpu/ppc4xx/4xx_pcie.c +++ b/cpu/ppc4xx/4xx_pcie.c @@ -638,7 +638,7 @@ int __ppc4xx_init_pcie_port_hw(int port, int rootport) switch (port) { case 0: SDR_WRITE(PESDR0_L0CDRCTL, 0x00003230); - SDR_WRITE(PESDR0_L0DRV, 0x00000136); + SDR_WRITE(PESDR0_L0DRV, 0x00000130); SDR_WRITE(PESDR0_L0CLK, 0x00000006);
SDR_WRITE(PESDR0_PHY_CTL_RST,0x10000000); @@ -649,10 +649,10 @@ int __ppc4xx_init_pcie_port_hw(int port, int rootport) SDR_WRITE(PESDR1_L1CDRCTL, 0x00003230); SDR_WRITE(PESDR1_L2CDRCTL, 0x00003230); SDR_WRITE(PESDR1_L3CDRCTL, 0x00003230); - SDR_WRITE(PESDR1_L0DRV, 0x00000136); - SDR_WRITE(PESDR1_L1DRV, 0x00000136); - SDR_WRITE(PESDR1_L2DRV, 0x00000136); - SDR_WRITE(PESDR1_L3DRV, 0x00000136); + SDR_WRITE(PESDR1_L0DRV, 0x00000130); + SDR_WRITE(PESDR1_L1DRV, 0x00000130); + SDR_WRITE(PESDR1_L2DRV, 0x00000130); + SDR_WRITE(PESDR1_L3DRV, 0x00000130); SDR_WRITE(PESDR1_L0CLK, 0x00000006); SDR_WRITE(PESDR1_L1CLK, 0x00000006); SDR_WRITE(PESDR1_L2CLK, 0x00000006);
Hi Marri,
On Friday 22 August 2008, fkan@amcc.com wrote:
From: Tirumala R Marri tmarri@amcc.com
During recent PCI-E tests it has been found that current driverl level and de-emphasis values are not set correctly. After sweeping throgh all de-ephasis values, it was found that 0x130 is a right value. Where 0x13 is driver level and 0 is de-emphasis.
Is this supposed to fix the issue with the Intel PRO/1000 in PCIe slot 0 on Canyonlands? Booting with root-fs via NFS doesn't work with this card in slot 0. In slot 1 it works.
I just tested this patch and the Linux patch you posted and the issue is still there:
eth0: Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX Looking up port of RPC 100005/1 on 10.0.0.152 VFS: Mounted root (nfs filesystem). Freeing unused kernel memory: 156k init modprobe: FATAL: Could not load /lib/modules/2.6.26-00016-gf873d41/modules.dep: No such file or directory
modprobe: FATAL: Could not load /lib/modules/2.6.26-00016-gf873d41/modules.dep: No such file or directory
INIT: version 2.86 booting Welcome to DENX Embedded Linux Environment Press 'I' to enter interactive startup. modprobe: FATAL: Could not load /lib/modules/2.6.26-00016-gf873d41/modules.dep: No such file or directory
modprobe: FATAL: Could not load /lib/modules/2.6.26-00016-gf873d41/modules.dep: No such file or directory
Cannot access the Hardware Clock via any known method. Use the --debug option to see the details of our search for an access method. Setting clock : Thu Jan 1 01:00:13 CET 1970 [ OK ] Building the cache nfs: server 10.0.0.152 not responding, still trying nfs: server 10.0.0.152 not responding, still trying nfs: server 10.0.0.152 not responding, still trying nfs: server 10.0.0.152 not responding, still trying nfs: server 10.0.0.152 not responding, still trying
Any comments on this?
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================
Hi Stefan, There were silent corruptions I noticed during a RAID-5 test using silicon image card. Then I hooked up a analyzer and found that eye diagram was not wide enough. After reducing the de-emphasis value I noticed better eye diagram. Also I ran 72 hour test which was successful to see if there are any corruptions .
Even though these de-emphasis values are only applicable to Linux. I wanted to make sure both Linux and u-boot are in sync. Regards, Marri -----Original Message----- From: Stefan Roese [mailto:sr@denx.de] Sent: Friday, August 22, 2008 1:42 AM To: u-boot@lists.denx.de Cc: Feng Kan; Tirumala Reddy Marri Subject: Re: [U-Boot] [PATCH] ppc4xx: AMCC PPC460GT/EX PCI-E de-emphasis adjustment fix
Hi Marri,
On Friday 22 August 2008, fkan@amcc.com wrote:
From: Tirumala R Marri tmarri@amcc.com
During recent PCI-E tests it has been found that current driverl level
and de-emphasis values are not set correctly. After sweeping throgh all de-ephasis values, it was found that 0x130 is a right value. Where 0x13 is driver level and 0 is de-emphasis.
Is this supposed to fix the issue with the Intel PRO/1000 in PCIe slot 0 on Canyonlands? Booting with root-fs via NFS doesn't work with this card in slot 0. In slot 1 it works.
I just tested this patch and the Linux patch you posted and the issue is still there:
eth0: Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX Looking up port of RPC 100005/1 on 10.0.0.152 VFS: Mounted root (nfs filesystem). Freeing unused kernel memory: 156k init modprobe: FATAL: Could not load /lib/modules/2.6.26-00016-gf873d41/modules.dep: No such file or directory
modprobe: FATAL: Could not load /lib/modules/2.6.26-00016-gf873d41/modules.dep: No such file or directory
INIT: version 2.86 booting Welcome to DENX Embedded Linux Environment Press 'I' to enter interactive startup. modprobe: FATAL: Could not load /lib/modules/2.6.26-00016-gf873d41/modules.dep: No such file or directory
modprobe: FATAL: Could not load /lib/modules/2.6.26-00016-gf873d41/modules.dep: No such file or directory
Cannot access the Hardware Clock via any known method. Use the --debug option to see the details of our search for an access method. Setting clock : Thu Jan 1 01:00:13 CET 1970 [ OK ] Building the cache nfs: server 10.0.0.152 not responding, still trying nfs: server 10.0.0.152 not responding, still trying nfs: server 10.0.0.152 not responding, still trying nfs: server 10.0.0.152 not responding, still trying nfs: server 10.0.0.152 not responding, still trying
Any comments on this?
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================
Hi Marri,
On Friday 22 August 2008, Tirumala Reddy Marri wrote:
There were silent corruptions I noticed during a RAID-5 test using silicon image card. Then I hooked up a analyzer and found that eye diagram was not wide enough. After reducing the de-emphasis value I noticed better eye diagram. Also I ran 72 hour test which was successful to see if there are any corruptions .
Did you run this on a Canyonlands? If yes, which PCIe slot did you use?
Even though these de-emphasis values are only applicable to Linux. I wanted to make sure both Linux and u-boot are in sync.
Yes, makes perfect sense. I'll push this into my repository later.
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================
participants (3)
-
fkan＠amcc.com -
Stefan Roese -
Tirumala Reddy Marri