[PATCH v1] arm: dts: verdin-imx8mm/imx8mp: use gpio-hog for sleep moci
From: Stefan Eichenberger stefan.eichenberger@toradex.com
In Linux, we allow sleep moci to be turned off when the carrier board supports it and the system is in suspend. In U-Boot, however, we want the sleep moci to be always on. So we use a gpio hog and disable the regulator. This change is necessary because we switched to upstream device tree files with commit 23fe2def1edf ("verdin-imx8mm/verdin-imx8mp: move imx verdins to OF_UPSTREAM"). A recent upstream patch removes the gpio hog from the Linux device tree, so we need to add it to the u-boot dtsi. The following patch will remove the gpio hog from the Linux device tree: https://lore.kernel.org/linux-devicetree/20240405160720.5977-1-eichest@gmail... The U-Boot patch can be applied without it and will not break the build.
Signed-off-by: Stefan Eichenberger stefan.eichenberger@toradex.com --- arch/arm/dts/imx8mm-verdin-wifi-dev-u-boot.dtsi | 5 +++++ arch/arm/dts/imx8mp-verdin-wifi-dev-u-boot.dtsi | 4 ++++ 2 files changed, 9 insertions(+)
diff --git a/arch/arm/dts/imx8mm-verdin-wifi-dev-u-boot.dtsi b/arch/arm/dts/imx8mm-verdin-wifi-dev-u-boot.dtsi index 38db56059d..8b397f535c 100644 --- a/arch/arm/dts/imx8mm-verdin-wifi-dev-u-boot.dtsi +++ b/arch/arm/dts/imx8mm-verdin-wifi-dev-u-boot.dtsi @@ -60,6 +60,11 @@
ctrl-sleep-moci-hog { bootph-pre-ram; + gpio-hog; + output-high; + gpios = <1 GPIO_ACTIVE_HIGH>; + line-name = "CTRL_SLEEP_MOCI#"; + }; };
diff --git a/arch/arm/dts/imx8mp-verdin-wifi-dev-u-boot.dtsi b/arch/arm/dts/imx8mp-verdin-wifi-dev-u-boot.dtsi index 03f211d5f7..7b45a87450 100644 --- a/arch/arm/dts/imx8mp-verdin-wifi-dev-u-boot.dtsi +++ b/arch/arm/dts/imx8mp-verdin-wifi-dev-u-boot.dtsi @@ -58,6 +58,10 @@
ctrl-sleep-moci-hog { bootph-pre-ram; + gpio-hog; + output-high; + gpios = <29 GPIO_ACTIVE_HIGH>; + line-name = "CTRL_SLEEP_MOCI#"; }; };
Subject: [PATCH v1] arm: dts: verdin-imx8mm/imx8mp: use gpio-hog for sleep moci
From: Stefan Eichenberger stefan.eichenberger@toradex.com
In Linux, we allow sleep moci to be turned off when the carrier board supports it and the system is in suspend. In U-Boot, however, we want the sleep moci to be always on. So we use a gpio hog and disable the regulator. This change is necessary because we switched to upstream device tree files with commit 23fe2def1edf ("verdin-imx8mm/verdin-imx8mp: move imx verdins to OF_UPSTREAM"). A recent upstream patch removes the gpio hog from the Linux device tree, so we need to add it to the u-boot dtsi. The following patch will remove the gpio hog from the Linux device tree: https://lore.ke/ rnel.org%2Flinux-devicetree%2F20240405160720.5977-1- eichest%40gmail.com%2F&data=05%7C02%7Cpeng.fan%40nxp.com%7C0ec7 6e3870ef48ab53fd08dc5ebb433c%7C686ea1d3bc2b4c6fa92cd99c5c301635 %7C0%7C0%7C638489405607145323%7CUnknown%7CTWFpbGZsb3d8eyJ WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D% 7C0%7C%7C%7C&sdata=jSxtB3eu0uvBO0UPV8TY16yrEgCdTqgj6fwrwmG%2F v7s%3D&reserved=0 The U-Boot patch can be applied without it and will not break the build.
Signed-off-by: Stefan Eichenberger stefan.eichenberger@toradex.com
Reviewed-by: Peng Fan peng.fan@nxp.com
arch/arm/dts/imx8mm-verdin-wifi-dev-u-boot.dtsi | 5 +++++ arch/arm/dts/imx8mp-verdin-wifi-dev-u-boot.dtsi | 4 ++++ 2 files changed, 9 insertions(+)
diff --git a/arch/arm/dts/imx8mm-verdin-wifi-dev-u-boot.dtsi b/arch/arm/dts/imx8mm-verdin-wifi-dev-u-boot.dtsi index 38db56059d..8b397f535c 100644 --- a/arch/arm/dts/imx8mm-verdin-wifi-dev-u-boot.dtsi +++ b/arch/arm/dts/imx8mm-verdin-wifi-dev-u-boot.dtsi @@ -60,6 +60,11 @@
ctrl-sleep-moci-hog { bootph-pre-ram;
gpio-hog;output-high;gpios = <1 GPIO_ACTIVE_HIGH>;line-name = "CTRL_SLEEP_MOCI#";};};
diff --git a/arch/arm/dts/imx8mp-verdin-wifi-dev-u-boot.dtsi b/arch/arm/dts/imx8mp-verdin-wifi-dev-u-boot.dtsi index 03f211d5f7..7b45a87450 100644 --- a/arch/arm/dts/imx8mp-verdin-wifi-dev-u-boot.dtsi +++ b/arch/arm/dts/imx8mp-verdin-wifi-dev-u-boot.dtsi @@ -58,6 +58,10 @@
ctrl-sleep-moci-hog { bootph-pre-ram;
gpio-hog;output-high;gpios = <29 GPIO_ACTIVE_HIGH>;line-name = "CTRL_SLEEP_MOCI#"; };};
-- 2.40.1
On Wed, Apr 17, 2024 at 5:49 AM Stefan Eichenberger eichest@gmail.com wrote:
From: Stefan Eichenberger stefan.eichenberger@toradex.com
In Linux, we allow sleep moci to be turned off when the carrier board supports it and the system is in suspend. In U-Boot, however, we want the sleep moci to be always on. So we use a gpio hog and disable the regulator. This change is necessary because we switched to upstream device tree files with commit 23fe2def1edf ("verdin-imx8mm/verdin-imx8mp: move imx verdins to OF_UPSTREAM"). A recent upstream patch removes the gpio hog from the Linux device tree, so we need to add it to the u-boot dtsi. The following patch will remove the gpio hog from the Linux device tree: https://lore.kernel.org/linux-devicetree/20240405160720.5977-1-eichest@gmail... The U-Boot patch can be applied without it and will not break the build.
Signed-off-by: Stefan Eichenberger stefan.eichenberger@toradex.com
Applied, thanks.
participants (3)
-
Fabio Estevam -
Peng Fan -
Stefan Eichenberger