Hi Heiko

Thanks for your review. Our bmc HW can support standard / fast / fast plus mode but our first uboot version 2019 is only run on standard mode. so the first upstream version is the same as before.

Now, some customer need to test other mode on uboot. So remove this judgment to support other mode.

I will add a commit message in the next version.

Best regards, Jim

On Mon, Oct 2, 2023 at 9:37 PM Heiko Schocher hs@denx.de wrote:

Hello Jim,

On 26.09.23 11:08, Jim Liu wrote:

...

Signed-off-by: Jim Liu JJLIU0@nuvoton.com

drivers/i2c/npcm_i2c.c | 5 ----- 1 file changed, 5 deletions(-)

diff --git a/drivers/i2c/npcm_i2c.c b/drivers/i2c/npcm_i2c.c index ea4ef53256..b867b6c8e9 100644 --- a/drivers/i2c/npcm_i2c.c +++ b/drivers/i2c/npcm_i2c.c @@ -517,11 +517,6 @@ static int npcm_i2c_init_clk(struct npcm_i2c_bus *bus, u32 bus_freq) u32 sclfrq; u8 hldt, val;

• if (bus_freq > I2C_FREQ_100K) {
  

•         printf("Support standard mode only\n");
  

•         return -EINVAL;
  

• }
  

Is it so easy to enable fast mode? As original code explicitely says "Support standard mode only" and returns -EINVAL?

And please add some text into commit message, may you can explain why current driver supports fast mode?

Thanks!

bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de