[U-Boot] [PATCH] mpc86xx: use r4 instead of r2 in lock_ram_in_cache and unlock_ram_in_cache

This is needed in unlock_ram_in_cache() because it is called from C and will corrupt the small data area anchor that is kept in R2.
lock_ram_in_cache() is modified similarly as good coding practice, but is not called from C.
Signed-off-by: Nick Spence nick.spence@freescale.com --- cpu/mpc86xx/start.S | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/cpu/mpc86xx/start.S b/cpu/mpc86xx/start.S index 03f2128..90a1b83 100644 --- a/cpu/mpc86xx/start.S +++ b/cpu/mpc86xx/start.S @@ -895,9 +895,9 @@ lock_ram_in_cache: */ lis r3, (CFG_INIT_RAM_ADDR & ~31)@h ori r3, r3, (CFG_INIT_RAM_ADDR & ~31)@l - li r2, ((CFG_INIT_RAM_END & ~31) + \ + li r4, ((CFG_INIT_RAM_END & ~31) + \ (CFG_INIT_RAM_ADDR & 31) + 31) / 32 - mtctr r2 + mtctr r4 1: dcbz r0, r3 addi r3, r3, 32 @@ -930,9 +930,9 @@ unlock_ram_in_cache: /* invalidate the INIT_RAM section */ lis r3, (CFG_INIT_RAM_ADDR & ~31)@h ori r3, r3, (CFG_INIT_RAM_ADDR & ~31)@l - li r2, ((CFG_INIT_RAM_END & ~31) + \ + li r4, ((CFG_INIT_RAM_END & ~31) + \ (CFG_INIT_RAM_ADDR & 31) + 31) / 32 - mtctr r2 + mtctr r4 1: icbi r0, r3 addi r3, r3, 32 bdnz 1b

Dear Jon,
in message 12199577553905-git-send-email-nick.spence@freescale.com Nick Spence wrote:
This is needed in unlock_ram_in_cache() because it is called from C and will corrupt the small data area anchor that is kept in R2.
lock_ram_in_cache() is modified similarly as good coding practice, but is not called from C.
Signed-off-by: Nick Spence nick.spence@freescale.com
cpu/mpc86xx/start.S | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
I think this patch was not added, nor was any feedback sent?
Please comment.
Best regards,
Wolfgang Denk

Dear Nick Spence,
In message 12199577553905-git-send-email-nick.spence@freescale.com you wrote:
This is needed in unlock_ram_in_cache() because it is called from C and will corrupt the small data area anchor that is kept in R2.
lock_ram_in_cache() is modified similarly as good coding practice, but is not called from C.
Signed-off-by: Nick Spence nick.spence@freescale.com
cpu/mpc86xx/start.S | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (2)
-
Nick Spence
-
Wolfgang Denk