[U-Boot] [PATCH 1/1] configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT
The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit is exceeded.
CONFIG_SPL_I2C_SUPPORT is not needed to move to main U-Boot. So let's disable it.
Suggested-by: David Wu david.wu@rock-chips.com Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- This solves only one of the problems with the boards in v2019.04. The next problem is that reading the environment from MMC fails.
The patch [PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB https://lists.denx.de/pipermail/u-boot/2019-February/358883.html makes the problem visibe. --- configs/tinker-rk3288_defconfig | 1 - 1 file changed, 1 deletion(-)
diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig index 68adf7635bf..03a7f81d63d 100644 --- a/configs/tinker-rk3288_defconfig +++ b/configs/tinker-rk3288_defconfig @@ -18,7 +18,6 @@ CONFIG_DEFAULT_FDT_FILE="rk3288-tinker.dtb" CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_STACK_R=y CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000 -CONFIG_SPL_I2C_SUPPORT=y CONFIG_CMD_GPIO=y CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y
On 2/27/19 8:05 PM, Heinrich Schuchardt wrote:
The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit is exceeded.
CONFIG_SPL_I2C_SUPPORT is not needed to move to main U-Boot. So let's disable it.
Suggested-by: David Wu david.wu@rock-chips.com Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
Hello Philipp,
the patch has been assigned to you in patchwork. Is there any reason not to merge it into U-Boot v2019.04?
Best regards
Heinrich
This solves only one of the problems with the boards in v2019.04. The next problem is that reading the environment from MMC fails.
The patch [PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB https://lists.denx.de/pipermail/u-boot/2019-February/358883.html makes the problem visibe.
configs/tinker-rk3288_defconfig | 1 - 1 file changed, 1 deletion(-)
diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig index 68adf7635bf..03a7f81d63d 100644 --- a/configs/tinker-rk3288_defconfig +++ b/configs/tinker-rk3288_defconfig @@ -18,7 +18,6 @@ CONFIG_DEFAULT_FDT_FILE="rk3288-tinker.dtb" CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_STACK_R=y CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000 -CONFIG_SPL_I2C_SUPPORT=y CONFIG_CMD_GPIO=y CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y
Hi Philipp,
This config does not look like it will be used in SPL and can be deleted.
Reviewed-by: David Wu david.wu@rock-chips.com
在 2019/2/28 上午3:05, Heinrich Schuchardt 写道:
The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit is exceeded.
CONFIG_SPL_I2C_SUPPORT is not needed to move to main U-Boot. So let's disable it.
Suggested-by: David Wu david.wu@rock-chips.com Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
This solves only one of the problems with the boards in v2019.04. The next problem is that reading the environment from MMC fails.
The patch [PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB https://lists.denx.de/pipermail/u-boot/2019-February/358883.html makes the problem visibe.
configs/tinker-rk3288_defconfig | 1 - 1 file changed, 1 deletion(-)
diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig index 68adf7635bf..03a7f81d63d 100644 --- a/configs/tinker-rk3288_defconfig +++ b/configs/tinker-rk3288_defconfig @@ -18,7 +18,6 @@ CONFIG_DEFAULT_FDT_FILE="rk3288-tinker.dtb" CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_STACK_R=y CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000 -CONFIG_SPL_I2C_SUPPORT=y CONFIG_CMD_GPIO=y CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y
The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit is exceeded.
CONFIG_SPL_I2C_SUPPORT is not needed to move to main U-Boot. So let's disable it.
Suggested-by: David Wu david.wu@rock-chips.com Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de Reviewed-by: David Wu david.wu@rock-chips.com
This solves only one of the problems with the boards in v2019.04. The next problem is that reading the environment from MMC fails.
The patch [PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB https://lists.denx.de/pipermail/u-boot/2019-February/358883.html makes the problem visibe.
configs/tinker-rk3288_defconfig | 1 - 1 file changed, 1 deletion(-)
Reviewed-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
On 4/21/19 6:57 PM, Philipp Tomsich wrote:
The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit is exceeded.
CONFIG_SPL_I2C_SUPPORT is not needed to move to main U-Boot. So let's disable it.
Suggested-by: David Wu david.wu@rock-chips.com Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de Reviewed-by: David Wu david.wu@rock-chips.com
This solves only one of the problems with the boards in v2019.04. The next problem is that reading the environment from MMC fails.
The patch [PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB https://lists.denx.de/pipermail/u-boot/2019-February/358883.html makes the problem visibe.
configs/tinker-rk3288_defconfig | 1 - 1 file changed, 1 deletion(-)
Reviewed-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
Hello Tom,
could you, please, merge this patch that has been lingering since February to fix the build issue for the TinkerBoard:
https://lists.denx.de/pipermail/u-boot/2019-February/360367.html https://patchwork.ozlabs.org/patch/1049112/
You will have to rebase the patch:
CONFIG_SPL_TEXT_BASE=0xff704000 <<<< change this line CONFIG_SPL_STACK_R=y CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000 -CONFIG_SPL_I2C_SUPPORT=y CONFIG_CMD_GPIO=y CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y
Best regards
Heinrich
On Wed, Feb 27, 2019 at 08:05:43PM +0100, Heinrich Schuchardt wrote:
The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit is exceeded.
CONFIG_SPL_I2C_SUPPORT is not needed to move to main U-Boot. So let's disable it.
Suggested-by: David Wu david.wu@rock-chips.com Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de Reviewed-by: David Wu david.wu@rock-chips.com Reviewed-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
Applied to u-boot/master, thanks!
participants (5)
-
David Wu -
Heinrich Schuchardt -
Heinrich Schuchardt -
Philipp Tomsich -
Tom Rini