[U-Boot] [PATCH] mpc8315erdb: fix out-of-tree building for NAND config

Out-of-tree build for MPC8315ERDB_NAND configuration failed with /bin/sh: line 0: cd: /tmp/foo/nand_spl/board/freescale/mpc8315erdb: No such file or directory error message
Signed-off-by: Wolfgang Denk wd@denx.de --- Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile index 524b9da..72f59f8 100644 --- a/Makefile +++ b/Makefile @@ -2273,6 +2273,8 @@ MPC8313ERDB_NAND_66_config: unconfig MPC8315ERDB_NAND_config \ MPC8315ERDB_config: unconfig @if [ "$(findstring _NAND_,$@)" ] ; then \ + mkdir -p $(obj)nand_spl/board/freescale/mpc8313erdb ; \ + ln -sf mpc8313erdb $(obj)nand_spl/board/freescale/mpc8315erdb ; \ ln -sf mpc8313erdb nand_spl/board/freescale/mpc8315erdb ; \ fi ; @$(MKCONFIG) -t $(@:_config=) MPC8315ERDB ppc mpc83xx mpc8315erdb freescale

On Sun, 21 Feb 2010 21:52:56 +0100 Wolfgang Denk wd@denx.de wrote:
Out-of-tree build for MPC8315ERDB_NAND configuration failed with /bin/sh: line 0: cd: /tmp/foo/nand_spl/board/freescale/mpc8315erdb: No such file or directory error message
Signed-off-by: Wolfgang Denk wd@denx.de
applied.
Thanks Wolfgang,
Kim

Dear Kim Phillips,
In message 20100222192612.8da0a6b6.kim.phillips@freescale.com you wrote:
On Sun, 21 Feb 2010 21:52:56 +0100 Wolfgang Denk wd@denx.de wrote:
Out-of-tree build for MPC8315ERDB_NAND configuration failed with /bin/sh: line 0: cd: /tmp/foo/nand_spl/board/freescale/mpc8315erdb: No such file or directory error message
Signed-off-by: Wolfgang Denk wd@denx.de
applied.
Please undo. This is still broken.
Running an out of tree build for MPC8315ERDB_NAND causes the symbolic link nand_spl/board/freescale/mpc8315erdb -> mpc8313erdb to be created in the local source tree. But the local source tree must be left unchanged for out of tree builds (assume it is on a read-only storage device).
As is, I see no straightforward way to acchieve this - the current implementation assumes there is a board directory mpc8315erdb which does not exist.
I think this must be changed on a deeper level.
Can you please look into this? Thanks.
Best regards,
Wolfgang Denk

On Tue, 23 Feb 2010 23:58:42 +0100 Wolfgang Denk wd@denx.de wrote:
Dear Kim Phillips,
In message 20100222192612.8da0a6b6.kim.phillips@freescale.com you wrote:
On Sun, 21 Feb 2010 21:52:56 +0100 Wolfgang Denk wd@denx.de wrote:
Out-of-tree build for MPC8315ERDB_NAND configuration failed with /bin/sh: line 0: cd: /tmp/foo/nand_spl/board/freescale/mpc8315erdb: No such file or directory error message
Signed-off-by: Wolfgang Denk wd@denx.de
applied.
Please undo. This is still broken.
Running an out of tree build for MPC8315ERDB_NAND causes the symbolic link nand_spl/board/freescale/mpc8315erdb -> mpc8313erdb to be created in the local source tree. But the local source tree must be left unchanged for out of tree builds (assume it is on a read-only storage device).
As is, I see no straightforward way to acchieve this - the current implementation assumes there is a board directory mpc8315erdb which does not exist.
I think this must be changed on a deeper level.
Can you please look into this? Thanks.
it seems a complete merge of mpc8313 and mpc8315 into mpc831x is in order. I'll see what I can do.
Kim

On Tue, Feb 23, 2010 at 06:48:15PM -0600, Kim Phillips wrote: [...]
Can you please look into this? Thanks.
it seems a complete merge of mpc8313 and mpc8315 into mpc831x is in order. I'll see what I can do.
IIRC some 837x boards can boot from nand too, and I guess there isn't much differencies between 831x and 837x SPLs. Maybe there is some way to merge 831x SPL into 83xx SPL?
Thanks,
participants (3)
-
Anton Vorontsov
-
Kim Phillips
-
Wolfgang Denk