[PATCH] board: amlogic: vim3: ethernet mac fixed from serial

Fixed randomly generated ethernet mac address!
Used meson_generate_serial_ethaddr for generate mac address from board serial number, if ethaddr variable not defined.
Signed-off-by: Artem Lapkin art@khadas.com --- board/amlogic/vim3/vim3.c | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/board/amlogic/vim3/vim3.c b/board/amlogic/vim3/vim3.c index 09ef39ff30..0315eaf569 100644 --- a/board/amlogic/vim3/vim3.c +++ b/board/amlogic/vim3/vim3.c @@ -133,5 +133,14 @@ int misc_init_r(void) { meson_eth_init(PHY_INTERFACE_MODE_RGMII, 0);
+ u8 mac_addr[6]; + if (!eth_env_get_enetaddr("ethaddr", mac_addr)) { + meson_generate_serial_ethaddr(); + eth_env_get_enetaddr("ethaddr", mac_addr); + printf("[i] serial eth mac %02X:%02X:%02X:%02X:%02X:%02X\n", + mac_addr[0],mac_addr[1],mac_addr[2], + mac_addr[3],mac_addr[4],mac_addr[5]); + } + return 0; }

Hi,
On 1/8/21 2:43 PM, Artem Lapkin wrote:
Fixed randomly generated ethernet mac address!
Used meson_generate_serial_ethaddr for generate mac address from board serial number, if ethaddr variable not defined.
AFAIK, it's fixed with Marek's patch
https://patchwork.ozlabs.org/project/uboot/patch/20201217072642.1319-1-m.szy...
Best Regards, Jaehoon CHung
Signed-off-by: Artem Lapkin art@khadas.com
board/amlogic/vim3/vim3.c | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/board/amlogic/vim3/vim3.c b/board/amlogic/vim3/vim3.c index 09ef39ff30..0315eaf569 100644 --- a/board/amlogic/vim3/vim3.c +++ b/board/amlogic/vim3/vim3.c @@ -133,5 +133,14 @@ int misc_init_r(void) { meson_eth_init(PHY_INTERFACE_MODE_RGMII, 0);
- u8 mac_addr[6];
- if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
meson_generate_serial_ethaddr();
eth_env_get_enetaddr("ethaddr", mac_addr);
printf("[i] serial eth mac %02X:%02X:%02X:%02X:%02X:%02X\n",
mac_addr[0],mac_addr[1],mac_addr[2],
mac_addr[3],mac_addr[4],mac_addr[5]);
- }
- return 0;
}

AFAIK, it's fixed with Marek's patch
https://patchwork.ozlabs.org/project/uboot/patch/20201217072642.1319-1-m.szy...
not solve ! because mac which must stored in mcu is empty by default and by default we have random mac every time
i think i will make new complex patch from both patches
On Mon, Jan 11, 2021 at 6:46 AM Jaehoon Chung jh80.chung@samsung.com wrote:
Hi,
On 1/8/21 2:43 PM, Artem Lapkin wrote:
Fixed randomly generated ethernet mac address!
Used meson_generate_serial_ethaddr for generate mac address from board serial number, if ethaddr variable not defined.
AFAIK, it's fixed with Marek's patch
https://patchwork.ozlabs.org/project/uboot/patch/20201217072642.1319-1-m.szy...
Best Regards, Jaehoon CHung
Signed-off-by: Artem Lapkin art@khadas.com
board/amlogic/vim3/vim3.c | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/board/amlogic/vim3/vim3.c b/board/amlogic/vim3/vim3.c index 09ef39ff30..0315eaf569 100644 --- a/board/amlogic/vim3/vim3.c +++ b/board/amlogic/vim3/vim3.c @@ -133,5 +133,14 @@ int misc_init_r(void) { meson_eth_init(PHY_INTERFACE_MODE_RGMII, 0);
u8 mac_addr[6];
if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
meson_generate_serial_ethaddr();
eth_env_get_enetaddr("ethaddr", mac_addr);
printf("[i] serial eth mac
%02X:%02X:%02X:%02X:%02X:%02X\n",
mac_addr[0],mac_addr[1],mac_addr[2],
mac_addr[3],mac_addr[4],mac_addr[5]);
}
return 0;
}

plz ignore my prev emails
AFAIK, it's fixed with Marek's patch
https://patchwork.ozlabs.org/project/uboot/patch/20201217072642.1319-1-m.szy...
look like yes ! u right
Best regards Art
On Mon, Jan 11, 2021 at 9:27 AM Art Nikpal email2tema@gmail.com wrote:
AFAIK, it's fixed with Marek's patch
https://patchwork.ozlabs.org/project/uboot/patch/20201217072642.1319-1-m.szy...
not solve ! because mac which must stored in mcu is empty by default and by default we have random mac every time
i think i will make new complex patch from both patches
On Mon, Jan 11, 2021 at 6:46 AM Jaehoon Chung jh80.chung@samsung.com wrote:
Hi,
On 1/8/21 2:43 PM, Artem Lapkin wrote:
Fixed randomly generated ethernet mac address!
Used meson_generate_serial_ethaddr for generate mac address from board serial number, if ethaddr variable not defined.
AFAIK, it's fixed with Marek's patch
https://patchwork.ozlabs.org/project/uboot/patch/20201217072642.1319-1-m.szy...
Best Regards, Jaehoon CHung
Signed-off-by: Artem Lapkin art@khadas.com
board/amlogic/vim3/vim3.c | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/board/amlogic/vim3/vim3.c b/board/amlogic/vim3/vim3.c index 09ef39ff30..0315eaf569 100644 --- a/board/amlogic/vim3/vim3.c +++ b/board/amlogic/vim3/vim3.c @@ -133,5 +133,14 @@ int misc_init_r(void) { meson_eth_init(PHY_INTERFACE_MODE_RGMII, 0);
u8 mac_addr[6];
if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
meson_generate_serial_ethaddr();
eth_env_get_enetaddr("ethaddr", mac_addr);
printf("[i] serial eth mac
%02X:%02X:%02X:%02X:%02X:%02X\n",
mac_addr[0],mac_addr[1],mac_addr[2],
mac_addr[3],mac_addr[4],mac_addr[5]);
}
return 0;
}
participants (3)
-
Art Nikpal
-
Artem Lapkin
-
Jaehoon Chung