Dear Lijun Pan,

In message 8a9667bd97ae488198eebd93bc38189c@DM2PR03MB368.namprd03.prod.outlook.com you wrote:

...

"is very useful" is not enough reason to add any code.

Where are the actual users of these functions? We will not add dead code.

I will be the actual user. I will upstream some codes using these functions.

Then please submit this patch as part of the series where you will actually use these functions.

Also, drivers/usb/host/xhci.h uses these. 64 bit architecture is becoming

Actually it uses only lower_32_bits(), and totally ignores the upper 32 bits, it there should be any. To me this looks like a bug.

...

Hm... This comment is definitely wrong for the Power Architecture, where bit 0 is always the most significan bit, so upper_32_bits would reutn bits 0...31.

I will modify the comment.

Thanks.

Best regards,

Wolfgang Denk