Re: [U-Boot] [PATCH v4 2/2] sifive: fu540: Enable OF_SEPARATE
Hi Jagon
From: Jagan Teki [mailto:jagan@amarulasolutions.com] Sent: Monday, November 18, 2019 7:30 PM To: Rick Jian-Zhi Chen(陳建志) Cc: u-boot@lists.denx.de; Jagan Teki Subject: [PATCH v4 2/2] sifive: fu540: Enable OF_SEPARATE
Use dts support from U-Boot via OF_SEPARATE instead of depending from opensbi.
This would help to make the necessary changes in drivers and device trees in U-Boot tree itself. This feature would also be helpful to not pass dtb during opensbi builds.
Signed-off-by: Jagan Teki jagan@amarulasolutions.com
Changes for v4:
- Drop abosolete text
configs/sifive_fu540_defconfig | 3 ++- doc/board/sifive/fu540.rst | 5 +---- 2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/configs/sifive_fu540_defconfig b/configs/sifive_fu540_defconfig index 48865e5f11..979d0a0418 100644 --- a/configs/sifive_fu540_defconfig +++ b/configs/sifive_fu540_defconfig @@ -6,6 +6,7 @@ CONFIG_RISCV_SMODE=y CONFIG_DISTRO_DEFAULTS=y CONFIG_FIT=y CONFIG_MISC_INIT_R=y +CONFIG_DEFAULT_DEVICE_TREE="hifive-unleashed-a00" CONFIG_DISPLAY_CPUINFO=y CONFIG_DISPLAY_BOARDINFO=y -CONFIG_OF_PRIOR_STAGE=y +CONFIG_OF_SEPARATE=y diff --git a/doc/board/sifive/fu540.rst b/doc/board/sifive/fu540.rst index 7807f5b2c1..dd279f6a03 100644 --- a/doc/board/sifive/fu540.rst +++ b/doc/board/sifive/fu540.rst @@ -58,10 +58,7 @@ firmware. We need to compile OpenSBI with below command:
.. code-block:: none
- make PLATFORM=sifive/fu540 FW_PAYLOAD_PATH=<path to u-boot.bin> FW_PAYLOAD_FDT_PATH=<path to hifive-unleashed-a00.dtb from Linux>
-(Note: Prefer hifive-unleashed-a00.dtb from Linux-5.3 or higher) -(Note: Linux-5.2 is also fine but it does not have ethernet DT node)
- make PLATFORM=sifive/fu540 FW_PAYLOAD_PATH=<path to u-boot-dtb.bin>
More detailed description of steps required to build FW_PAYLOAD firmware is beyond the scope of this document. Please refer OpenSBI documenation.
2.18.0.321.gffc6fa0e3
I am trying to prepare a PR, but it encounter a conflict with the master when applying this patch. Can you rebase it again ?
Or if you don't mind I can modify your patch directly.
Thanks Rick
Hi Rick,
On Mon, Dec 2, 2019 at 9:02 AM Rick Chen rickchen36@gmail.com wrote:
Hi Jagon
From: Jagan Teki [mailto:jagan@amarulasolutions.com] Sent: Monday, November 18, 2019 7:30 PM To: Rick Jian-Zhi Chen(陳建志) Cc: u-boot@lists.denx.de; Jagan Teki Subject: [PATCH v4 2/2] sifive: fu540: Enable OF_SEPARATE
Use dts support from U-Boot via OF_SEPARATE instead of depending from opensbi.
This would help to make the necessary changes in drivers and device trees in U-Boot tree itself. This feature would also be helpful to not pass dtb during opensbi builds.
Signed-off-by: Jagan Teki jagan@amarulasolutions.com
Changes for v4:
- Drop abosolete text
configs/sifive_fu540_defconfig | 3 ++- doc/board/sifive/fu540.rst | 5 +---- 2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/configs/sifive_fu540_defconfig b/configs/sifive_fu540_defconfig index 48865e5f11..979d0a0418 100644 --- a/configs/sifive_fu540_defconfig +++ b/configs/sifive_fu540_defconfig @@ -6,6 +6,7 @@ CONFIG_RISCV_SMODE=y CONFIG_DISTRO_DEFAULTS=y CONFIG_FIT=y CONFIG_MISC_INIT_R=y +CONFIG_DEFAULT_DEVICE_TREE="hifive-unleashed-a00" CONFIG_DISPLAY_CPUINFO=y CONFIG_DISPLAY_BOARDINFO=y -CONFIG_OF_PRIOR_STAGE=y +CONFIG_OF_SEPARATE=y diff --git a/doc/board/sifive/fu540.rst b/doc/board/sifive/fu540.rst index 7807f5b2c1..dd279f6a03 100644 --- a/doc/board/sifive/fu540.rst +++ b/doc/board/sifive/fu540.rst @@ -58,10 +58,7 @@ firmware. We need to compile OpenSBI with below command:
.. code-block:: none
- make PLATFORM=sifive/fu540 FW_PAYLOAD_PATH=<path to u-boot.bin> FW_PAYLOAD_FDT_PATH=<path to hifive-unleashed-a00.dtb from Linux>
-(Note: Prefer hifive-unleashed-a00.dtb from Linux-5.3 or higher) -(Note: Linux-5.2 is also fine but it does not have ethernet DT node)
- make PLATFORM=sifive/fu540 FW_PAYLOAD_PATH=<path to u-boot-dtb.bin>
More detailed description of steps required to build FW_PAYLOAD firmware is beyond the scope of this document. Please refer OpenSBI documenation.
2.18.0.321.gffc6fa0e3
I am trying to prepare a PR, but it encounter a conflict with the master when applying this patch. Can you rebase it again ?
Or if you don't mind I can modify your patch directly.
Sure, please do. thanks.
participants (2)
-
Jagan Teki -
Rick Chen