[PATCH] config: j7200: removed not needed power config

For J7200, R5/SPL TI_SCI_POWER_DOMAIN should be disabled as DM is a separate binary like other SOC of J7* family.
Fixes: 02dff65efe7 (configs: j7200_evm_r5: Add initial support)
Signed-off-by: Udit Kumar u-kumar1@ti.com --- Boot logs https://gist.github.com/uditkumarti/04f053efa73eae8be53666d9a31033c2
configs/j7200_evm_r5_defconfig | 1 - 1 file changed, 1 deletion(-)
diff --git a/configs/j7200_evm_r5_defconfig b/configs/j7200_evm_r5_defconfig index 6d240b16cb..9e744ba434 100644 --- a/configs/j7200_evm_r5_defconfig +++ b/configs/j7200_evm_r5_defconfig @@ -126,7 +126,6 @@ CONFIG_SPL_PINCTRL=y # CONFIG_SPL_PINCTRL_GENERIC is not set CONFIG_PINCTRL_SINGLE=y CONFIG_POWER_DOMAIN=y -CONFIG_TI_SCI_POWER_DOMAIN=y CONFIG_TI_POWER_DOMAIN=y CONFIG_DM_PMIC=y CONFIG_PMIC_TPS65941=y

On 16:49-20230911, Udit Kumar wrote:
For J7200, R5/SPL TI_SCI_POWER_DOMAIN should be disabled as DM is a separate binary like other SOC of J7* family.
Fixes: 02dff65efe7 (configs: j7200_evm_r5: Add initial support)
Signed-off-by: Udit Kumar u-kumar1@ti.com
Boot logs https://gist.github.com/uditkumarti/04f053efa73eae8be53666d9a31033c2
configs/j7200_evm_r5_defconfig | 1 - 1 file changed, 1 deletion(-)
diff --git a/configs/j7200_evm_r5_defconfig b/configs/j7200_evm_r5_defconfig index 6d240b16cb..9e744ba434 100644 --- a/configs/j7200_evm_r5_defconfig +++ b/configs/j7200_evm_r5_defconfig @@ -126,7 +126,6 @@ CONFIG_SPL_PINCTRL=y # CONFIG_SPL_PINCTRL_GENERIC is not set CONFIG_PINCTRL_SINGLE=y CONFIG_POWER_DOMAIN=y -CONFIG_TI_SCI_POWER_DOMAIN=y CONFIG_TI_POWER_DOMAIN=y CONFIG_DM_PMIC=y CONFIG_PMIC_TPS65941=y -- 2.34.1
And maybe expand this patch so that it contains something like the following to prevent this from coming back again elsewhere?
diff --git a/drivers/clk/ti/Kconfig b/drivers/clk/ti/Kconfig index fbcdefd889ae..aff1ba5ab43b 100644 --- a/drivers/clk/ti/Kconfig +++ b/drivers/clk/ti/Kconfig @@ -36,7 +36,7 @@ config CLK_TI_MUX
config CLK_TI_SCI bool "TI System Control Interface (TI SCI) clock driver" - depends on CLK && TI_SCI_PROTOCOL && OF_CONTROL + depends on CLK && TI_SCI_PROTOCOL && OF_CONTROL && !CLK_K3 help This enables the clock driver support over TI System Control Interface available on some new TI's SoCs. If you wish to use clock resources @@ -44,24 +44,24 @@ config CLK_TI_SCI
config CLK_K3_PLL bool "PLL clock support for K3 SoC family of devices" - depends on CLK && LIB_RATIONAL + depends on CLK && LIB_RATIONAL && !CLK_TI_SCI help Enables PLL clock support for K3 SoC family of devices.
config SPL_CLK_K3_PLL bool "PLL clock support for K3 SoC family of devices" - depends on CLK && LIB_RATIONAL && SPL + depends on CLK && LIB_RATIONAL && SPL && !CLK_TI_SCI help Enables PLL clock support for K3 SoC family of devices.
config CLK_K3 bool "Clock support for K3 SoC family of devices" - depends on CLK + depends on CLK && !CLK_TI_SCI help Enables the clock translation layer from DT to device clocks.
config SPL_CLK_K3 bool "Clock support for K3 SoC family of devices" - depends on CLK && SPL + depends on CLK && SPL && !CLK_TI_SCI help Enables the clock translation layer from DT to device clocks. diff --git a/drivers/power/domain/Kconfig b/drivers/power/domain/Kconfig index 411c210756a3..9625764b304b 100644 --- a/drivers/power/domain/Kconfig +++ b/drivers/power/domain/Kconfig @@ -92,14 +92,14 @@ config TEGRA186_POWER_DOMAIN
config TI_SCI_POWER_DOMAIN bool "Enable the TI SCI-based power domain driver" - depends on POWER_DOMAIN && TI_SCI_PROTOCOL + depends on POWER_DOMAIN && TI_SCI_PROTOCOL && !TI_POWER_DOMAIN help Generic power domain implementation for TI devices implementing the TI SCI protocol.
config TI_POWER_DOMAIN bool "Enable the TI K3 Power domain driver" - depends on POWER_DOMAIN && ARCH_K3 + depends on POWER_DOMAIN && ARCH_K3 && !TI_SCI_POWER_DOMAIN help Generic power domain implementation for TI K3 devices.

Thank you for suggestion Nishanth
On 9/11/2023 6:51 PM, Nishanth Menon wrote:
On 16:49-20230911, Udit Kumar wrote:
[..]
And maybe expand this patch so that it contains something like the following to prevent this from coming back again elsewhere?
diff --git a/drivers/clk/ti/Kconfig b/drivers/clk/ti/Kconfig index fbcdefd889ae..aff1ba5ab43b 100644 --- a/drivers/clk/ti/Kconfig +++ b/drivers/clk/ti/Kconfig @@ -36,7 +36,7 @@ config CLK_TI_MUX
config CLK_TI_SCI bool "TI System Control Interface (TI SCI) clock driver"
- depends on CLK && TI_SCI_PROTOCOL && OF_CONTROL
- depends on CLK && TI_SCI_PROTOCOL && OF_CONTROL && !CLK_K3 help This enables the clock driver support over TI System Control Interface available on some new TI's SoCs. If you wish to use clock resources
@@ -44,24 +44,24 @@ config CLK_TI_SCI
[..]
config CLK_K3 bool "Clock support for K3 SoC family of devices"
- depends on CLK
- depends on CLK && !CLK_TI_SCI help Enables the clock translation layer from DT to device clocks.
I think these may end up recursive dependency
diff --git a/drivers/power/domain/Kconfig b/drivers/power/domain/Kconfig index 411c210756a3..9625764b304b 100644 --- a/drivers/power/domain/Kconfig +++ b/drivers/power/domain/Kconfig @@ -92,14 +92,14 @@ config TEGRA186_POWER_DOMAIN
config TI_SCI_POWER_DOMAIN bool "Enable the TI SCI-based power domain driver"
- depends on POWER_DOMAIN && TI_SCI_PROTOCOL
depends on POWER_DOMAIN && TI_SCI_PROTOCOL && !TI_POWER_DOMAIN help Generic power domain implementation for TI devices implementing the TI SCI protocol.
config TI_POWER_DOMAIN bool "Enable the TI K3 Power domain driver"
- depends on POWER_DOMAIN && ARCH_K3
- depends on POWER_DOMAIN && ARCH_K3 && !TI_SCI_POWER_DOMAIN help Generic power domain implementation for TI K3 devices.
and these too.

On 20:29-20230911, Kumar, Udit wrote:
Thank you for suggestion Nishanth
On 9/11/2023 6:51 PM, Nishanth Menon wrote:
On 16:49-20230911, Udit Kumar wrote:
[..]
And maybe expand this patch so that it contains something like the following to prevent this from coming back again elsewhere?
diff --git a/drivers/clk/ti/Kconfig b/drivers/clk/ti/Kconfig index fbcdefd889ae..aff1ba5ab43b 100644 --- a/drivers/clk/ti/Kconfig +++ b/drivers/clk/ti/Kconfig @@ -36,7 +36,7 @@ config CLK_TI_MUX config CLK_TI_SCI bool "TI System Control Interface (TI SCI) clock driver"
- depends on CLK && TI_SCI_PROTOCOL && OF_CONTROL
- depends on CLK && TI_SCI_PROTOCOL && OF_CONTROL && !CLK_K3 help This enables the clock driver support over TI System Control Interface available on some new TI's SoCs. If you wish to use clock resources
@@ -44,24 +44,24 @@ config CLK_TI_SCI [..] config CLK_K3 bool "Clock support for K3 SoC family of devices"
- depends on CLK
- depends on CLK && !CLK_TI_SCI help Enables the clock translation layer from DT to device clocks.
I think these may end up recursive dependency
Please do the needful, but it is best if the Kconfig enforces this prior to defconfig updates.
diff --git a/drivers/power/domain/Kconfig b/drivers/power/domain/Kconfig index 411c210756a3..9625764b304b 100644 --- a/drivers/power/domain/Kconfig +++ b/drivers/power/domain/Kconfig @@ -92,14 +92,14 @@ config TEGRA186_POWER_DOMAIN config TI_SCI_POWER_DOMAIN bool "Enable the TI SCI-based power domain driver"
- depends on POWER_DOMAIN && TI_SCI_PROTOCOL
- depends on POWER_DOMAIN && TI_SCI_PROTOCOL && !TI_POWER_DOMAIN help Generic power domain implementation for TI devices implementing the TI SCI protocol. config TI_POWER_DOMAIN bool "Enable the TI K3 Power domain driver"
- depends on POWER_DOMAIN && ARCH_K3
- depends on POWER_DOMAIN && ARCH_K3 && !TI_SCI_POWER_DOMAIN help Generic power domain implementation for TI K3 devices.
and these too.
participants (3)
-
Kumar, Udit
-
Nishanth Menon
-
Udit Kumar