Re: [U-Boot] [RFC PATCH 2/2] efi_loader: gop: add support to use cfb_console's framebuffer
2017年2月8日 10:44于 Bin Meng bmeng.cn@gmail.com写道：
On Tue, Feb 7, 2017 at 8:58 PM, Icenowy Zheng icenowy@aosc.xyz wrote:
As cfb_console now can expose its GraphicDevice, use it in the implementation of EFI GOP protocol, so that the graphics framebuffer can be passed to EFI applications.
Signed-off-by: Icenowy Zheng icenowy@aosc.xyz
Tested on an Allwinner H3 board with out-of-tree display support.
cmd/bootefi.c | 2 +- lib/efi_loader/Makefile | 1 + lib/efi_loader/efi_gop.c | 29 ++++++++++++++++++++++++----- 3 files changed, 26 insertions(+), 6 deletions(-)
Instead of adding support on legacy CFB console driver, can we use the DM video driver instead?
Many platforms are still using legacy video_hw_init, and may not have the possibility to get ported...
Regards, Bin
Hi,
On 7 February 2017 at 21:50, Icenowy Zheng icenowy@aosc.xyz wrote:
2017年2月8日 10:44于 Bin Meng bmeng.cn@gmail.com写道：
On Tue, Feb 7, 2017 at 8:58 PM, Icenowy Zheng icenowy@aosc.xyz wrote:
As cfb_console now can expose its GraphicDevice, use it in the implementation of EFI GOP protocol, so that the graphics framebuffer can be passed to EFI applications.
Signed-off-by: Icenowy Zheng icenowy@aosc.xyz
Tested on an Allwinner H3 board with out-of-tree display support.
cmd/bootefi.c | 2 +- lib/efi_loader/Makefile | 1 + lib/efi_loader/efi_gop.c | 29 ++++++++++++++++++++++++----- 3 files changed, 26 insertions(+), 6 deletions(-)
Instead of adding support on legacy CFB console driver, can we use the DM video driver instead?
Many platforms are still using legacy video_hw_init, and may not have the possibility to get ported...
Eventually these boads will be removed if they really don't get converted. But we should not be adding new features to legacy code. It's even worse when it is not added to the new code. How would anyone ever upgrade? The new code becomes a backwater.
So please do this with driver model - ask for help if needed.
Regards, Simon
participants (2)
-
Icenowy Zheng -
Simon Glass