[U-Boot] rockchip: rk3288: grf: FIX the correct gmac tx_delay shift
If the tx_delay is not enabled, the RGMII/1000M can't work.
Signed-off-by: David Wu david.wu@rock-chips.com --- arch/arm/include/asm/arch-rockchip/grf_rk3288.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch-rockchip/grf_rk3288.h b/arch/arm/include/asm/arch-rockchip/grf_rk3288.h index 1a7c819..6e5a947 100644 --- a/arch/arm/include/asm/arch-rockchip/grf_rk3288.h +++ b/arch/arm/include/asm/arch-rockchip/grf_rk3288.h @@ -813,7 +813,7 @@ enum { (1 << RK3288_TXCLK_DLY_ENA_GMAC_SHIFT), RK3288_TXCLK_DLY_ENA_GMAC_DISABLE = 0, RK3288_TXCLK_DLY_ENA_GMAC_ENABLE = - (1 << RK3288_RXCLK_DLY_ENA_GMAC_SHIFT), + (1 << RK3288_TXCLK_DLY_ENA_GMAC_SHIFT),
RK3288_CLK_RX_DL_CFG_GMAC_SHIFT = 0x7, RK3288_CLK_RX_DL_CFG_GMAC_MASK =
Hi David,
On 04/14/2017 05:02 PM, David Wu wrote:
If the tx_delay is not enabled, the RGMII/1000M can't work.
Signed-off-by: David Wu david.wu@rock-chips.com
arch/arm/include/asm/arch-rockchip/grf_rk3288.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch-rockchip/grf_rk3288.h b/arch/arm/include/asm/arch-rockchip/grf_rk3288.h index 1a7c819..6e5a947 100644 --- a/arch/arm/include/asm/arch-rockchip/grf_rk3288.h +++ b/arch/arm/include/asm/arch-rockchip/grf_rk3288.h @@ -813,7 +813,7 @@ enum { (1 << RK3288_TXCLK_DLY_ENA_GMAC_SHIFT), RK3288_TXCLK_DLY_ENA_GMAC_DISABLE = 0, RK3288_TXCLK_DLY_ENA_GMAC_ENABLE =
(1 << RK3288_RXCLK_DLY_ENA_GMAC_SHIFT),
(1 << RK3288_TXCLK_DLY_ENA_GMAC_SHIFT),RK3288_CLK_RX_DL_CFG_GMAC_SHIFT = 0x7, RK3288_CLK_RX_DL_CFG_GMAC_MASK =
Reviewed-by: Kever Yang kever.yang@rock-chips.com
Thanks, - Kever
On 14 Apr 2017, at 11:02, David Wu david.wu@rock-chips.com wrote:
If the tx_delay is not enabled, the RGMII/1000M can't work.
Signed-off-by: David Wu david.wu@rock-chips.com
arch/arm/include/asm/arch-rockchip/grf_rk3288.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch-rockchip/grf_rk3288.h b/arch/arm/include/asm/arch-rockchip/grf_rk3288.h index 1a7c819..6e5a947 100644 --- a/arch/arm/include/asm/arch-rockchip/grf_rk3288.h +++ b/arch/arm/include/asm/arch-rockchip/grf_rk3288.h @@ -813,7 +813,7 @@ enum { (1 << RK3288_TXCLK_DLY_ENA_GMAC_SHIFT), RK3288_TXCLK_DLY_ENA_GMAC_DISABLE = 0, RK3288_TXCLK_DLY_ENA_GMAC_ENABLE =
(1 << RK3288_RXCLK_DLY_ENA_GMAC_SHIFT),
(1 << RK3288_TXCLK_DLY_ENA_GMAC_SHIFT),RK3288_CLK_RX_DL_CFG_GMAC_SHIFT = 0x7, RK3288_CLK_RX_DL_CFG_GMAC_MASK =
-- 1.9.1
Reviewed-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
On 14 April 2017 at 03:24, Dr. Philipp Tomsich philipp.tomsich@theobroma-systems.com wrote:
On 14 Apr 2017, at 11:02, David Wu david.wu@rock-chips.com wrote:
If the tx_delay is not enabled, the RGMII/1000M can't work.
Signed-off-by: David Wu david.wu@rock-chips.com
arch/arm/include/asm/arch-rockchip/grf_rk3288.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch-rockchip/grf_rk3288.h b/arch/arm/include/asm/arch-rockchip/grf_rk3288.h index 1a7c819..6e5a947 100644 --- a/arch/arm/include/asm/arch-rockchip/grf_rk3288.h +++ b/arch/arm/include/asm/arch-rockchip/grf_rk3288.h @@ -813,7 +813,7 @@ enum { (1 << RK3288_TXCLK_DLY_ENA_GMAC_SHIFT), RK3288_TXCLK_DLY_ENA_GMAC_DISABLE = 0, RK3288_TXCLK_DLY_ENA_GMAC_ENABLE =
(1 << RK3288_RXCLK_DLY_ENA_GMAC_SHIFT),
(1 << RK3288_TXCLK_DLY_ENA_GMAC_SHIFT), RK3288_CLK_RX_DL_CFG_GMAC_SHIFT = 0x7, RK3288_CLK_RX_DL_CFG_GMAC_MASK =-- 1.9.1
Reviewed-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
Acked-by: Simon Glass sjg@chromium.org
participants (4)
-
David Wu -
Dr. Philipp Tomsich -
Kever Yang -
Simon Glass