Dear Wolfgang Denk,

...

This patch supports OneNAND device on U-Boot. The most codes are based on OneNAND MTD in kernel.

Your patches have a few cosing style issues (indentation not by TAB's, trailing white space). Please clean up and resubmet; see also http://www.denx.de/wiki/UBoot/CodingStyle

Thank you, I use the 'indent' programe to fix indentation

Also, please restrict your line length no around 70 characters or so.

Since its code based on kernel and consistent with kernel. it has almost same syntax.

And can you please add a GPL license header to onenand/onenand_bbt.c, include/linux/mtd/bbm.h

I added it.

...

For better performance I added 32-bytes aligned memcpy32. Pleae check it.

Did you measure how much of performance this gains? Is it really worth the effort? In any case, the file needs a GPL license header.

we can feel that it's more faster than before. OK I added GPL license

Thank you, Kyungmin Park

...

...

Also, please restrict your line length no around 70

characters or so.

...

Since its code based on kernel and consistent with kernel. it has almost same syntax.

So what?

To maintain easily. as mentioned it's the first version of OneNAND driver in kernel. it's code is almost same in kernel 2.6.15. After release I changed a lots of code. I will update it for OneNAND on U- Boot.

Indentation not by TABs, trailing white space.

I changed it using 's/^ /^ /g', 's/ $/$/g'.

...

...

...

For better performance I added 32-bytes aligned memcpy32. Pleae check it.

Did you measure how much of performance this gains? Is it really worth the effort? In any case, the file needs a

GPL license

...

...

header.

we can feel that it's more faster than before. OK I added

GPL license

How much? 5%? 20%? 50%?

Architecture optimized copy is fast about 3 times in OMAP 16xx series (ARM 9 core) in U-Boot

Here's test results memory copy (Unit: nsec) 96 MHz 192 MHz unsigned long * 189,440 ~ 192,000 158,720 ~ 160,000 architecture optimized copy 56,320 ~ 58,880 53,760 ~ 55, 040

where increment time is 2560 nsec in 96 MHz and 1280 nsec in 192 MHz

Thank you, Kyungmin Park

...

...

Indentation not by TABs, trailing white space.

I changed it using 's/^ /^ /g', 's/ $/$/g'.

Which is definitely not good enough.

...

Architecture optimized copy is fast about 3 times in OMAP

16xx series

...

(ARM 9 core) in U-Boot

OK. Will the code work for non-ARM architectures?

Maybe not. I'm not famiar with other architectures. Now most boards which use OneNAND are ARM Arch. so I only consider it. Sorry. We have to consider other architetures.

We can only use it in ARM by adding __ARM__ definition in onenand_base.c, otherwise use its own memcpy

+#ifdef __ARM__ extern void memcpy32(void *, void *, size_t);

static void *memcpy(void *dest, const void *src, size_t count) { if (count < 32) { unsigned short *_s = (unsigned short *) (src); unsigned short *_d = (unsigned short *) (dest); count >>= 1; while (count--) *_d++ = *_s++; return _d; }

memcpy32(dest, src, count);

return (void *) count; } +#endif

Thank you, Kyungmin Park