[U-Boot] [PATCH] titanium: Return the error when cpu_eth_init() fails

From: Fabio Estevam fabio.estevam@freescale.com
When cpu_eth_init() fails we should not return success.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- board/freescale/titanium/titanium.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/freescale/titanium/titanium.c b/board/freescale/titanium/titanium.c index 6025eb7..9a317bc 100644 --- a/board/freescale/titanium/titanium.c +++ b/board/freescale/titanium/titanium.c @@ -272,7 +272,7 @@ int board_eth_init(bd_t *bis) if (ret) printf("FEC MXC: %s:failed\n", __func__);
- return 0; + return ret; }
int board_early_init_f(void)

Hi Fabio,
On 04.11.2013 01:12, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
When cpu_eth_init() fails we should not return success.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
board/freescale/titanium/titanium.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/freescale/titanium/titanium.c b/board/freescale/titanium/titanium.c index 6025eb7..9a317bc 100644 --- a/board/freescale/titanium/titanium.c +++ b/board/freescale/titanium/titanium.c @@ -272,7 +272,7 @@ int board_eth_init(bd_t *bis) if (ret) printf("FEC MXC: %s:failed\n", __func__);
- return 0;
- return ret;
}
int board_early_init_f(void)
Thanks.
Acked-by: Stefan Roese sr@denx.de
Thanks, Stefan

On 04/11/2013 01:12, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
When cpu_eth_init() fails we should not return success.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Applied to u-boot-imx, thanks.
Best regards, Stefano Babic
participants (3)
-
Fabio Estevam
-
Stefan Roese
-
Stefano Babic