[U-Boot] [PATCH v2] Makefile: Fix linking with modern binutils
Since Binutils 1a9ccd70f9a7[1] u-boot will not link targets that set CONFIG_SYS_TEXT_BASE=0 with the following error:
LD u-boot arm-linux-gnueabi-ld.bfd: u-boot: Not enough room for program headers, try linking with -N arm-linux-gnueabi-ld.bfd: final link failed: Bad value
The issue can reproduced the bad binutils and the rock2_defconfig target.
This issue was also encountered by the powerpc kernel[2], with the fix being to pass --no-dynamic-linker for linkers newer than 2.26 when this flag was introduced. The option tells ld that the PIE or shared lib does not need loaded program headers.
Ubuntu Zesty's Binutils 2.27.51.20161202 hits this error.
[1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=1a9ccd70... [2] https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/commit/?h=nex...
Signed-off-by: Joel Stanley joel@jms.id.au --- v2: - use ld-option to test for the flag instead of the version, as suggested by Måns - update commit message with clarification from Alan
Makefile | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/Makefile b/Makefile index dfed58bec661..c98a8361654a 100644 --- a/Makefile +++ b/Makefile @@ -793,6 +793,10 @@ ALL-y += $(CONFIG_BUILD_TARGET:"%"=%) endif
LDFLAGS_u-boot += $(LDFLAGS_FINAL) + +# Avoid 'Not enough room for program headers' error on binutils 2.28 onwards. +LDFLAGS_u-boot += $(call ld-option, --no-dynamic-linker) + ifneq ($(CONFIG_SYS_TEXT_BASE),) LDFLAGS_u-boot += -Ttext $(CONFIG_SYS_TEXT_BASE) endif
On Fri, Dec 16, 2016 at 03:23:30PM +1030, Joel Stanley wrote:
Since Binutils 1a9ccd70f9a7[1] u-boot will not link targets that set CONFIG_SYS_TEXT_BASE=0 with the following error:
LD u-boot arm-linux-gnueabi-ld.bfd: u-boot: Not enough room for program headers, try linking with -N arm-linux-gnueabi-ld.bfd: final link failed: Bad value
The issue can reproduced the bad binutils and the rock2_defconfig target.
This issue was also encountered by the powerpc kernel[2], with the fix being to pass --no-dynamic-linker for linkers newer than 2.26 when this flag was introduced. The option tells ld that the PIE or shared lib does not need loaded program headers.
Ubuntu Zesty's Binutils 2.27.51.20161202 hits this error.
[1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=1a9ccd70... [2] https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/commit/?h=nex...
Signed-off-by: Joel Stanley joel@jms.id.au
v2:
- use ld-option to test for the flag instead of the version, as suggested by Måns
- update commit message with clarification from Alan
Makefile | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/Makefile b/Makefile index dfed58bec661..c98a8361654a 100644 --- a/Makefile +++ b/Makefile @@ -793,6 +793,10 @@ ALL-y += $(CONFIG_BUILD_TARGET:"%"=%) endif
LDFLAGS_u-boot += $(LDFLAGS_FINAL)
+# Avoid 'Not enough room for program headers' error on binutils 2.28 onwards. +LDFLAGS_u-boot += $(call ld-option, --no-dynamic-linker)
ifneq ($(CONFIG_SYS_TEXT_BASE),) LDFLAGS_u-boot += -Ttext $(CONFIG_SYS_TEXT_BASE) endif
I had to think about this a bit and poke around. I think we need to be adjusting LDFLAGS_$(SPL_BIN) in scripts/Makefile.spl for safety here as well since if CONFIG_SPL_TEXT_BASE=0 (which seems just as possible as CONFIG_SYS_TEXT_BASE=0) we would hit the same condition. Thanks!
Tested on current Debian unstable: GNU ld (GNU Binutils for Debian) 2.27.90.20170109
Tested-by: Sjoerd Simons sjoerd.simons@collabora.co.uk
On Fri, 2016-12-16 at 15:23 +1030, Joel Stanley wrote:
Since Binutils 1a9ccd70f9a7[1] u-boot will not link targets that set CONFIG_SYS_TEXT_BASE=0 with the following error:
LD u-boot arm-linux-gnueabi-ld.bfd: u-boot: Not enough room for program headers, try linking with -N arm-linux-gnueabi-ld.bfd: final link failed: Bad value
The issue can reproduced the bad binutils and the rock2_defconfig target.
This issue was also encountered by the powerpc kernel[2], with the fix being to pass --no-dynamic-linker for linkers newer than 2.26 when this flag was introduced. The option tells ld that the PIE or shared lib does not need loaded program headers.
Ubuntu Zesty's Binutils 2.27.51.20161202 hits this error.
[1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit ;h=1a9ccd70f9a7 [2] https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/co mmit/?h=next&id=ff45000fcb56b5b0f1a14a865d3541746d838a0a
Signed-off-by: Joel Stanley joel@jms.id.au
v2: - use ld-option to test for the flag instead of the version, as suggested by Måns - update commit message with clarification from Alan
Makefile | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/Makefile b/Makefile index dfed58bec661..c98a8361654a 100644 --- a/Makefile +++ b/Makefile @@ -793,6 +793,10 @@ ALL-y += $(CONFIG_BUILD_TARGET:"%"=%) endif LDFLAGS_u-boot += $(LDFLAGS_FINAL)
+# Avoid 'Not enough room for program headers' error on binutils 2.28 onwards. +LDFLAGS_u-boot += $(call ld-option, --no-dynamic-linker)
ifneq ($(CONFIG_SYS_TEXT_BASE),) LDFLAGS_u-boot += -Ttext $(CONFIG_SYS_TEXT_BASE) endif
Likewise tested on Fedora rawhide with: binutils-2.28-5.fc27
This patch allows our distro u-boot builds to succeed. +1
Tested-by: Jon Disnard jdisnard@gmail.com
On Thu, Jan 12, 2017 at 3:19 AM, Sjoerd Simons sjoerd.simons@collabora.co.uk wrote:
Tested on current Debian unstable: GNU ld (GNU Binutils for Debian) 2.27.90.20170109
Tested-by: Sjoerd Simons sjoerd.simons@collabora.co.uk
On Fri, 2016-12-16 at 15:23 +1030, Joel Stanley wrote:
Since Binutils 1a9ccd70f9a7[1] u-boot will not link targets that set CONFIG_SYS_TEXT_BASE=0 with the following error:
LD u-boot arm-linux-gnueabi-ld.bfd: u-boot: Not enough room for program headers, try linking with -N arm-linux-gnueabi-ld.bfd: final link failed: Bad value
The issue can reproduced the bad binutils and the rock2_defconfig target.
This issue was also encountered by the powerpc kernel[2], with the fix being to pass --no-dynamic-linker for linkers newer than 2.26 when this flag was introduced. The option tells ld that the PIE or shared lib does not need loaded program headers.
Ubuntu Zesty's Binutils 2.27.51.20161202 hits this error.
[1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit ;h=1a9ccd70f9a7 [2] https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/co mmit/?h=next&id=ff45000fcb56b5b0f1a14a865d3541746d838a0a
Signed-off-by: Joel Stanley joel@jms.id.au
v2:
- use ld-option to test for the flag instead of the version, as
suggested by Måns
- update commit message with clarification from Alan
Makefile | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/Makefile b/Makefile index dfed58bec661..c98a8361654a 100644 --- a/Makefile +++ b/Makefile @@ -793,6 +793,10 @@ ALL-y += $(CONFIG_BUILD_TARGET:"%"=%) endif
LDFLAGS_u-boot += $(LDFLAGS_FINAL)
+# Avoid 'Not enough room for program headers' error on binutils 2.28 onwards. +LDFLAGS_u-boot += $(call ld-option, --no-dynamic-linker)
ifneq ($(CONFIG_SYS_TEXT_BASE),) LDFLAGS_u-boot += -Ttext $(CONFIG_SYS_TEXT_BASE) endif
-- Sjoerd Simons Collabora Ltd. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
On Tue, Mar 21, 2017 at 08:59:04AM -0500, Jon wrote:
Likewise tested on Fedora rawhide with: binutils-2.28-5.fc27
This patch allows our distro u-boot builds to succeed. +1
Tested-by: Jon Disnard jdisnard@gmail.com
Has anyone figure out what exactly is going on yet? It's pretty odd to me that linking at 0x0 (or not) is what's causing new binutils to throw this particular error out there. Thanks!
On Thu, Jan 12, 2017 at 3:19 AM, Sjoerd Simons sjoerd.simons@collabora.co.uk wrote:
Tested on current Debian unstable: GNU ld (GNU Binutils for Debian) 2.27.90.20170109
Tested-by: Sjoerd Simons sjoerd.simons@collabora.co.uk
On Fri, 2016-12-16 at 15:23 +1030, Joel Stanley wrote:
Since Binutils 1a9ccd70f9a7[1] u-boot will not link targets that set CONFIG_SYS_TEXT_BASE=0 with the following error:
LD u-boot arm-linux-gnueabi-ld.bfd: u-boot: Not enough room for program headers, try linking with -N arm-linux-gnueabi-ld.bfd: final link failed: Bad value
The issue can reproduced the bad binutils and the rock2_defconfig target.
This issue was also encountered by the powerpc kernel[2], with the fix being to pass --no-dynamic-linker for linkers newer than 2.26 when this flag was introduced. The option tells ld that the PIE or shared lib does not need loaded program headers.
Ubuntu Zesty's Binutils 2.27.51.20161202 hits this error.
[1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit ;h=1a9ccd70f9a7 [2] https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/co mmit/?h=next&id=ff45000fcb56b5b0f1a14a865d3541746d838a0a
Signed-off-by: Joel Stanley joel@jms.id.au
v2:
- use ld-option to test for the flag instead of the version, as
suggested by Måns
- update commit message with clarification from Alan
Makefile | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/Makefile b/Makefile index dfed58bec661..c98a8361654a 100644 --- a/Makefile +++ b/Makefile @@ -793,6 +793,10 @@ ALL-y += $(CONFIG_BUILD_TARGET:"%"=%) endif
LDFLAGS_u-boot += $(LDFLAGS_FINAL)
+# Avoid 'Not enough room for program headers' error on binutils 2.28 onwards. +LDFLAGS_u-boot += $(call ld-option, --no-dynamic-linker)
ifneq ($(CONFIG_SYS_TEXT_BASE),) LDFLAGS_u-boot += -Ttext $(CONFIG_SYS_TEXT_BASE) endif
-- Sjoerd Simons Collabora Ltd. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
--
-Jon Disnard _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
On Tue, 21 Mar 2017 11:16:50 -0400 Tom Rini trini@konsulko.com wrote:
On Tue, Mar 21, 2017 at 08:59:04AM -0500, Jon wrote:
Likewise tested on Fedora rawhide with: binutils-2.28-5.fc27
This patch allows our distro u-boot builds to succeed. +1
Tested-by: Jon Disnard jdisnard@gmail.com
Has anyone figure out what exactly is going on yet? It's pretty odd to me that linking at 0x0 (or not) is what's causing new binutils to throw this particular error out there. Thanks!
Some discussion from binutils developers is here:
On Wed, Mar 22, 2017 at 09:00:58AM +1000, Nicholas Piggin wrote:
On Tue, 21 Mar 2017 11:16:50 -0400 Tom Rini trini@konsulko.com wrote:
On Tue, Mar 21, 2017 at 08:59:04AM -0500, Jon wrote:
Likewise tested on Fedora rawhide with: binutils-2.28-5.fc27
This patch allows our distro u-boot builds to succeed. +1
Tested-by: Jon Disnard jdisnard@gmail.com
Has anyone figure out what exactly is going on yet? It's pretty odd to me that linking at 0x0 (or not) is what's causing new binutils to throw this particular error out there. Thanks!
Some discussion from binutils developers is here:
That in turn seems to point to https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id... as an example of how to correct the problem (what U-Boot is doing), and we should make a patch similar to that it seems. Thanks!
On Tue, Mar 21, 2017 at 07:13:44PM -0400, Tom Rini wrote:
On Wed, Mar 22, 2017 at 09:00:58AM +1000, Nicholas Piggin wrote:
On Tue, 21 Mar 2017 11:16:50 -0400 Tom Rini trini@konsulko.com wrote:
On Tue, Mar 21, 2017 at 08:59:04AM -0500, Jon wrote:
Likewise tested on Fedora rawhide with: binutils-2.28-5.fc27
This patch allows our distro u-boot builds to succeed. +1
Tested-by: Jon Disnard jdisnard@gmail.com
Has anyone figure out what exactly is going on yet? It's pretty odd to me that linking at 0x0 (or not) is what's causing new binutils to throw this particular error out there. Thanks!
Some discussion from binutils developers is here:
That in turn seems to point to https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id... as an example of how to correct the problem (what U-Boot is doing), and we should make a patch similar to that it seems. Thanks!
That is the correct solution. Nick's patch for https://sourceware.org/bugzilla/show_bug.cgi?id=20815 isn't going to be reverted as the ELF standard is quite clear regarding PT_PHDR. Yes, there was a bug in the patch adding more space than needed, fixed 2016-11-30 with binutils git commit e9a38e0f528, but even after that patch more space is needed than before.
participants (6)
-
Alan Modra -
Joel Stanley -
Jon -
Nicholas Piggin -
Sjoerd Simons -
Tom Rini