[U-Boot] [PATCH 1/2] mmc: sh_mmcif: Fix compile error

BY commit "mmc: Split mmc struct, rework mmc initialization (v2)", sh_mmcif has compile error. This fixes compile error.
Signed-off-by: Nobuhiro Iwamatsu nobuhiro.iwamatsu.yj@renesas.com CC: Pantelis Antoniou panto@antoniou-consulting.com Reported-by: Masahiro Yamada yamada.m@jp.panasonic.com --- drivers/mmc/sh_mmcif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/sh_mmcif.c b/drivers/mmc/sh_mmcif.c index 64b5b47..ad5b23c 100644 --- a/drivers/mmc/sh_mmcif.c +++ b/drivers/mmc/sh_mmcif.c @@ -580,7 +580,7 @@ static struct mmc_config sh_mmcif_cfg = { .ops = &sh_mmcif_ops, .host_caps = MMC_MODE_HS | MMC_MODE_HS_52MHz | MMC_MODE_4BIT | MMC_MODE_8BIT | MMC_MODE_HC, - .voltages = MMC_VDD_32_33 | MMC_VDD_33_34; + .voltages = MMC_VDD_32_33 | MMC_VDD_33_34, .f_min = CLKDEV_MMC_INIT, .f_max = CLKDEV_EMMC_DATA, .b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT,

Signed-off-by: Nobuhiro Iwamatsu nobuhiro.iwamatsu.yj@renesas.com Reported-by: Masahiro Yamada yamada.m@jp.panasonic.com --- drivers/mmc/sh_mmcif.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mmc/sh_mmcif.c b/drivers/mmc/sh_mmcif.c index ad5b23c..ed83a14 100644 --- a/drivers/mmc/sh_mmcif.c +++ b/drivers/mmc/sh_mmcif.c @@ -588,13 +588,12 @@ static struct mmc_config sh_mmcif_cfg = {
int mmcif_mmc_init(void) { - int ret = 0; struct mmc *mmc; struct sh_mmcif_host *host = NULL;
host = malloc(sizeof(struct sh_mmcif_host)); if (!host) - ret = -ENOMEM; + return -ENOMEM; memset(host, 0, sizeof(*host));
host->regs = (struct sh_mmcif_regs *)CONFIG_SH_MMCIF_ADDR;

Hi Nobuhiro,
Thanks for catching this.
On Mar 31, 2014, at 8:54 AM, Nobuhiro Iwamatsu wrote:
Signed-off-by: Nobuhiro Iwamatsu nobuhiro.iwamatsu.yj@renesas.com Reported-by: Masahiro Yamada yamada.m@jp.panasonic.com
drivers/mmc/sh_mmcif.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mmc/sh_mmcif.c b/drivers/mmc/sh_mmcif.c index ad5b23c..ed83a14 100644 --- a/drivers/mmc/sh_mmcif.c +++ b/drivers/mmc/sh_mmcif.c @@ -588,13 +588,12 @@ static struct mmc_config sh_mmcif_cfg = {
int mmcif_mmc_init(void) {
int ret = 0; struct mmc *mmc; struct sh_mmcif_host *host = NULL;
host = malloc(sizeof(struct sh_mmcif_host)); if (!host)
ret = -ENOMEM;
return -ENOMEM;
memset(host, 0, sizeof(*host));
host->regs = (struct sh_mmcif_regs *)CONFIG_SH_MMCIF_ADDR;
-- 1.9.1
Acked-by: Pantelis Antoniou panto@antoniou-consulting.com

Hi Nobuhiro,
Thank you for catching this.
On Mar 31, 2014, at 8:54 AM, Nobuhiro Iwamatsu wrote:
BY commit "mmc: Split mmc struct, rework mmc initialization (v2)", sh_mmcif has compile error. This fixes compile error.
Signed-off-by: Nobuhiro Iwamatsu nobuhiro.iwamatsu.yj@renesas.com CC: Pantelis Antoniou panto@antoniou-consulting.com Reported-by: Masahiro Yamada yamada.m@jp.panasonic.com
drivers/mmc/sh_mmcif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/sh_mmcif.c b/drivers/mmc/sh_mmcif.c index 64b5b47..ad5b23c 100644 --- a/drivers/mmc/sh_mmcif.c +++ b/drivers/mmc/sh_mmcif.c @@ -580,7 +580,7 @@ static struct mmc_config sh_mmcif_cfg = { .ops = &sh_mmcif_ops, .host_caps = MMC_MODE_HS | MMC_MODE_HS_52MHz | MMC_MODE_4BIT | MMC_MODE_8BIT | MMC_MODE_HC,
- .voltages = MMC_VDD_32_33 | MMC_VDD_33_34;
- .voltages = MMC_VDD_32_33 | MMC_VDD_33_34, .f_min = CLKDEV_MMC_INIT, .f_max = CLKDEV_EMMC_DATA, .b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT,
-- 1.9.1
Thanks
Acked-by: Pantelis Antoniou panto@antoniou-consulting.com

Hi!
Thanks for your Acked-by. These are part of the MMC, I want to fetch in into your repository. And could you send PR to Tom?
Best regards, Nobuhiro
2014-03-31 15:45 GMT+09:00 Pantelis Antoniou panto@antoniou-consulting.com:
Hi Nobuhiro,
Thank you for catching this.
On Mar 31, 2014, at 8:54 AM, Nobuhiro Iwamatsu wrote:
BY commit "mmc: Split mmc struct, rework mmc initialization (v2)", sh_mmcif has compile error. This fixes compile error.
Signed-off-by: Nobuhiro Iwamatsu nobuhiro.iwamatsu.yj@renesas.com CC: Pantelis Antoniou panto@antoniou-consulting.com Reported-by: Masahiro Yamada yamada.m@jp.panasonic.com
drivers/mmc/sh_mmcif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/sh_mmcif.c b/drivers/mmc/sh_mmcif.c index 64b5b47..ad5b23c 100644 --- a/drivers/mmc/sh_mmcif.c +++ b/drivers/mmc/sh_mmcif.c @@ -580,7 +580,7 @@ static struct mmc_config sh_mmcif_cfg = { .ops = &sh_mmcif_ops, .host_caps = MMC_MODE_HS | MMC_MODE_HS_52MHz | MMC_MODE_4BIT | MMC_MODE_8BIT | MMC_MODE_HC,
.voltages = MMC_VDD_32_33 | MMC_VDD_33_34;
.voltages = MMC_VDD_32_33 | MMC_VDD_33_34, .f_min = CLKDEV_MMC_INIT, .f_max = CLKDEV_EMMC_DATA, .b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT,
-- 1.9.1
Thanks
Acked-by: Pantelis Antoniou panto@antoniou-consulting.com
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Hi Nobuhiro,
Will be part of the next PR to Tom.
Regards
-- Pantelis
On Mar 31, 2014, at 10:06 AM, Nobuhiro Iwamatsu wrote:
Hi!
Thanks for your Acked-by. These are part of the MMC, I want to fetch in into your repository. And could you send PR to Tom?
Best regards, Nobuhiro
2014-03-31 15:45 GMT+09:00 Pantelis Antoniou panto@antoniou-consulting.com:
Hi Nobuhiro,
Thank you for catching this.
On Mar 31, 2014, at 8:54 AM, Nobuhiro Iwamatsu wrote:
BY commit "mmc: Split mmc struct, rework mmc initialization (v2)", sh_mmcif has compile error. This fixes compile error.
Signed-off-by: Nobuhiro Iwamatsu nobuhiro.iwamatsu.yj@renesas.com CC: Pantelis Antoniou panto@antoniou-consulting.com Reported-by: Masahiro Yamada yamada.m@jp.panasonic.com
drivers/mmc/sh_mmcif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/sh_mmcif.c b/drivers/mmc/sh_mmcif.c index 64b5b47..ad5b23c 100644 --- a/drivers/mmc/sh_mmcif.c +++ b/drivers/mmc/sh_mmcif.c @@ -580,7 +580,7 @@ static struct mmc_config sh_mmcif_cfg = { .ops = &sh_mmcif_ops, .host_caps = MMC_MODE_HS | MMC_MODE_HS_52MHz | MMC_MODE_4BIT | MMC_MODE_8BIT | MMC_MODE_HC,
.voltages = MMC_VDD_32_33 | MMC_VDD_33_34;
.f_min = CLKDEV_MMC_INIT, .f_max = CLKDEV_EMMC_DATA, .b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT,.voltages = MMC_VDD_32_33 | MMC_VDD_33_34,
-- 1.9.1
Thanks
Acked-by: Pantelis Antoniou panto@antoniou-consulting.com
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
-- Nobuhiro Iwamatsu
participants (2)
-
Nobuhiro Iwamatsu
-
Pantelis Antoniou