[U-Boot] [PATCH 1/3] ARM: Don't grab memory for LCD if FB address is defined
If FB address is defined specific address then don't grab memory for LCD
Signed-off-by: Minkyu Kang mk7.kang@samsung.com Cc: Albert Aribaud albert.aribaud@free.fr --- arch/arm/lib/board.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index c620d2c..5a4d2bd 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -356,9 +356,13 @@ void board_init_f (ulong bootflag) #endif /* CONFIG_VFD */
#ifdef CONFIG_LCD +#ifdef CONFIG_FB_ADDR + gd->fb_base = CONFIG_FB_ADDR; +#else /* reserve memory for LCD display (always full pages) */ addr = lcd_setmem (addr); gd->fb_base = addr; +#endif /* CONFIG_FB_ADDR */ #endif /* CONFIG_LCD */
/*
Dear Minkyu Kang,
In message 4D75B591.3040605@samsung.com you wrote:
If FB address is defined specific address then don't grab memory for LCD
Signed-off-by: Minkyu Kang mk7.kang@samsung.com Cc: Albert Aribaud albert.aribaud@free.fr
arch/arm/lib/board.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index c620d2c..5a4d2bd 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -356,9 +356,13 @@ void board_init_f (ulong bootflag) #endif /* CONFIG_VFD */
#ifdef CONFIG_LCD +#ifdef CONFIG_FB_ADDR
If you add a new CONFIG_ option, then you must document it (at least in the README).
Also, you must not split this into several patches, one for each architecture. All these changes must be done in a single commit.
Best regards,
Wolfgang Denk
Dear Wolfgang,
On 14 March 2011 04:50, Wolfgang Denk wd@denx.de wrote:
Dear Minkyu Kang,
In message 4D75B591.3040605@samsung.com you wrote:
If FB address is defined specific address then don't grab memory for LCD
Signed-off-by: Minkyu Kang mk7.kang@samsung.com Cc: Albert Aribaud albert.aribaud@free.fr
arch/arm/lib/board.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index c620d2c..5a4d2bd 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -356,9 +356,13 @@ void board_init_f (ulong bootflag) #endif /* CONFIG_VFD */
#ifdef CONFIG_LCD +#ifdef CONFIG_FB_ADDR
If you add a new CONFIG_ option, then you must document it (at least in the README).
Also, you must not split this into several patches, one for each architecture. All these changes must be done in a single commit.
OK, I will.
Thanks Minkyu Kang
f FB address is defined specific address then don't grab memory for LCD
Signed-off-by: Minkyu Kang mk7.kang@samsung.com Cc: Albert Aribaud albert.aribaud@free.fr Cc: Wolfgang Denk wd@denx.de Cc: Stefan Roese sr@denx.de Cc: Kim Phillips kim.phillips@freescale.com Cc: Andy Fleming afleming@gmail.com Cc: Kumar Gala kumar.gala@freescale.com --- v2 add document
arch/arm/lib/board.c | 4 ++++ arch/m68k/lib/board.c | 4 ++++ arch/powerpc/lib/board.c | 4 ++++ doc/README.fb_addr | 17 +++++++++++++++++ 4 files changed, 29 insertions(+), 0 deletions(-) create mode 100644 doc/README.fb_addr
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index c620d2c..5a4d2bd 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -356,9 +356,13 @@ void board_init_f (ulong bootflag) #endif /* CONFIG_VFD */
#ifdef CONFIG_LCD +#ifdef CONFIG_FB_ADDR + gd->fb_base = CONFIG_FB_ADDR; +#else /* reserve memory for LCD display (always full pages) */ addr = lcd_setmem (addr); gd->fb_base = addr; +#endif /* CONFIG_FB_ADDR */ #endif /* CONFIG_LCD */
/* diff --git a/arch/m68k/lib/board.c b/arch/m68k/lib/board.c index 7867ba5..a6cd9b8 100644 --- a/arch/m68k/lib/board.c +++ b/arch/m68k/lib/board.c @@ -277,9 +277,13 @@ board_init_f (ulong bootflag) debug ("Top of RAM usable for U-Boot at: %08lx\n", addr);
#ifdef CONFIG_LCD +#ifdef CONFIG_FB_ADDR + gd->fb_base = CONFIG_FB_ADDR; +#else /* reserve memory for LCD display (always full pages) */ addr = lcd_setmem (addr); gd->fb_base = addr; +#endif /* CONFIG_FB_ADDR */ #endif /* CONFIG_LCD */
/* diff --git a/arch/powerpc/lib/board.c b/arch/powerpc/lib/board.c index b88cf6b..09c20e9 100644 --- a/arch/powerpc/lib/board.c +++ b/arch/powerpc/lib/board.c @@ -453,9 +453,13 @@ void board_init_f (ulong bootflag) debug ("Top of RAM usable for U-Boot at: %08lx\n", addr);
#ifdef CONFIG_LCD +#ifdef CONFIG_FB_ADDR + gd->fb_base = CONFIG_FB_ADDR; +#else /* reserve memory for LCD display (always full pages) */ addr = lcd_setmem (addr); gd->fb_base = addr; +#endif /* CONFIG_FB_ADDR */ #endif /* CONFIG_LCD */
#if defined(CONFIG_VIDEO) && defined(CONFIG_8xx) diff --git a/doc/README.fb_addr b/doc/README.fb_addr new file mode 100644 index 0000000..ea8bca6 --- /dev/null +++ b/doc/README.fb_addr @@ -0,0 +1,17 @@ +Define CONFIG_FB_ADDR if you want to use specific address for frame buffer. +Then system will reserve the frame buffer address to defined address instead of +lcd_setmem (this function grab the memory for frame buffer by panel's size). + +Please see below code (in board_init_f function from arch/arm/lib/board.c) + +#ifdef CONFIG_FB_ADDR + gd->fb_base = CONFIG_FB_ADDR; +#else + /* reserve memory for LCD display (always full pages) */ + addr = lcd_setmem (addr); + gd->fb_base = addr; +#endif /* CONFIG_FB_ADDR */ + +If you want this config option then please define it at your board config file + +#define CONFIG_FB_ADDR 0x00000000
Hi Minkyu Kang,
Le 15/03/2011 09:35, Minkyu Kang a écrit :
f FB address is defined specific address then don't grab memory for LCD
Signed-off-by: Minkyu Kangmk7.kang@samsung.com Cc: Albert Aribaudalbert.aribaud@free.fr Cc: Wolfgang Denkwd@denx.de Cc: Stefan Roesesr@denx.de Cc: Kim Phillipskim.phillips@freescale.com Cc: Andy Flemingafleming@gmail.com Cc: Kumar Galakumar.gala@freescale.com
v2 add document
arch/arm/lib/board.c | 4 ++++ arch/m68k/lib/board.c | 4 ++++ arch/powerpc/lib/board.c | 4 ++++ doc/README.fb_addr | 17 +++++++++++++++++ 4 files changed, 29 insertions(+), 0 deletions(-) create mode 100644 doc/README.fb_addr
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index c620d2c..5a4d2bd 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -356,9 +356,13 @@ void board_init_f (ulong bootflag) #endif /* CONFIG_VFD */
#ifdef CONFIG_LCD +#ifdef CONFIG_FB_ADDR
- gd->fb_base = CONFIG_FB_ADDR;
+#else /* reserve memory for LCD display (always full pages) */ addr = lcd_setmem (addr); gd->fb_base = addr; +#endif /* CONFIG_FB_ADDR */ #endif /* CONFIG_LCD */
/* diff --git a/arch/m68k/lib/board.c b/arch/m68k/lib/board.c index 7867ba5..a6cd9b8 100644 --- a/arch/m68k/lib/board.c +++ b/arch/m68k/lib/board.c @@ -277,9 +277,13 @@ board_init_f (ulong bootflag) debug ("Top of RAM usable for U-Boot at: %08lx\n", addr);
#ifdef CONFIG_LCD +#ifdef CONFIG_FB_ADDR
- gd->fb_base = CONFIG_FB_ADDR;
+#else /* reserve memory for LCD display (always full pages) */ addr = lcd_setmem (addr); gd->fb_base = addr; +#endif /* CONFIG_FB_ADDR */ #endif /* CONFIG_LCD */
/* diff --git a/arch/powerpc/lib/board.c b/arch/powerpc/lib/board.c index b88cf6b..09c20e9 100644 --- a/arch/powerpc/lib/board.c +++ b/arch/powerpc/lib/board.c @@ -453,9 +453,13 @@ void board_init_f (ulong bootflag) debug ("Top of RAM usable for U-Boot at: %08lx\n", addr);
#ifdef CONFIG_LCD +#ifdef CONFIG_FB_ADDR
- gd->fb_base = CONFIG_FB_ADDR;
+#else /* reserve memory for LCD display (always full pages) */ addr = lcd_setmem (addr); gd->fb_base = addr; +#endif /* CONFIG_FB_ADDR */ #endif /* CONFIG_LCD */
#if defined(CONFIG_VIDEO)&& defined(CONFIG_8xx) diff --git a/doc/README.fb_addr b/doc/README.fb_addr new file mode 100644 index 0000000..ea8bca6 --- /dev/null +++ b/doc/README.fb_addr @@ -0,0 +1,17 @@ +Define CONFIG_FB_ADDR if you want to use specific address for frame buffer. +Then system will reserve the frame buffer address to defined address instead of +lcd_setmem (this function grab the memory for frame buffer by panel's size).
+Please see below code (in board_init_f function from arch/arm/lib/board.c)
+#ifdef CONFIG_FB_ADDR
- gd->fb_base = CONFIG_FB_ADDR;
+#else
- /* reserve memory for LCD display (always full pages) */
- addr = lcd_setmem (addr);
- gd->fb_base = addr;
+#endif /* CONFIG_FB_ADDR */
+If you want this config option then please define it at your board config file
+#define CONFIG_FB_ADDR 0x00000000
Patch does not apply cleanly through git am due to whitespace errors (space before tabs).
Amicalement,
If FB address is defined specific address then don't grab memory for LCD
Signed-off-by: Minkyu Kang mk7.kang@samsung.com Cc: Albert Aribaud albert.aribaud@free.fr Cc: Wolfgang Denk wd@denx.de Cc: Stefan Roese sr@denx.de Cc: Kim Phillips kim.phillips@freescale.com Cc: Andy Fleming afleming@gmail.com Cc: Kumar Gala kumar.gala@freescale.com --- v3 fix whitespace errors v2 add document
arch/arm/lib/board.c | 4 ++++ arch/m68k/lib/board.c | 4 ++++ arch/powerpc/lib/board.c | 4 ++++ doc/README.fb_addr | 17 +++++++++++++++++ 4 files changed, 29 insertions(+), 0 deletions(-) create mode 100644 doc/README.fb_addr
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index c620d2c..5a4d2bd 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -356,9 +356,13 @@ void board_init_f (ulong bootflag) #endif /* CONFIG_VFD */
#ifdef CONFIG_LCD +#ifdef CONFIG_FB_ADDR + gd->fb_base = CONFIG_FB_ADDR; +#else /* reserve memory for LCD display (always full pages) */ addr = lcd_setmem (addr); gd->fb_base = addr; +#endif /* CONFIG_FB_ADDR */ #endif /* CONFIG_LCD */
/* diff --git a/arch/m68k/lib/board.c b/arch/m68k/lib/board.c index 7867ba5..a6cd9b8 100644 --- a/arch/m68k/lib/board.c +++ b/arch/m68k/lib/board.c @@ -277,9 +277,13 @@ board_init_f (ulong bootflag) debug ("Top of RAM usable for U-Boot at: %08lx\n", addr);
#ifdef CONFIG_LCD +#ifdef CONFIG_FB_ADDR + gd->fb_base = CONFIG_FB_ADDR; +#else /* reserve memory for LCD display (always full pages) */ addr = lcd_setmem (addr); gd->fb_base = addr; +#endif /* CONFIG_FB_ADDR */ #endif /* CONFIG_LCD */
/* diff --git a/arch/powerpc/lib/board.c b/arch/powerpc/lib/board.c index b88cf6b..09c20e9 100644 --- a/arch/powerpc/lib/board.c +++ b/arch/powerpc/lib/board.c @@ -453,9 +453,13 @@ void board_init_f (ulong bootflag) debug ("Top of RAM usable for U-Boot at: %08lx\n", addr);
#ifdef CONFIG_LCD +#ifdef CONFIG_FB_ADDR + gd->fb_base = CONFIG_FB_ADDR; +#else /* reserve memory for LCD display (always full pages) */ addr = lcd_setmem (addr); gd->fb_base = addr; +#endif /* CONFIG_FB_ADDR */ #endif /* CONFIG_LCD */
#if defined(CONFIG_VIDEO) && defined(CONFIG_8xx) diff --git a/doc/README.fb_addr b/doc/README.fb_addr new file mode 100644 index 0000000..ea8bca6 --- /dev/null +++ b/doc/README.fb_addr @@ -0,0 +1,17 @@ +Define CONFIG_FB_ADDR if you want to use specific address for frame buffer. +Then system will reserve the frame buffer address to defined address instead of +lcd_setmem (this function grab the memory for frame buffer by panel's size). + +Please see below code (in board_init_f function from arch/arm/lib/board.c) + +#ifdef CONFIG_FB_ADDR + gd->fb_base = CONFIG_FB_ADDR; +#else + /* reserve memory for LCD display (always full pages) */ + addr = lcd_setmem (addr); + gd->fb_base = addr; +#endif /* CONFIG_FB_ADDR */ + +If you want this config option then please define it at your board config file + +#define CONFIG_FB_ADDR 0x00000000
Le 25/03/2011 01:50, Minkyu Kang a écrit :
If FB address is defined specific address then don't grab memory for LCD
Signed-off-by: Minkyu Kangmk7.kang@samsung.com Cc: Albert Aribaudalbert.aribaud@free.fr Cc: Wolfgang Denkwd@denx.de Cc: Stefan Roesesr@denx.de Cc: Kim Phillipskim.phillips@freescale.com Cc: Andy Flemingafleming@gmail.com Cc: Kumar Galakumar.gala@freescale.com
Applied to u-boot-arm/next, thanks.
Amicalement,
Dear Albert,
In message 4D8F6229.5040300@free.fr you wrote:
Le 25/03/2011 01:50, Minkyu Kang a écrit :
If FB address is defined specific address then don't grab memory for LCD
Signed-off-by: Minkyu Kangmk7.kang@samsung.com Cc: Albert Aribaudalbert.aribaud@free.fr Cc: Wolfgang Denkwd@denx.de Cc: Stefan Roesesr@denx.de Cc: Kim Phillipskim.phillips@freescale.com Cc: Andy Flemingafleming@gmail.com Cc: Kumar Galakumar.gala@freescale.com
Applied to u-boot-arm/next, thanks.
Oops. Sorry, but I just added a late review comment.
Best regards,
Wolfgang Denk
Dear Minkyu Kang,
In message 4D8BE6BD.2090101@samsung.com you wrote:
If FB address is defined specific address then don't grab memory for LCD
Signed-off-by: Minkyu Kang mk7.kang@samsung.com Cc: Albert Aribaud albert.aribaud@free.fr Cc: Wolfgang Denk wd@denx.de Cc: Stefan Roese sr@denx.de Cc: Kim Phillips kim.phillips@freescale.com Cc: Andy Fleming afleming@gmail.com Cc: Kumar Gala kumar.gala@freescale.com
...
--- /dev/null +++ b/doc/README.fb_addr @@ -0,0 +1,17 @@ +Define CONFIG_FB_ADDR if you want to use specific address for frame buffer. +Then system will reserve the frame buffer address to defined address instead of +lcd_setmem (this function grab the memory for frame buffer by panel's size).
+Please see below code (in board_init_f function from arch/arm/lib/board.c)
+#ifdef CONFIG_FB_ADDR
- gd->fb_base = CONFIG_FB_ADDR;
+#else
- /* reserve memory for LCD display (always full pages) */
- addr = lcd_setmem (addr);
- gd->fb_base = addr;
+#endif /* CONFIG_FB_ADDR */
+If you want this config option then please define it at your board config file
+#define CONFIG_FB_ADDR 0x00000000
Sorry for the late review, but it makes littel sense to add individual README.* files for each and every CONFIG option. Please add the documentation (with a little less verbocity) to the top level README instead.
Best regards,
Wolfgang Denk
Le 25/04/2011 01:27, Wolfgang Denk a écrit :
Dear Minkyu Kang,
In message4D8BE6BD.2090101@samsung.com you wrote:
If FB address is defined specific address then don't grab memory for LCD
Signed-off-by: Minkyu Kangmk7.kang@samsung.com Cc: Albert Aribaudalbert.aribaud@free.fr Cc: Wolfgang Denkwd@denx.de Cc: Stefan Roesesr@denx.de Cc: Kim Phillipskim.phillips@freescale.com Cc: Andy Flemingafleming@gmail.com Cc: Kumar Galakumar.gala@freescale.com
...
--- /dev/null +++ b/doc/README.fb_addr @@ -0,0 +1,17 @@ +Define CONFIG_FB_ADDR if you want to use specific address for frame buffer. +Then system will reserve the frame buffer address to defined address instead of +lcd_setmem (this function grab the memory for frame buffer by panel's size).
+Please see below code (in board_init_f function from arch/arm/lib/board.c)
+#ifdef CONFIG_FB_ADDR
- gd->fb_base = CONFIG_FB_ADDR;
+#else
- /* reserve memory for LCD display (always full pages) */
- addr = lcd_setmem (addr);
- gd->fb_base = addr;
+#endif /* CONFIG_FB_ADDR */
+If you want this config option then please define it at your board config file
+#define CONFIG_FB_ADDR 0x00000000
Sorry for the late review, but it makes littel sense to add individual README.* files for each and every CONFIG option. Please add the documentation (with a little less verbocity) to the top level README instead.
Minkyu: can you provide an quick-updated patch with the doc in the top level README? I'll rebase and replace accordingly.
Best regards,
Wolfgang Denk
Amicalement,
Dear Albert ARIBAUD,
On 25 April 2011 16:38, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Sorry for the late review, but it makes littel sense to add individual README.* files for each and every CONFIG option. Please add the documentation (with a little less verbocity) to the top level README instead.
Minkyu: can you provide an quick-updated patch with the doc in the top level README? I'll rebase and replace accordingly.
OK. will send v4 patch.
Thanks. Minkyu Kang
If FB address is defined specific address then don't grab memory for LCD
Signed-off-by: Minkyu Kang mk7.kang@samsung.com Cc: Albert Aribaud albert.aribaud@free.fr Cc: Wolfgang Denk wd@denx.de Cc: Stefan Roese sr@denx.de Cc: Kim Phillips kim.phillips@freescale.com Cc: Andy Fleming afleming@gmail.com Cc: Kumar Gala kumar.gala@freescale.com --- v4 move the document v3 fix whitespace errors v2 add document
README | 14 ++++++++++++++ arch/arm/lib/board.c | 4 ++++ arch/m68k/lib/board.c | 4 ++++ arch/powerpc/lib/board.c | 4 ++++ 4 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/README b/README index beb1cbb..c5533b4 100644 --- a/README +++ b/README @@ -2009,6 +2009,20 @@ The following options need to be configured: thus overwriting the architecutre dependent default settings.
+- Frame Buffer Address: + CONFIG_FB_ADDR + + Define CONFIG_FB_ADDR if you want to use specific address for + frame buffer. + Then system will reserve the frame buffer address to defined address + instead of lcd_setmem (this function grab the memory for frame buffer + by panel's size). + + Please see board_init_f function. + + If you want this config option then, + please define it at your board config file + Legacy uImage format:
Arg Where When diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index dc46e21..db13ad1 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -356,9 +356,13 @@ void board_init_f (ulong bootflag) #endif /* CONFIG_VFD */
#ifdef CONFIG_LCD +#ifdef CONFIG_FB_ADDR + gd->fb_base = CONFIG_FB_ADDR; +#else /* reserve memory for LCD display (always full pages) */ addr = lcd_setmem (addr); gd->fb_base = addr; +#endif /* CONFIG_FB_ADDR */ #endif /* CONFIG_LCD */
/* diff --git a/arch/m68k/lib/board.c b/arch/m68k/lib/board.c index f824b34..6a892db 100644 --- a/arch/m68k/lib/board.c +++ b/arch/m68k/lib/board.c @@ -277,9 +277,13 @@ board_init_f (ulong bootflag) debug ("Top of RAM usable for U-Boot at: %08lx\n", addr);
#ifdef CONFIG_LCD +#ifdef CONFIG_FB_ADDR + gd->fb_base = CONFIG_FB_ADDR; +#else /* reserve memory for LCD display (always full pages) */ addr = lcd_setmem (addr); gd->fb_base = addr; +#endif /* CONFIG_FB_ADDR */ #endif /* CONFIG_LCD */
/* diff --git a/arch/powerpc/lib/board.c b/arch/powerpc/lib/board.c index 83fb074..aaa5add 100644 --- a/arch/powerpc/lib/board.c +++ b/arch/powerpc/lib/board.c @@ -459,9 +459,13 @@ void board_init_f (ulong bootflag) debug ("Top of RAM usable for U-Boot at: %08lx\n", addr);
#ifdef CONFIG_LCD +#ifdef CONFIG_FB_ADDR + gd->fb_base = CONFIG_FB_ADDR; +#else /* reserve memory for LCD display (always full pages) */ addr = lcd_setmem (addr); gd->fb_base = addr; +#endif /* CONFIG_FB_ADDR */ #endif /* CONFIG_LCD */
#if defined(CONFIG_VIDEO) && defined(CONFIG_8xx)
participants (5)
-
Albert ARIBAUD -
Albert ARIBAUD -
Minkyu Kang -
Minkyu Kang -
Wolfgang Denk