[U-Boot-Users] [PATCH] Correct NAND erase percentage output

For NAND erase sizes smaller than one NAND erase block, erase percentage output becomes grater than 100% e.g.
-- cut --
nand info
Device 0: NAND 64MiB 1,8V 8-bit, sector size 16 KiB
nand erase 0x100000 0x2000
NAND erase: device 0 offset 0x100000, size 0x2000 Erasing at 0x100000 -- 200% complete. OK
-- cut --
Correct this and give user a warning that more is erased than specified:
-- cut --
nand erase 0x100000 0x2000
NAND erase: device 0 offset 0x100000, size 0x2000 Warning: Erase size 0x00002000 smaller than one erase block 0x00004000 Erasing 0x00004000 instead Erasing at 0x100000 -- 100% complete. OK
-- cut --
This patch is against u-boot-nand-flash.git.
Signed-off-by: Dirk Behme dirk.behme@gmail.com
--- drivers/mtd/nand/nand_util.c_orig 2008-01-14 21:13:10.000000000 +0100 +++ drivers/mtd/nand/nand_util.c 2008-01-14 21:46:53.000000000 +0100 @@ -153,6 +153,13 @@ int nand_erase_opts(nand_info_t *meminfo priv_nand->bbt = NULL; }
+ if(erase_length < meminfo->erasesize) { + printf("Warning: Erase size 0x%08x smaller than one " \ + "erase block 0x%08x\n",erase_length, meminfo->erasesize); + printf(" Erasing 0x%08x instead\n", meminfo->erasesize); + erase_length = meminfo->erasesize; + } + for (; erase.addr < opts->offset + erase_length; erase.addr += meminfo->erasesize) {

On Mon, 14 Jan 2008, Dirk Behme wrote:
Aha! Here it is... :)
For NAND erase sizes smaller than one NAND erase block, erase percentage output becomes grater than 100% e.g.
-- cut --
nand info
Device 0: NAND 64MiB 1,8V 8-bit, sector size 16 KiB
nand erase 0x100000 0x2000
NAND erase: device 0 offset 0x100000, size 0x2000 Erasing at 0x100000 -- 200% complete. OK
-- cut --
Correct this and give user a warning that more is erased than specified:
-- cut --
nand erase 0x100000 0x2000
NAND erase: device 0 offset 0x100000, size 0x2000 Warning: Erase size 0x00002000 smaller than one erase block 0x00004000 Erasing 0x00004000 instead Erasing at 0x100000 -- 100% complete. OK
-- cut --
This patch is against u-boot-nand-flash.git.
Signed-off-by: Dirk Behme dirk.behme@gmail.com
--- ****************************************************************** * KSI@home KOI8 Net < > The impossible we do immediately. * * Las Vegas NV, USA < > Miracles require 24-hour notice. * ******************************************************************

Hi Dirk,
On Monday 14 January 2008, Dirk Behme wrote:
For NAND erase sizes smaller than one NAND erase block, erase percentage output becomes grater than 100% e.g.
Applied to new "mtd-2.6.22.1" branch. Will push to git server in a short while.
Thanks.
Dirk, better would be if you could post your patches inlined instead of attached. I suggest to use "git-send-email" which makes life easy for you and me. :)
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================
participants (3)
-
Dirk Behme
-
ksi@koi8.net
-
Stefan Roese