[U-Boot] [POWERPC] mgcoge: correct init of the UPIOx
Signed-off-by: Heiko Schocher hs@denx.de --- board/keymile/mgcoge/mgcoge.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/board/keymile/mgcoge/mgcoge.c b/board/keymile/mgcoge/mgcoge.c index 31703ab..099e77b 100644 --- a/board/keymile/mgcoge/mgcoge.c +++ b/board/keymile/mgcoge/mgcoge.c @@ -296,7 +296,7 @@ int board_early_init_r (void) { /* setup the UPIOx */ *(char *)(CFG_PIGGY_BASE + 0x02) = 0xc0; - *(char *)(CFG_PIGGY_BASE + 0x03) = 0x15; + *(char *)(CFG_PIGGY_BASE + 0x03) = 0x35; return 0; }
Dear Heiko Schocher,
In message 48F75168.1040806@denx.de you wrote:
Signed-off-by: Heiko Schocher hs@denx.de
board/keymile/mgcoge/mgcoge.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/board/keymile/mgcoge/mgcoge.c b/board/keymile/mgcoge/mgcoge.c index 31703ab..099e77b 100644 --- a/board/keymile/mgcoge/mgcoge.c +++ b/board/keymile/mgcoge/mgcoge.c @@ -296,7 +296,7 @@ int board_early_init_r (void) { /* setup the UPIOx */ *(char *)(CFG_PIGGY_BASE + 0x02) = 0xc0;
- *(char *)(CFG_PIGGY_BASE + 0x03) = 0x15;
- *(char *)(CFG_PIGGY_BASE + 0x03) = 0x35; return 0;
}
Umm... no.
Please change all this code to use the appropriate accesor functions instead (these pointers are not even volatile - shudder...).
Best regards,
Wolfgang Denk
participants (2)
-
Heiko Schocher -
Wolfgang Denk