[U-Boot] [PATCH v3 1/1] gpio: altera_pio: fix get_value
gpio_get_value should return 0 or 1, not the value of bit & (1 << pin)
Acked-by: Marek Vasut marex@denx.de Signed-off-by: Julien Beraud julien.beraud@orolia.com --- drivers/gpio/altera_pio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/altera_pio.c b/drivers/gpio/altera_pio.c index 59e30979f0..324f9c29a8 100644 --- a/drivers/gpio/altera_pio.c +++ b/drivers/gpio/altera_pio.c @@ -56,7 +56,7 @@ static int altera_pio_get_value(struct udevice *dev, unsigned pin) struct altera_pio_platdata *plat = dev_get_platdata(dev); struct altera_pio_regs *const regs = plat->regs;
- return readl(®s->data) & (1 << pin); + return !!(readl(®s->data) & (1 << pin)); }
On 1/7/19 10:17 AM, Julien Béraud wrote:
gpio_get_value should return 0 or 1, not the value of bit & (1 << pin)
Acked-by: Marek Vasut marex@denx.de Signed-off-by: Julien Beraud julien.beraud@orolia.com
btw. you should keep a changelog with each new Vx of a patch. Here it's fine, just add one next time you submit patches.
drivers/gpio/altera_pio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/altera_pio.c b/drivers/gpio/altera_pio.c index 59e30979f0..324f9c29a8 100644 --- a/drivers/gpio/altera_pio.c +++ b/drivers/gpio/altera_pio.c @@ -56,7 +56,7 @@ static int altera_pio_get_value(struct udevice *dev, unsigned pin) struct altera_pio_platdata *plat = dev_get_platdata(dev); struct altera_pio_regs *const regs = plat->regs;
- return readl(®s->data) & (1 << pin);
- return !!(readl(®s->data) & (1 << pin));
}
On 07/01/2019 10:27, Julien Beraud wrote:
On 07/01/2019 10:26, Marek Vasut wrote:
btw. you should keep a changelog with each new Vx of a patch. Here it's fine, just add one next time you submit patches.
Sure, I'll do it next time. Thanks.
Julien
Hi Marek,
I can see on https://patchwork.ozlabs.org/patch/1021221/ that the patch has been delegated to you. Though I assume you were thinking someone else would apply, may I ask you to apply it ?
Regards, Julien
On 2/20/19 4:13 PM, Julien Béraud wrote:
On 07/01/2019 10:27, Julien Beraud wrote:
On 07/01/2019 10:26, Marek Vasut wrote:
btw. you should keep a changelog with each new Vx of a patch. Here it's fine, just add one next time you submit patches.
Sure, I'll do it next time. Thanks.
Julien
Hi Marek,
I can see on https://patchwork.ozlabs.org/patch/1021221/ that the patch has been delegated to you. Though I assume you were thinking someone else would apply, may I ask you to apply it ?
Applied, thanks for the reminder
participants (2)
-
Julien Béraud -
Marek Vasut