Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

Dear Huang Changming-R66093,
Reposting _AGAIN_ because you again discarded the U-Boot ML address.
Best Regards Jerry Huang
Can you please fix your mailer?
-----Original Message----- From: Marek Vasut [mailto:marex@denx.de] Sent: Thursday, November 01, 2012 10:26 AM To: Huang Changming-R66093 Cc: Andy Fleming; u-boot@linux.freescale.net Subject: Re: [PATCH] powerpc/esdhc: force the bus width to 4bit
Dear Huang Changming-R66093,
Andy, Do you agree my suggest to revert these codes to fix this issue?
Please ... do us all a favor, read [1] and stop being so inconsiderate of others! Given that I can no longer make any sense of this thread because of your top-posting making it complete utmost mess, my opinion is NAK on reverting them.
Then, could you give some suggest, how to fix the 12bit-width issue?
see drivers/mmc/mmc.c:
1089 width = ((mmc->host_caps & MMC_MODE_MASK_WIDTH_BITS) >> 1090 MMC_MODE_WIDTH_BITS_SHIFT);
Fix this snipped of code and the related code below ... that's the way to go about it.
Best regards, Marek Vasut

-----Original Message----- From: Marek Vasut [mailto:marex@denx.de] Sent: Thursday, November 01, 2012 11:06 AM To: Huang Changming-R66093 Cc: Andy Fleming; u-boot@linux.freescale.net; u-boot@lists.denx.de Subject: Re: [PATCH] powerpc/esdhc: force the bus width to 4bit
Dear Huang Changming-R66093,
Reposting _AGAIN_ because you again discarded the U-Boot ML address.
I don't know why, I replied to all, not discard any address.
-----Original Message----- From: Marek Vasut [mailto:marex@denx.de] Sent: Thursday, November 01, 2012 10:26 AM To: Huang Changming-R66093 Cc: Andy Fleming; u-boot@linux.freescale.net Subject: Re: [PATCH] powerpc/esdhc: force the bus width to 4bit
Dear Huang Changming-R66093,
Andy, Do you agree my suggest to revert these codes to fix this issue?
Please ... do us all a favor, read [1] and stop being so inconsiderate of others! Given that I can no longer make any sense of this thread because of your top-posting making it complete utmost mess, my opinion is NAK on reverting them.
Then, could you give some suggest, how to fix the 12bit-width issue?
see drivers/mmc/mmc.c:
1089 width = ((mmc->host_caps & MMC_MODE_MASK_WIDTH_BITS) >> 1090 MMC_MODE_WIDTH_BITS_SHIFT);
Fix this snipped of code and the related code below ... that's the way to go about it.
Yes, I can change these codes to: Width = EXT_CSD_BUS_WIDTH_8;
Then, first value of width will be 2.
But, those modification is I said, the codes is reverted to the old codes.
participants (2)
-
Huang Changming-R66093
-
Marek Vasut