[U-Boot] [PATCH] add common.h include to stdio_dev.h
stdio_dev.h references uchar which is defined in common.h and causes build failures on toolchains which have tightened build flags such as Fedora 28. This was causing build failures on devices such as Xilinx zynqmp targets which include stdio_dev.h via FPGA drivers.
Signed-off-by: Peter Robinson pbrobinson@gmail.com --- include/stdio_dev.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/include/stdio_dev.h b/include/stdio_dev.h index 3164fa2a55..eed4385100 100644 --- a/include/stdio_dev.h +++ b/include/stdio_dev.h @@ -8,6 +8,7 @@ #ifndef _STDIO_DEV_H_ #define _STDIO_DEV_H_
+#include <common.h> #include <linux/list.h>
/*
On Wed, May 02, 2018 at 10:59:12AM +0100, Peter Robinson wrote:
stdio_dev.h references uchar which is defined in common.h and causes build failures on toolchains which have tightened build flags such as Fedora 28. This was causing build failures on devices such as Xilinx zynqmp targets which include stdio_dev.h via FPGA drivers.
Signed-off-by: Peter Robinson pbrobinson@gmail.com
include/stdio_dev.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/include/stdio_dev.h b/include/stdio_dev.h index 3164fa2a55..eed4385100 100644 --- a/include/stdio_dev.h +++ b/include/stdio_dev.h @@ -8,6 +8,7 @@ #ifndef _STDIO_DEV_H_ #define _STDIO_DEV_H_
+#include <common.h> #include <linux/list.h>
/*
I have an alternative fix in progress here: https://travis-ci.org/trini/u-boot/builds/373883559 as it looks like the section in question is just unused now.
On Wed, May 2, 2018 at 12:24 PM, Tom Rini trini@konsulko.com wrote:
On Wed, May 02, 2018 at 10:59:12AM +0100, Peter Robinson wrote:
stdio_dev.h references uchar which is defined in common.h and causes build failures on toolchains which have tightened build flags such as Fedora 28. This was causing build failures on devices such as Xilinx zynqmp targets which include stdio_dev.h via FPGA drivers.
Signed-off-by: Peter Robinson pbrobinson@gmail.com
include/stdio_dev.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/include/stdio_dev.h b/include/stdio_dev.h index 3164fa2a55..eed4385100 100644 --- a/include/stdio_dev.h +++ b/include/stdio_dev.h @@ -8,6 +8,7 @@ #ifndef _STDIO_DEV_H_ #define _STDIO_DEV_H_
+#include <common.h> #include <linux/list.h>
/*
I have an alternative fix in progress here: https://travis-ci.org/trini/u-boot/builds/373883559 as it looks like the section in question is just unused now.
Cool, works for me if it builds ;-)
participants (2)
-
Peter Robinson -
Tom Rini