[PATCH v2 0/2] x86: p2sb: P2SB fixes
Currently it is possible to select the P2SB driver without selecting the P2SB uclass, which can't work. Fix this by adding a "depends on" in Kconfig.
While at it, correct the meaning of P2SB (according to Intel's documentation P2SB stands for "Primary to Sideband Bridge").
Remark: I have resent this series as V2 as I had messed up the cover letter in V1.
Changes in v2: - Fixed cover letter
Wolfgang Wallner (2): drivers: p2sb: replace Primary-to-Sideband Bus with Primary to Sideband Bridge x86: p2sb: make P2SB driver depend on P2SB uclass
arch/x86/Kconfig | 1 + drivers/misc/Kconfig | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-)
In Intel's documentation the term P2SB stands for "Primary to Sideband Bridge".
Signed-off-by: Wolfgang Wallner wolfgang.wallner@br-automation.com ---
(no changes since v1)
drivers/misc/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 6bb5bc77e9..b6b8510e40 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -243,10 +243,10 @@ config NUVOTON_NCT6102D in the Nuvoton Super IO chips on X86 platforms.
config P2SB - bool "Intel Primary-to-Sideband Bus" + bool "Intel Primary to Sideband Bridge" depends on X86 || SANDBOX help - This enables support for the Intel Primary-to-Sideband bus, + This enables support for the Intel Primary to Sideband Bridge, abbreviated to P2SB. The P2SB is used to access various peripherals such as eSPI, GPIO, through memory-mapped I/O in a large chunk of PCI space. The space is segmented into different channels and peripherals @@ -259,7 +259,7 @@ config SPL_P2SB bool "Intel Primary-to-Sideband Bus in SPL" depends on SPL && (X86 || SANDBOX) help - The Primary-to-Sideband bus is used to access various peripherals + The Primary to Sideband Bridge is used to access various peripherals through memory-mapped I/O in a large chunk of PCI space. The space is segmented into different channels and peripherals are accessed by device-specific means within those channels. Devices should be added @@ -269,7 +269,7 @@ config TPL_P2SB bool "Intel Primary-to-Sideband Bus in TPL" depends on TPL && (X86 || SANDBOX) help - The Primary-to-Sideband bus is used to access various peripherals + The Primary to Sideband Bridge is used to access various peripherals through memory-mapped I/O in a large chunk of PCI space. The space is segmented into different channels and peripherals are accessed by device-specific means within those channels. Devices should be added
Currently it is possible to select the P2SB driver without selecting the P2SB uclass, which can't work. Fix this by adding a "depends on" in Kconfig.
Signed-off-by: Wolfgang Wallner wolfgang.wallner@br-automation.com
---
Changes in v2: - Fixed cover letter
arch/x86/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index c8eae24c07..27295ef384 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -717,6 +717,7 @@ config HAVE_ITSS
config HAVE_P2SB bool "Enable P2SB" + depends on P2SB help Select this to include the driver for the Primary to Sideband Bridge (P2SB) which is found on several Intel
Hi Wolfgang,
On Wed, Jul 1, 2020 at 5:06 PM Wolfgang Wallner wolfgang.wallner@br-automation.com wrote:
Currently it is possible to select the P2SB driver without selecting the P2SB uclass, which can't work. Fix this by adding a "depends on" in Kconfig.
While at it, correct the meaning of P2SB (according to Intel's documentation P2SB stands for "Primary to Sideband Bridge").
Remark: I have resent this series as V2 as I had messed up the cover letter in V1.
Changes in v2:
- Fixed cover letter
Is this series needed for v2020.07? Does this break anything?
Regards, Bin
Hi Bin,
-----"Bin Meng" bmeng.cn@gmail.com schrieb: -----
Betreff: Re: [PATCH v2 0/2] x86: p2sb: P2SB fixes
Hi Wolfgang,
On Wed, Jul 1, 2020 at 5:06 PM Wolfgang Wallner wolfgang.wallner@br-automation.com wrote:
Currently it is possible to select the P2SB driver without selecting the P2SB uclass, which can't work. Fix this by adding a "depends on" in Kconfig.
While at it, correct the meaning of P2SB (according to Intel's documentation P2SB stands for "Primary to Sideband Bridge").
Remark: I have resent this series as V2 as I had messed up the cover letter in V1.
Changes in v2:
- Fixed cover letter
Is this series needed for v2020.07? Does this break anything?
No, it is not needed for v2020.07. This patch is only a precaution to avoid creating configs that won't work.
regards, Wolfgang
participants (2)
-
Bin Meng -
Wolfgang Wallner