[U-Boot] [PATCH] powerpc/t208x: enable command MEMTEST DDR_INTERACTIVE EEPROM
Enable CONFIG_CMD_MEMTEST, CONFIG_FSL_DDR_INTERACTIVE, CONFIG_CMD_EEPROM
Signed-off-by: Shengzhou Liu Shengzhou.Liu@freescale.com --- include/configs/T208xQDS.h | 6 +++++- include/configs/T208xRDB.h | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/include/configs/T208xQDS.h b/include/configs/T208xQDS.h index 7c5f57c..c9ac9a5 100644 --- a/include/configs/T208xQDS.h +++ b/include/configs/T208xQDS.h @@ -163,13 +163,15 @@ unsigned long get_board_ddr_clk(void); #define CONFIG_CHIP_SELECTS_PER_CTRL (4 * CONFIG_DIMM_SLOTS_PER_CTLR) #define CONFIG_DDR_SPD #define CONFIG_SYS_FSL_DDR3 -#undef CONFIG_FSL_DDR_INTERACTIVE +#define CONFIG_FSL_DDR_INTERACTIVE #define CONFIG_SYS_SPD_BUS_NUM 0 #define CONFIG_SYS_SDRAM_SIZE 2048 /* for fixed parameter use */ #define SPD_EEPROM_ADDRESS1 0x51 #define SPD_EEPROM_ADDRESS2 0x52 #define SPD_EEPROM_ADDRESS SPD_EEPROM_ADDRESS1 #define CTRL_INTLV_PREFERED cacheline +#define CONFIG_SYS_MEMTEST_START 0x01000000 /* memtest works on */ +#define CONFIG_SYS_MEMTEST_END 0x01ffffff
/* * IFC Definitions @@ -679,6 +681,8 @@ unsigned long get_board_ddr_clk(void); #define CONFIG_CMD_I2C #define CONFIG_CMD_MII #define CONFIG_CMD_PING +#define CONFIG_CMD_MEMTEST +#define CONFIG_CMD_EEPROM #define CONFIG_CMD_SETEXPR #define CONFIG_CMD_REGINFO #define CONFIG_CMD_BDI diff --git a/include/configs/T208xRDB.h b/include/configs/T208xRDB.h index 1db8bea..de4d6dc 100644 --- a/include/configs/T208xRDB.h +++ b/include/configs/T208xRDB.h @@ -152,13 +152,15 @@ unsigned long get_board_ddr_clk(void); #define CONFIG_CHIP_SELECTS_PER_CTRL (4 * CONFIG_DIMM_SLOTS_PER_CTLR) #define CONFIG_DDR_SPD #define CONFIG_SYS_FSL_DDR3 -#undef CONFIG_FSL_DDR_INTERACTIVE +#define CONFIG_FSL_DDR_INTERACTIVE #define CONFIG_SYS_SPD_BUS_NUM 0 #define CONFIG_SYS_SDRAM_SIZE 2048 /* for fixed parameter use */ #define SPD_EEPROM_ADDRESS1 0x51 #define SPD_EEPROM_ADDRESS2 0x52 #define SPD_EEPROM_ADDRESS SPD_EEPROM_ADDRESS1 #define CTRL_INTLV_PREFERED cacheline +#define CONFIG_SYS_MEMTEST_START 0x01000000 /* memtest works on */ +#define CONFIG_SYS_MEMTEST_END 0x01ffffff
/* * IFC Definitions @@ -631,6 +633,8 @@ unsigned long get_board_ddr_clk(void); #define CONFIG_CMD_I2C #define CONFIG_CMD_PING #define CONFIG_CMD_ECHO +#define CONFIG_CMD_MEMTEST +#define CONFIG_CMD_EEPROM #define CONFIG_CMD_SETEXPR #define CONFIG_CMD_REGINFO #define CONFIG_CMD_BDI
On Mar 12, 2014, at 8:17 PM, Shengzhou Liu wrote:
Enable CONFIG_CMD_MEMTEST, CONFIG_FSL_DDR_INTERACTIVE, CONFIG_CMD_EEPROM
I can see the ddr debugging and eeprom command are useful. But I am not convinced memtest is effective as it is intended to be. There was a discussion a while ago. As for the ddr debugging, do you need it enabled by default? I am not against the idea to have it because I debug DDR a lot. But I doubt if it is useful for developers who don't care the detail about DDR.
York
Dear York Sun,
In message 88C8C779-B636-4ABF-9751-33E4713074FB@freescale.com you wrote:
On Mar 12, 2014, at 8:17 PM, Shengzhou Liu wrote:
Enable CONFIG_CMD_MEMTEST, CONFIG_FSL_DDR_INTERACTIVE, CONFIG_CMD_EEPROM
I can see the ddr debugging and eeprom command are useful. But I am not convinced memtest is effective as it is intended to be. There was a discussion a while ago.
Except for some very specific cases (like watching signals on a scope while running the test) memtest is almost totally worthless.
Best regards,
Wolfgang Denk
On 03/13/2014 12:10 AM, Wolfgang Denk wrote:
Dear York Sun,
In message 88C8C779-B636-4ABF-9751-33E4713074FB@freescale.com you wrote:
On Mar 12, 2014, at 8:17 PM, Shengzhou Liu wrote:
Enable CONFIG_CMD_MEMTEST, CONFIG_FSL_DDR_INTERACTIVE, CONFIG_CMD_EEPROM
I can see the ddr debugging and eeprom command are useful. But I am not convinced memtest is effective as it is intended to be. There was a discussion a while ago.
Except for some very specific cases (like watching signals on a scope while running the test) memtest is almost totally worthless.
Wolfgang,
Thanks. I will info our internal team to phase out memtest.
York
participants (3)
-
Shengzhou Liu -
Wolfgang Denk -
York Sun