[U-Boot] Pull request u-boot-marvell.git

Hi Tom
Pls pull the following
The following changes since commit 1b063b552e815f90a6a880e78fc40cc309dd52ad: Anders Darander (1): Add bootcount to AT91
are available in the git repository at:
http://git.denx.de/u-boot/u-boot-marvell.git master branch
Heiko Schocher (1): arm: add support for the suen3 board from keymile
MAINTAINERS | 2 +- MAKEALL | 1 + Makefile | 3 + board/keymile/common/common.c | 6 +- board/keymile/km_arm/Makefile | 51 ++++++ board/keymile/km_arm/config.mk | 28 ++++ board/keymile/km_arm/km_arm.c | 324 +++++++++++++++++++++++++++++++++++++ board/keymile/km_arm/kwbimage.cfg | 176 ++++++++++++++++++++ include/configs/km_arm.h | 191 ++++++++++++++++++++++ include/configs/suen3.h | 103 ++++++++++++ 10 files changed, 882 insertions(+), 3 deletions(-) create mode 100644 board/keymile/km_arm/Makefile create mode 100644 board/keymile/km_arm/config.mk create mode 100644 board/keymile/km_arm/km_arm.c create mode 100644 board/keymile/km_arm/kwbimage.cfg create mode 100644 include/configs/km_arm.h create mode 100644 include/configs/suen3.h
Regards.. Prafulla . .

Prafulla Wadaskar wrote:
Hi Tom
Pls pull the following
The following changes since commit 1b063b552e815f90a6a880e78fc40cc309dd52ad: Anders Darander (1): Add bootcount to AT91
are available in the git repository at:
http://git.denx.de/u-boot/u-boot-marvell.git master branch
Heiko Schocher (1): arm: add support for the suen3 board from keymile
For the regression test, I get a failure to build error. This must be fixed. Other warnings should also be fixed.
Tom
jffs2_1pass.c: In function 'get_fl_mem': jffs2_1pass.c:399: warning: unused variable 'id' jffs2_1pass.c: In function 'get_node_mem': jffs2_1pass.c:423: warning: unused variable 'id' kirkwood_egiga.c: In function 'kwgbe_init': kirkwood_egiga.c:448: warning: dereferencing type-punned pointer will break strict-aliasing rules kirkwood_egiga.c: In function 'kwgbe_recv': kirkwood_egiga.c:609: warning: dereferencing type-punned pointer will break strict-aliasing rules Assembler messages: Fatal error: can't create .../build/board/keymile/km_arm/../common/common.o: No such file or directory make[1]: *** [.../build/board/keymile/km_arm/../common/common.o] Error 2 make: *** [.../build/board/keymile/km_arm/libkm_arm.a] Error 2
The '...' is my reduction of path T

Hello Tom,
Tom wrote:
Prafulla Wadaskar wrote:
Hi Tom
Pls pull the following
The following changes since commit 1b063b552e815f90a6a880e78fc40cc309dd52ad: Anders Darander (1): Add bootcount to AT91
are available in the git repository at:
http://git.denx.de/u-boot/u-boot-marvell.git master branch
Heiko Schocher (1): arm: add support for the suen3 board from keymile
For the regression test, I get a failure to build error. This must be fixed.
Yes, you are right, good catch. The following patch will help:
diff --git a/board/keymile/km_arm/Makefile b/board/keymile/km_arm/Makefile index fffc6a3..c5b0be1 100644 --- a/board/keymile/km_arm/Makefile +++ b/board/keymile/km_arm/Makefile @@ -23,6 +23,9 @@ #
include $(TOPDIR)/config.mk +ifneq ($(OBJTREE),$(SRCTREE)) +$(shell mkdir -p $(obj)../common) +endif
LIB = $(obj)lib$(BOARD).a
Should I make a new version of the "arm: add support for the suen3 board from keymile" patch, or a patch based on the actual
git://git.denx.de/u-boot-marvell.git ?
bye Heiko

Heiko Schocher wrote:
Hello Tom,
Tom wrote:
Prafulla Wadaskar wrote:
Hi Tom
Pls pull the following
The following changes since commit 1b063b552e815f90a6a880e78fc40cc309dd52ad: Anders Darander (1): Add bootcount to AT91
are available in the git repository at:
http://git.denx.de/u-boot/u-boot-marvell.git master branch
Heiko Schocher (1): arm: add support for the suen3 board from keymile
For the regression test, I get a failure to build error. This must be fixed.
Yes, you are right, good catch. The following patch will help:
diff --git a/board/keymile/km_arm/Makefile b/board/keymile/km_arm/Makefile index fffc6a3..c5b0be1 100644 --- a/board/keymile/km_arm/Makefile +++ b/board/keymile/km_arm/Makefile @@ -23,6 +23,9 @@ #
include $(TOPDIR)/config.mk +ifneq ($(OBJTREE),$(SRCTREE)) +$(shell mkdir -p $(obj)../common) +endif
LIB = $(obj)lib$(BOARD).a
Should I make a new version of the "arm: add support for the suen3 board from keymile" patch, or a patch based on the actual
git://git.denx.de/u-boot-marvell.git ?
Please just the much smaller 'Compiler fix.. ' patch. Thanks, Tom
bye Heiko

Signed-off-by: Heiko Schocher hs@denx.de ---
Patch against current git://git.denx.de/u-boot-marvell.git
board/keymile/km_arm/Makefile | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/board/keymile/km_arm/Makefile b/board/keymile/km_arm/Makefile index fffc6a3..c5b0be1 100644 --- a/board/keymile/km_arm/Makefile +++ b/board/keymile/km_arm/Makefile @@ -23,6 +23,9 @@ #
include $(TOPDIR)/config.mk +ifneq ($(OBJTREE),$(SRCTREE)) +$(shell mkdir -p $(obj)../common) +endif
LIB = $(obj)lib$(BOARD).a

Heiko Schocher wrote:
Signed-off-by: Heiko Schocher hs@denx.de
Patch against current git://git.denx.de/u-boot-marvell.git
board/keymile/km_arm/Makefile | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
This fixes the build errors. There are still some compile warnings wrt dereferencing pointers. Do you have a fix for these?
Prafulla, Are you ok with me pushing this directly to ARM ?
Tom
diff --git a/board/keymile/km_arm/Makefile b/board/keymile/km_arm/Makefile index fffc6a3..c5b0be1 100644 --- a/board/keymile/km_arm/Makefile +++ b/board/keymile/km_arm/Makefile @@ -23,6 +23,9 @@ #
include $(TOPDIR)/config.mk +ifneq ($(OBJTREE),$(SRCTREE)) +$(shell mkdir -p $(obj)../common) +endif
LIB = $(obj)lib$(BOARD).a

-----Original Message----- From: Tom [mailto:Tom.Rix@windriver.com] Sent: Wednesday, March 03, 2010 2:55 AM To: hs@denx.de; Prafulla Wadaskar Cc: u-boot@lists.denx.de Subject: Re: [PATCH] arm, suen3: fix compile error, if doing not a local build
Heiko Schocher wrote:
Signed-off-by: Heiko Schocher hs@denx.de
Patch against current git://git.denx.de/u-boot-marvell.git
board/keymile/km_arm/Makefile | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
This fixes the build errors. There are still some compile warnings wrt dereferencing pointers. Do you have a fix for these?
For the warnings in kirkwood_egiga.c, I am posting a patch soon
Prafulla, Are you ok with me pushing this directly to ARM ?
Sure, no issues
Regards.. Prafulla . .

-----Original Message----- From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Prafulla Wadaskar Sent: Wednesday, March 03, 2010 10:07 AM To: Tom; hs@denx.de Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] arm, suen3: fix compile error, if doing not a local build
-----Original Message----- From: Tom [mailto:Tom.Rix@windriver.com] Sent: Wednesday, March 03, 2010 2:55 AM To: hs@denx.de; Prafulla Wadaskar Cc: u-boot@lists.denx.de Subject: Re: [PATCH] arm, suen3: fix compile error, if doing not a local build
Heiko Schocher wrote:
Signed-off-by: Heiko Schocher hs@denx.de
Patch against current git://git.denx.de/u-boot-marvell.git
board/keymile/km_arm/Makefile | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
This fixes the build errors. There are still some compile warnings wrt dereferencing pointers. Do you have a fix for these?
For the warnings in kirkwood_egiga.c, I am posting a patch soon
Hi Ben I have posted patch fix patch for this, that should go to net repository. http://lists.denx.de/pipermail/u-boot/2010-March/068201.html
Hi Tom Also I have posted a patch for build warning fix for suen3 board. http://lists.denx.de/pipermail/u-boot/2010-March/068202.html You may push this patch directly to ARM, or suggest if I should provide you pull request.
Regards.. Prafulla . .

Prafulla Wadaskar wrote:
-----Original Message----- From: Tom [mailto:Tom.Rix@windriver.com] Sent: Wednesday, March 03, 2010 2:55 AM To: hs@denx.de; Prafulla Wadaskar Cc: u-boot@lists.denx.de Subject: Re: [PATCH] arm, suen3: fix compile error, if doing not a local build
Heiko Schocher wrote:
Signed-off-by: Heiko Schocher hs@denx.de
Patch against current git://git.denx.de/u-boot-marvell.git
board/keymile/km_arm/Makefile | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
This fixes the build errors. There are still some compile warnings wrt dereferencing pointers. Do you have a fix for these?
For the warnings in kirkwood_egiga.c, I am posting a patch soon
Prafulla, Are you ok with me pushing this directly to ARM ?
I have applied the marvell pull request and this patch to ARM. Thanks Tom
Sure, no issues
Regards.. Prafulla . .
participants (3)
-
Heiko Schocher
-
Prafulla Wadaskar
-
Tom